70 Commits

Author SHA1 Message Date
TomasVotruba
7a5e0a446e fix foreach variable override in const decoupling 2020-07-12 10:36:33 +02:00
TomasVotruba
9d938daffb use early return 2020-07-05 02:07:55 +02:00
TomasVotruba
f00eb1c7b7 skip inversion of weak comparison 2020-07-05 01:58:13 +02:00
derrickschoen
4d5003c9bd BooleanAnd is not the inverse of BooleanOr 2020-07-05 01:28:05 +02:00
derrickschoen
169d075f97 BooleanAnd is not the inverse of BooleanOr 2020-07-05 01:28:05 +02:00
Derrick Schoen
09fd6fee8a Found a bug where if there is a nested if with an "OR" and all conditions evaluate to true, the rector changes the output.
When calling invertCondition() with a BooleanOr, it returns a BooleanAnd that needs a BooleanNot added.

Attempting to rebase and squanch to one commit.
2020-07-05 01:28:05 +02:00
TomasVotruba
9327cffa0e [SOLID] Prevent adding constant, that is reserved keyword in RepeatedLiteralToClassConstantRector 2020-07-02 00:45:01 +02:00
TomasVotruba
52acc54005 merge PropertyNaming to one class 2020-07-01 23:42:23 +02:00
TomasVotruba
a8a6e7bcad rename file to fileInfo 2020-06-30 01:45:05 +02:00
TomasVotruba
547e15099d use explicit xBuilder classes to prevent typos and PHPStan and PHPStorm confussion 2020-06-30 01:34:19 +02:00
TomasVotruba
0cb82c2a6f apply new Naming_ 2020-06-30 00:57:38 +02:00
TomasVotruba
7f49658112 change test(string ) to test(SmartFileInfo ) in tests 2020-06-25 20:02:36 +02:00
TomasVotruba
05d01aa455 fix missing continue 2020-06-24 23:38:52 +02:00
TomasVotruba
8b34ab3821 remove double negate 2020-06-24 23:28:21 +02:00
TomasVotruba
ab2f83c4f7 cs 2020-06-24 23:26:31 +02:00
TomasVotruba
2064e3cc4b cs 2020-06-24 23:26:27 +02:00
derrickschoen
e72ed987e6
reduce size of array 2020-06-24 17:06:39 -04:00
derrickschoen
740dd752ac
reduce size of array 2020-06-24 17:03:50 -04:00
Derrick Schoen
e12336e3c5 Reduce number of variables 2020-06-24 08:33:51 -04:00
Derrick Schoen
87e0c838cd Boolean Operands cause ChangeNestedForeachIfsToEarlyContinueRector to produce code that gives a different output from the original code. 2020-06-23 17:49:19 -04:00
TomasVotruba
2248dc00fc add @scrumworks - amateri.com sponsor to particular rules, thank you 2020-06-21 13:43:17 +02:00
TomasVotruba
5b8bf939a6 skip encapsed string from constant extraction 2020-06-15 15:23:23 +02:00
TomasVotruba
d1e5990531 fix nested comment in nested foreach to if 2020-06-15 11:58:12 +02:00
Tomas Votruba
363483fe1f
Merge pull request #3503 from derrickschoen/EarlyContinueBugWhenThereIsACommentInsideIfStatement
I found a bug with the ChangeNestedForeachIfsToEarlyContinueRector
2020-06-15 11:56:02 +02:00
TomasVotruba
43da75f2e1 skip multi assign ChangeReadOnlyVariableWithDefaultValueToConstantRector 2020-06-15 11:18:24 +02:00
Derrick Schoen
91cec91778 I found a bug with the ChangeNestedForeachIfsToEarlyContinueRector
When there is a comment inside the if statement before the brace, it misses a brace creating the early continue statement.

https://getrector.org/demo/9757fa4a-ed15-4130-8bdc-ae150305360e
2020-06-09 17:31:39 -04:00
TomasVotruba
f0a67edb7e [Nette Kdyby] Add ReplaceEventManagerWithEventSubscriberRector 2020-05-29 01:36:25 +02:00
rector-bot
aa6a408060 fixup! fixup! add ParsedClassConstFetchNodeCollector 2020-05-21 15:05:38 +00:00
rector-bot
730090621f fixup! add ParsedClassConstFetchNodeCollector 2020-05-21 15:04:49 +00:00
TomasVotruba
a00329a4f1 add ParsedClassConstFetchNodeCollector 2020-05-21 17:01:29 +02:00
TomasVotruba
42890d64c5 add Symfony @required 2020-05-21 09:52:04 +02:00
TomasVotruba
678a992a9d [SOLID] add InjectMethodFactory for multi parent abstract rector 2020-05-21 09:50:38 +02:00
TomasVotruba
5bad3274b9 [SOLID] Add MultiParentingToAbstractDependencyRector 2020-05-21 09:15:47 +02:00
TomasVotruba
797cc53a38 note 2020-05-19 12:31:46 +02:00
TomasVotruba
d493363695 fix race-condition of name imports and class constant name 2020-05-19 12:21:58 +02:00
TomasVotruba
4f41f06e5d apply Rector 2020-05-09 22:13:01 +02:00
TomasVotruba
515ee780fb apply constant on /compiler 2020-05-09 21:56:12 +02:00
TomasVotruba
ff88e4b37a fix another constant in repeated literal to class constant 2020-05-09 21:50:52 +02:00
TomasVotruba
83ef24bd9d add slash to repeated literal to class constant 2020-05-09 21:33:17 +02:00
TomasVotruba
b86f4afdaf apply on packages 2020-05-06 23:40:31 +02:00
TomasVotruba
9c65e7ac75 [SOLID] Add RepeatedLiteralToClassConstantRector 2020-05-06 23:36:28 +02:00
TomasVotruba
94160332e1 [utils] improve SeeAnnotationToTestRule to check reference to test case class 2020-05-05 22:09:56 +02:00
TomasVotruba
69dfe3cf96 Fix multi-comment malforming 2020-05-05 00:19:45 +02:00
TomasVotruba
ef5501d06c various cs cleanup 2020-05-03 21:33:36 +02:00
TomasVotruba
00b3184eb3 [Naming] Add RenamePropertyToMatchTypeRector 2020-05-02 22:36:11 +02:00
TomasVotruba
653e5353bb [SOLID] Add AddFalseDefaultToBoolPropertyRector 2020-05-02 12:03:03 +02:00
TomasVotruba
b0836bde3c use propety over property property 2020-04-29 13:53:06 +02:00
TomasVotruba
1bf62ac1c7 [cs] sort private methods by call order and property by complexity 2020-04-26 02:57:47 +02:00
TomasVotruba
5f4a2c1e3b Add changed files caching 2020-04-20 01:54:17 +02:00
TomasVotruba
192c4464ec various improvements 2020-04-19 23:17:01 +02:00