1676 Commits

Author SHA1 Message Date
Tomas Votruba
7e10245fa1
[Nette] Add double render use case to TemplateMagicAssignToExplicitVariableArrayRector (#5549)
* add double case

* [ci-review] Rector Rectify

Co-authored-by: kaizen-ci <info@kaizen-ci.org>
2021-02-15 01:23:19 +00:00
Tomas Votruba
de8fa30257
[cs] apply indent of call in configs (#5547) 2021-02-14 21:28:21 +00:00
Tomas Votruba
054de822ed
[DoctrineCodeQuality] Add tests (#5540)
Co-authored-by: kaizen-ci <info@kaizen-ci.org>
2021-02-14 19:51:04 +00:00
Abdul Malik Ikhsan
a8e1a97444
update regex Fixture path for Fixture Finder (#5546) 2021-02-14 17:12:52 +01:00
Abdul Malik Ikhsan
01360925b2
[EarlyReturn] Add ReturnAfterToEarlyBreakRector (#5529)
Co-authored-by: kaizen-ci <info@kaizen-ci.org>
2021-02-14 10:53:04 +01:00
Tomas Votruba
d2948833a8
drop unused AddPropertyByParentRector (#5537) 2021-02-13 23:36:53 +00:00
Tomas Votruba
768e1ad381
[Nette] Allow optional case to render() parameters (#5538) 2021-02-13 22:57:57 +00:00
Tomas Votruba
1a45becf74
[Nette] Add false return check to template check (#5535)
Co-authored-by: kaizen-ci <info@kaizen-ci.org>
2021-02-13 23:26:00 +01:00
Abdul Malik Ikhsan
c910b26253
[DeadCode] Skip RemoveUnusedConstructorParamRector on property promotion (#5534) 2021-02-13 21:05:43 +01:00
Tomas Votruba
cd5cc8e12e
[Nette] Add render support to TemplateMagicAssignToExplicitVariableArrayRector, skip render() calls where missing template, now handled by another rule (#5532) 2021-02-13 17:56:58 +00:00
Tomas Votruba
6ce792c70a
[CodingStyle] Drop AnnotateThrowablesRector to narrow code scope, designed for custom community rule (#5528) 2021-02-13 15:19:19 +01:00
Tomas Votruba
d0fb658dad
[Nette] Improve TemplateMagicAssignToExplicitVariableArrayRector with conditional if/else (#5527)
Co-authored-by: kaizen-ci <info@kaizen-ci.org>
2021-02-13 13:25:47 +00:00
Tomas Votruba
eb3276e7fc
[NetteCodeQuality] Add MergeTemplateSetFileToTemplateRenderRector (#5525) 2021-02-13 01:08:54 +00:00
Tomas Votruba
a37dc9fdf1
[Renaming] Skip parent class rename, if target class is final (#5524) 2021-02-12 23:04:30 +00:00
TomasVotruba
6d65aa1423 simplify example 2021-02-12 23:58:52 +01:00
Tomas Votruba
afdf5839e7
[testing] change provideConfigFileInfo() to provideConfigFilePath() (#5518) 2021-02-12 19:19:40 +01:00
Tomas Votruba
fb1bf1f554
[Privatization] Skip on open-source abstract (#5516) 2021-02-12 02:02:28 +01:00
Abdul Malik Ikhsan
8d97bdc3c5
[DeadCode] Skip RemoveUnusedConstructorParamRector on interface and abstract method (#5515) 2021-02-12 01:34:10 +01:00
Tomas Votruba
1586fa7899
[Privatization] Skip privatization in abstract only on open-source type (#5514) 2021-02-11 22:24:40 +00:00
Tomas Votruba
4735479369
[PHP 5.5] Skip StringClassNameToClassConstantRector for is_a() checks (#5512) 2021-02-11 17:24:08 +00:00
Abdul Malik Ikhsan
9c57f47fa0
[CodeQualityStrict] Handle space in variable new name and assign in if cond at MoveOutMethodCallInsideIfConditionRector (#5509) 2021-02-11 17:47:29 +01:00
Tomas Votruba
82208c0730
[DeadCode] Fix RemoveUnusedPrivatePropertyRector in foreach (#5507)
Co-authored-by: Oliver Nybroe <oliver@worksome.com>
2021-02-11 15:01:41 +00:00
Tomas Votruba
65dfaca287
[Privatization] Add test case to verify property privatization (#5508) 2021-02-11 15:00:43 +00:00
TomasVotruba
fadfdbb4ef remove duplicated class 2021-02-11 13:11:16 +01:00
TomasVotruba
6bf6ced426 allow the test case class too 2021-02-11 13:08:17 +01:00
Tomas Votruba
63ea75cbf5
[testing] Add update tests feature to AbstractCommunityRectorTestCase (#5504) 2021-02-11 11:46:54 +00:00
TomasVotruba
45caffd591 use string for class that might be missing 2021-02-10 19:56:50 +01:00
Tomas Votruba
09af0bd66e
[Transform] Add CommunityTestCaseRector (#5497) 2021-02-10 18:34:06 +00:00
Abdul Malik Ikhsan
8d5706d5ac
[DeadCode] Skip RemoveUnusedClassesRector on class has children (#5498)
Co-authored-by: Tomas Norre Mikkelsen <tomas.mikkelsen@aoe.com>
2021-02-10 19:29:00 +01:00
Abdul Malik Ikhsan
99e5d0a210
[Renaming] Handle RenameMethodRector on new in caller class (#5493)
Co-authored-by: Ruud Kamphuis <ruudk@users.noreply.github.com>
2021-02-10 16:21:14 +01:00
Tomas Votruba
346bacfe19
[Tests] Split main test case and community test case (#5481)
Co-authored-by: kaizen-ci <info@kaizen-ci.org>
2021-02-10 11:57:25 +00:00
Tomas Votruba
69d5980d1d
simplify EnabledRectorsProvider (#5486)
Co-authored-by: kaizen-ci <info@kaizen-ci.org>
2021-02-09 23:54:08 +00:00
Tomas Votruba
560b720b83
[DependencyInjectoin] Add ActionInjectionToConstructorInjectionRector (#5485) 2021-02-09 22:57:20 +00:00
Tomas Votruba
7a3f5a8c0a
remove unused RectorClassesProvider (#5482)
* remove unused RectorClassesProvider

* README: remove ci-checkstyle link, marginal topic, to avoid confusion for first readers
2021-02-09 22:43:04 +00:00
Abdul Malik Ikhsan
6a6ac8332b
[EarlyReturn] Rename ChangeAndIfContinueToMultiContinueRector to ChangeOrIfContinueToMultiContinueRector (#5483)
* [EarlyReturn] Register ChangeAndIfContinueToMultiContinueRector to early-return config set

* try with clone $if

* [EarlyReturn] Rename ChangeAndIfContinueToMultiContinueRector to ChangeOrIfContinueToMultiContinueRector

* re-register

* [ci-review] Rector Rectify

* [ci-review] Rector Rectify

* [ci-review] Rector Rectify

* reduce complexity

* [ci-review] Rector Rectify

Co-authored-by: kaizen-ci <info@kaizen-ci.org>
2021-02-09 22:52:57 +01:00
Tomas Votruba
b9f5fe2f3d
[CI] Add PHP 8.0 php linter (#5479) 2021-02-09 21:32:17 +01:00
Abdul Malik Ikhsan
6b8789eeca
[EarlyReturn] Add ChangeAndIfContinueToMultiContinueRector (#5460)
* [EarlyReturn] [WIP] Fixes #5230 Add ChangeAndIfContinueToContinueEarlyRector

* skip multi stmts

* skip not continue

* skip not and

* functional

* cs fix

* negated check

* not identical

* reduce repetitive method

* comment test

* comment fixture

* reduce complexity

* cs fix

* [ci-review] Rector Rectify

* using isIfWithOnly()

* phpstan

* use ConditionInverter service

Co-authored-by: kaizen-ci <info@kaizen-ci.org>
2021-02-09 20:07:20 +01:00
Abdul Malik Ikhsan
1a9544f5f4
[DeadCode] Register RemoveDeadInstanceOfRector to dead-code config set (#5474)
* [DeadCode] Register RemoveDeadInstanceOfRector to dead-code config set

* failing fixture nullable type

* null type check

* handle child check and null check

* failing fixture with php doc type

* debug

* ensure different var

* fix

* fixture rename

* skip assign as may has side effect

* Param check

* clean up

* clean up

* final touch

* final touch

* fix

* fix

* [ci-review] Rector Rectify

* [ci-review] Rector Rectify

Co-authored-by: kaizen-ci <info@kaizen-ci.org>
2021-02-09 20:04:20 +01:00
Tomas Votruba
ecbef2bcaa
[Tests] remove getPhpVersion() helped method, use configs instead (#5477) 2021-02-09 17:25:16 +00:00
Tomas Votruba
e822db8625
moving ArrayPartPhpDocTagPrinterTrait and PrintTagValueNodeTrait to services (#5473) 2021-02-09 14:17:25 +00:00
Tomas Votruba
e0ad0f960f
[Tests] Move from getRectorsWithConfiguration() to provideConfigFileInfo() to make test configs more intuitive (#5468)
Co-authored-by: kaizen-ci <info@kaizen-ci.org>
2021-02-09 15:02:29 +01:00
Abdul Malik Ikhsan
31ceccc571
[DeadCode] Add RemoveDeadInstanceOfRector (#5470)
* [DeadCode] [WIP] Fixes #5458 Add RemoveDeadInstanceOfRector

* add failing fixture

* functional for BooleanNot

* skip not instanceof

* skip no previous var

* test do not remove parent child flipped

* skip has else/elseif

* phpstan

* celan up

* clean up

* fix

* implemented use unwrapStmts()

* fixture-a
2021-02-09 14:31:11 +01:00
Ruud Kamphuis
a0e735a652
Add failing test fixture for StringifyStrNeedlesRector (#5461)
* Add failing test fixture for StringifyStrNeedlesRector

# Failing Test for StringifyStrNeedlesRector

Based on https://getrector.org/demo/d2da9632-23c3-4f71-b800-219c8871639c

It should understand that `PHP_EOL` is a constant that is always a `string`. Therefore, no need to cast it to string.

* Support UnionType in NodeTypeAnalyser
2021-02-09 14:07:00 +01:00
Tomas Votruba
9f6834c46e
[DeadCode] Add RemoveUnusedConstructorParamRector (#5467)
Co-authored-by: kaizen-ci <info@kaizen-ci.org>
2021-02-09 04:55:21 +01:00
Tomas Votruba
5e95bbb294
Remove NotifyingNodeRemover, RemovedAndAddedFilesTrait, merge traits to AbstractRector (#5466)
Co-authored-by: kaizen-ci <info@kaizen-ci.org>
2021-02-09 01:52:35 +00:00
Tomas Votruba
f3b05c714c
[PHPUnit] Improve TryCatchToExpectExceptionRector complexity (#5465)
Co-authored-by: kaizen-ci <info@kaizen-ci.org>
2021-02-09 00:42:47 +01:00
Tomas Votruba
50f6adf47e
consolidate AbstractRectorTrait (#5464)
Co-authored-by: kaizen-ci <info@kaizen-ci.org>
2021-02-08 21:00:45 +00:00
Tomas Votruba
1757e83cdc
misc, remove RemoveProjectFileRector (#5463) 2021-02-08 18:26:00 +00:00
Tomas Votruba
d7353baf2c
Misc cleanup (#5456)
Co-authored-by: kaizen-ci <info@kaizen-ci.org>
2021-02-08 12:33:17 +00:00
Tomas Votruba
e9cdf37d16
Decopule nodes docs generator (#5453)
Co-authored-by: kaizen-ci <info@kaizen-ci.org>
2021-02-08 02:04:48 +01:00