65 Commits

Author SHA1 Message Date
Tomas Votruba
7e10245fa1
[Nette] Add double render use case to TemplateMagicAssignToExplicitVariableArrayRector (#5549)
* add double case

* [ci-review] Rector Rectify

Co-authored-by: kaizen-ci <info@kaizen-ci.org>
2021-02-15 01:23:19 +00:00
Tomas Votruba
768e1ad381
[Nette] Allow optional case to render() parameters (#5538) 2021-02-13 22:57:57 +00:00
Tomas Votruba
1a45becf74
[Nette] Add false return check to template check (#5535)
Co-authored-by: kaizen-ci <info@kaizen-ci.org>
2021-02-13 23:26:00 +01:00
Tomas Votruba
cd5cc8e12e
[Nette] Add render support to TemplateMagicAssignToExplicitVariableArrayRector, skip render() calls where missing template, now handled by another rule (#5532) 2021-02-13 17:56:58 +00:00
Tomas Votruba
d0fb658dad
[Nette] Improve TemplateMagicAssignToExplicitVariableArrayRector with conditional if/else (#5527)
Co-authored-by: kaizen-ci <info@kaizen-ci.org>
2021-02-13 13:25:47 +00:00
Tomas Votruba
ecbef2bcaa
[Tests] remove getPhpVersion() helped method, use configs instead (#5477) 2021-02-09 17:25:16 +00:00
Tomas Votruba
b2423f1f56
skip double template assigN (#5394) 2021-01-31 11:56:53 +00:00
Tomas Votruba
491cef11b9
allow another render names (#5393) 2021-01-31 11:16:51 +00:00
Tomas Votruba
f70a75f797
skip presenter (#5391) 2021-01-31 10:24:36 +00:00
Tomas Votruba
ad320cf63b
[Nette] Skip public method in template control (#5390)
Co-authored-by: rector-bot <tomas@getrector.org>
2021-01-31 08:35:44 +00:00
Tomas Votruba
a4f0c017ab
template control (#5388) 2021-01-31 00:51:20 +00:00
Tomas Votruba
7badb6347e
[Nette] Skip constructor on magic template call (#5289)
* Add failing test fixture for TemplateMagicAssignToExplicitVariableArrayRector

# Failing Test for TemplateMagicAssignToExplicitVariableArrayRector

Based on https://getrector.org/demo/cb7a63bb-d6ab-4f83-916e-714531f095bd

* [Nette] Skip constructor on magic template call

* [ci-review] Rector Rectify

Co-authored-by: Richard Kapička <richard@kapicka.cz>
Co-authored-by: rector-bot <tomas@getrector.org>
2021-01-22 20:01:32 +01:00
Tomas Votruba
f7fc1ea144
skip presenter on control parent/name remover (#5278) 2021-01-22 01:15:05 +01:00
Tomas Votruba
85e7f7fa2c
Make remove parent/name only on component, skip form (#5266) 2021-01-20 15:57:49 +00:00
Tomas Votruba
a7550337f0
Add promoted property in PHP 8.0, when adding a ctor dependency (#5222)
* add PHP 8.0 test

* Add promoted property adding in constructor injection on PHP 8

* update tests to use propert promotion

* fix promoted property adding

* decopule Doctrine registry to manager

* shorter naming

* fix parent ctor completion

* nette promotion fixes

* fixes

* fix property inject

* misc

* misc
2021-01-18 13:09:48 +00:00
Abdul Malik Ikhsan
4f6da168e0
[Nette] Do not Remove Param on RemoveParentAndNameFromComponentConstructorRector when used in Assign (#5098)
* Add failing test fixture for RemoveParentAndNameFromComponentConstructorRector

# Failing Test for RemoveParentAndNameFromComponentConstructorRector

Based on https://getrector.org/demo/12f10dc7-7ffb-4fe1-8004-7bf82e7aa9ce

There are multiple problems in this rule:
1) only $name is removed ($parent should be also removed)
2) $name (and if it would work also $parent) is removed also when there is some future use of it (e.g. assigning to private property $this->name = $name)

* Failing fixtures

* Closes #5052

* cs fix

* rename fixture

* rename fixture

* reduce complexity

* refactor

* use Assign

Co-authored-by: Michal Lulco <michal.lulco@gmail.com>
Co-authored-by: Michal Lulco <lulco@efabrica.sk>
2021-01-06 12:07:13 +01:00
Tomas Votruba
ec92bcc95e
[phpstan] enable file lenght rule (#4999)
* enable file lenght rule

* longer file, just to show ci worked

* [ci] add ValidateFileLengthCommand

* [phpstan] drop PathsAreNotTooLongRule

* [Downgrade] Shorten property promotion rector rule

* [Symfony] Shorten AutoWireWithClassNameSuffixForMethodWithRequiredAnnotationRector name

* shorten fixture name

* rename ChangeControlArrayAccessToAnnotatedControlVariableRector to AnnotateMagicalControlArrayAccessRector

* rename ReplaceMagicEventPropertySubscriberWithEventClassSubscriberRector to ReplaceMagicPropertyWithEventClassRector

* rename GetConfigWithDefaultsArgumentToArrayMergeInCompilerExtensionRector to MergeDefaultsInGetConfigCompilerExtensionRector

* rename ChangeCollectionTypeOptionTypeFromStringToClassReferenceRector to ChangeStringCollectionOptionToConstantRector

* decouple ProjectFilesFinder
2020-12-26 14:53:21 +00:00
Abdul Malik Ikhsan
24e17588c1
[Utils] Run validate-fixture-namespace/classname to rules/ directories (#4935) 2020-12-22 18:12:20 +01:00
Tomas Votruba
267989bb05
[Docs] Add docblock docs (#4740)
* skip getUser() as the method is final

* drop comment along with removed node, as in other removed nodes

* [docs] add doc block docs
2020-12-01 01:09:50 +00:00
Tomas Votruba
080e5cbe00
use symplify/skipper (#4689) 2020-11-26 23:09:21 +01:00
Abdul Malik Ikhsan
a38debb672
[DX] Fixes #4205 Change phpversion from string to php constant int type (#4679)
Co-authored-by: rector-bot <tomas@getrector.org>
2020-11-24 16:32:49 +01:00
Abdul Malik Ikhsan
01092de6bb
[Nette 3.0] Fixes #4387 : Add ConvertAddUploadWithThirdArgumentTrueToAddMultiUploadRector (#4551)
Co-authored-by: rector-bot <tomas@getrector.org>
2020-11-04 05:45:10 +01:00
Tomas Votruba
0513315056
Change file system approach of MultipleClassFileToPsr4ClassesRector to file without namespace node (#4522)
* Change file system approach of MultipleClassFileToPsr4ClassesRector to file without namespace node

* update DecoupleClassMethodToOwnClassRector

* [ci] add rebase jobp

* disable fail fast for unit tests

* misc
2020-10-31 12:59:40 +00:00
Tomas Votruba
18d2ea2d31
[Nette] Add MoveFinalGetUserToCheckRequirementsClassMethodRector (#4520)
* [Nette] Add MoveFinalGetUserToCheckRequirementsClassMethodRector

* [Nette] Add MoveFinalGetUserToCheckRequirementsClassMethodRector

* patch final presenter to allow tests
2020-10-31 00:43:54 +00:00
Tomas Votruba
3ed76c6559
[Nette] Add RemoveParentAndNameFromComponentConstructorRector (#4515)
* [Nette] Add RemoveParentAndNameFromComponentConstructorRector

* add refactorClassMethod()

* add refactorStaticCall()

* add refactorNew() method

* [Nette] Rename AddDatePickerToDateControlRector to AddNextrasDatePickerToDateControlRector

* [ci-review] Rector Rectify

Co-authored-by: rector-bot <tomas@getrector.org>
2020-10-30 17:10:17 +00:00
Tomas Votruba
3808d1b941
[Nette 3.0] Set update (#4381) 2020-10-09 22:01:37 +02:00
Tomas Votruba
8ae3868a57
[Restoration] Add RestoreFullyQualifiedNameRector (#4336)
* [Restoration] Add RestoreFullyQualifiedNameRector

* update docs

* use service aware test case for PHPStan rules

* improve FullyQualifiedNameMatcher

* cs fixes

* add return doc resolution

* composer: bump to symfony 4.4/5.1
2020-10-01 19:45:29 +00:00
Tomas Votruba
52ccfc0527
[DX] move Nette FileSytem to SmartFileSystem DI (#4262)
* move Nette FileSytem to SmartFileSystem DI

* move Symfony FileSytem to SmartFileSystem

* [ci] run rector diretly, without composer wrap
2020-09-19 09:27:29 +00:00
Tomas Votruba
2bd1eac705
use dev nette deps to resolve form/application types (#3879) 2020-08-03 08:51:44 +00:00
Tomas Votruba
e35131524c
[Nette 3.0] Various rules updates (#3878)
Co-authored-by: rector-bot <tomas@getrector.org>
2020-08-03 09:26:01 +02:00
TomasVotruba
5859625d5d [Nette] Add TranslateClassMethodToVariadicsRector 2020-07-29 03:21:08 +02:00
TomasVotruba
94088334c7 fix missing test fixture in generator 2020-07-29 02:29:44 +02:00
TomasVotruba
1e7ad43b4d rename CreateRector command to only Create 2020-07-29 02:27:21 +02:00
TomasVotruba
f845935e4a [Nette 3.0] Get config to merge with defaults 2020-07-28 17:46:48 +02:00
TomasVotruba
d94e529f29 [Nette] Improve AddDatePickerToDateControlRector 2020-07-27 10:44:51 +02:00
TomasVotruba
86d8666438 [Nette] move quality rules to nette-code-quality directory 2020-07-26 18:48:18 +02:00
TomasVotruba
0650075005 [Nette] Add ChangeControlArrayAccessToAnnotatedControlVariableRector 2020-07-26 15:54:46 +02:00
TomasVotruba
e3c9add4b2 [Nette] Add dim fetch support 2020-07-26 11:54:56 +02:00
TomasVotruba
c50aedca5c [Nette] add support for getComponent() resolution in form array access 2020-07-25 18:24:40 +02:00
TomasVotruba
350a1be7ba [Nette] Improve AddDatePickerToDateControlRector 2020-07-25 16:23:30 +02:00
TomasVotruba
32e1e87a80 [Nette] Add MakeGetComponentAssignAnnotatedRector 2020-07-25 12:39:53 +02:00
TomasVotruba
6872ad1f07 add support for connection with method call 2020-07-25 00:55:09 +02:00
TomasVotruba
aa91188a04 [Nette] skip being assigned 2020-07-24 23:23:51 +02:00
TomasVotruba
88a0a64f46 [Nette] add add*() method resolution for factories 2020-07-24 22:16:19 +02:00
TomasVotruba
dc60a96ff6 [Nette] add support for new instance type 2020-07-24 18:32:31 +02:00
TomasVotruba
44040eba97 [Nette] Add external form factory support 2020-07-24 17:16:37 +02:00
TomasVotruba
adcaf173d3 add custom control by method name 2020-07-24 16:02:09 +02:00
TomasVotruba
407e0c4d33 [Nette] Add ChangeFormArrayAccessToAnnotatedControlVariableRector 2020-07-24 13:47:35 +02:00
TomasVotruba
92b670d8d5 Skip already fetched in form contorl 2020-07-23 00:09:48 +02:00
TomasVotruba
d4f6c497a7 [Nette] Add form dim access to standalone node control 2020-07-22 21:38:34 +02:00