879 Commits

Author SHA1 Message Date
Leonardo Losoviz
abb9a3ef90
Downgrade PHP7.1 features: nullable types and void return type (#4192) 2020-09-12 11:50:13 +02:00
dobryy
a6444fb801
[DX] Configurable rule must have configure code sample, and vice versa (#4174)
* [DX] Configurable rule must have configure code sample, and vice versa

* Add ConfiguredCodeSample

* heredocs

* code sample

* fix class

* drop AbstractConfigurableMatchTypeRector

Co-authored-by: TomasVotruba <tomas.vot@gmail.com>
2020-09-11 11:21:48 +02:00
dobryy
f69ea0e023
[Naming] Rename foreach value variable to match method return type (#4130)
Co-authored-by: rector-bot <tomas@getrector.org>
2020-09-09 10:52:43 +02:00
Leonardo Losoviz
7a498e328e
Split downgrade sets (#4175)
Co-authored-by: TomasVotruba <tomas.vot@gmail.com>
2020-09-09 10:32:28 +02:00
Leonardo Losoviz
27fa9556d8
Added downgrade rules (#4172)
Co-authored-by: TomasVotruba <tomas.vot@gmail.com>
2020-09-08 17:18:49 +02:00
Leonardo Losoviz
4197899608
Downgrade union type (#4150)
Co-authored-by: TomasVotruba <tomas.vot@gmail.com>
2020-09-08 15:25:38 +02:00
Leonardo Losoviz
4eacc84b22
Organize downgrades by PHP version (#4147)
Co-authored-by: TomasVotruba <tomas.vot@gmail.com>
2020-09-08 13:12:38 +02:00
Tomas Votruba
6508aedd13
[Downgrade PHP 8.0] Add union types to doc types (#4082) 2020-09-08 12:00:38 +02:00
Leonardo Losoviz
a0f99c2c7f
Downgrade arrow functions (#4137)
* Extracted rule into abstract class for reuse

* Implemented rule

* Added rule to downgrade set

* Fixed rector-ci errors

* Fixed cs

* Preserve return type

* Direct assignment of parameters

* Use interface instead of abstract methods

* Moved abstract class under Php72

* Added test for params with type
2020-09-07 15:38:03 +02:00
Leonardo Losoviz
c6203e96d2
Downgrade null coalescing operator (#4135)
* Return `null` to signify no change to the node

* Implemented rector

* Added new rule to downgrade set

* Test requires PHP 7.4

* Wrapped code inside class
2020-09-07 14:50:42 +02:00
Leonardo Losoviz
71682d2b52
Abstract downgrade type + Implementation for object type (#4118) 2020-09-04 11:57:12 +02:00
jjthiessen
ff5b60826f
Correct various mysql_* to mysqli_* conversion bugs (#4119)
Co-authored-by: Jonathan Thiessen <jonathan.thiessen@terago.ca>
2020-09-03 20:49:31 +02:00
Tomas Votruba
a127bf16eb
revert [Experimental] Add safe_types option - #3535 (#4120) 2020-09-03 18:02:07 +00:00
TomasVotruba
3da57841db fix cakephp41 set 2020-09-03 19:52:58 +02:00
TomasVotruba
64912f3375 fix cs 2020-09-03 19:47:41 +02:00
TomasVotruba
a1f66b98da fix cakephp41 set 2020-09-03 19:17:31 +02:00
TomasVotruba
7214d83d9a fix inlined value object 2020-09-03 15:56:52 +02:00
Tomas Votruba
740ccda385
[CodingStyle] Drop SimplifyBoolIdenticalTrueRector, does not bring expected value (#4113) 2020-09-02 20:12:58 +00:00
Tomas Votruba
7ac228c638
[CI] Add type-declaration set (#4089)
* [CI] Add type-declaration set

* [rector] [CI] Add type-declaration set

* [cs] [CI] Add type-declaration set

* skip nullable void

* add anonymous parent/interface support

* refactor MultiExceptionCatchRector to use Catch_ over integers

* type fixes

* fix unoin array type override

* remove unused test cases

* drop overcomplicated InlineValidationRulesToArrayDefinitionRector

* skip assign on var

* [rector] skip assign on var

* [cs] skip assign on var

* [rector] [cs] skip assign on var

* skip assign on var

* fixes

* [rector] fixes

* [cs] fixes

Co-authored-by: rector-bot <tomas@getrector.org>
2020-09-01 17:56:30 +00:00
Tomas Votruba
b281fb1260
StaticCall to MethodCall (#4085)
* drop MessageAsArrayRector, as only rule in guzzle

* [Transform] Move StaticCallToMethodCallRector to Transform

* merge FacadeStaticCallToConstructorInjectionRector to StaticCallToMethodCallRector

* add ArrayArgumentToDataProvider

* [Transform] Move PropertyAssignToMethodCallRector to Transform
2020-08-31 08:48:14 +00:00
Tomas Votruba
082f1c6294
[Transform] Move StaticCallToMethodCallRector to Transform (#4084)
* drop MessageAsArrayRector, as only rule in guzzle

* [Transform] Move StaticCallToMethodCallRector to Transform
2020-08-31 00:26:25 +00:00
Tomas Votruba
df6e083324
drop MessageAsArrayRector, as only rule in guzzle (#4083) 2020-08-31 00:16:12 +00:00
Tomas Votruba
3a7d197b34
update FuncNameToStaticCallName to FuncCallToStaticCall (#4080) 2020-08-30 20:12:49 +00:00
dobryy
4e91b78c7b
[Naming] Rename the rule to make it correspond with what rule does (#4076)
* [Naming] Rename the rule to make it correspond with what rule does

* [Naming] Update doc
2020-08-30 21:01:33 +02:00
Tomas Votruba
3d03ec4beb
Removing single-rule elastic package set, merge Decomplex set to CodingStyle, merge FrameworkMigration to NetteToSymfony (#4079)
* drop elasticsearch-dsl50, used for single change, unmaintained

* [CodingStyleAdvanced] Move UseMessageVariableForSprintfInSymfonyStyleRector from single-rule set Decomplex to CodingStyleAdvanced

* merge FrameworkMigration with 1 class to NetteToSymfony

* [Transform] Move ServiceGetterToConstructorInjectionRector to Transform set

* [Transform] Move ReplaceParentCallByPropertyCallRector to Transform package

* [Transform] Move StaticCallToFunctionRector to Transform

* update docs

* [Transform] Move NewToStaticCallRector to Transform
2020-08-30 18:48:37 +00:00
Tomas Votruba
4584359f96
[Transform] Move FuncCallToMethodCallRector to Transform category (#4077) 2020-08-30 19:59:59 +02:00
Tomas Votruba
989c3f4168
[Transform] Move HelperFunctionToConstructorInjectionRector to Transform package (#4074)
Co-authored-by: rector-bot <tomas@getrector.org>
2020-08-30 18:55:16 +02:00
Tomas Votruba
e698e83687
[Transform] Decouple new set that changes nodes (#4073)
* [Transform] Move PropertyToMethodRector from Generic to Transform category

* move AbstractIsAbleRector to Generic

* [Transform] Move MethodCallToPropertyFetchRector from Generic to Transform

* [Transform] Move MethodCallToStaticCallRector from Generic to Transform

* [Transform] Move MethodCallToAnotherMethodCallWithArgumentsRector from Generic to Transform
2020-08-30 15:47:36 +02:00
Tomas Votruba
ff6d6571e6
[Order] Add abstract class, check for changed order and move category to Class_, to prevent minus types (#4069)
* [Order] report applied rule only on change

* add AbstractConstantPropertyMethodOrderRector, use explicit Class_ and Trait_ over minus

* update docs

* add PropertyNameRankAndPosition value object

* static fixes

* add ClassMethodRankeable and RankeableInterface, to get rid of arrays

* add PropertyRankeable

* add ClassConstRankeable

* add sortByRanksAndGetNames()

* [rector] add sortByRanksAndGetNames()

* [cs] add sortByRanksAndGetNames()

Co-authored-by: rector-bot <tomas@getrector.org>
2020-08-30 12:45:03 +00:00
Tom Pavelec
36b24b2bfc
fix: swapped naming of camel and pascal cases (#4047) 2020-08-28 18:07:15 +02:00
Tomas Votruba
3220d3d93a
misc (#4036) 2020-08-27 11:06:47 +02:00
Tomas Votruba
dbda0beee8
[DX] Last value objects (#4035)
* [DX] Add CallToFluent

* [DX] Add ArrayToFluentCall

* [DX] Add FactoryMethod
2020-08-26 14:25:28 +00:00
Tomas Votruba
dfe158e2da
[DX] Various value objects added (#4034)
* [DX] Add TypeToStaticCall

* [DX] Add ClassConstantRename

* [DX] Add IssetUnsetToMethodCall

* [DX] Add MethodToYield

* drop unamtained shopware sets

* [DX] Add RenamedAnnotationInType

* [DX] Add MethodCallWrap

* [DX] Add RenamedProperty

* [DX] Add StringToClassConstant

* [DX] Add ArgumentSwap

* simplify rename function rector

* [DX] Add RemovedFunctionArgument

* [DX] Add MethodCallToService

* [DX] Add UnprefixedMethodToGetSet

* [DX] Add PseudoNamespaceToNamespaceRector

* [DX] Add FunctionArgumentSwap

* [DX] Add StaticCallToFunction

* [DX] Add ParentCallToProperty

* [DX] Add ParentDependency

* [DX] Add CallWithParamRename

* [DX] Added MethodCallRenameWithAddedArguments

* [DX] Add PropertyToMethodCall

* [DX] Add PropertyToMethodCall

* [rector] [DX] Add PropertyToMethodCall

* [cs] [DX] Add PropertyToMethodCall

Co-authored-by: rector-bot <tomas@getrector.org>
2020-08-26 10:54:53 +00:00
Tomas Votruba
b4db31a2ae
[DX] Add ReplacedArgument (#4030) 2020-08-26 00:21:41 +02:00
Tomas Votruba
5cad696c95
[DX] Add AddedArgument (#4029) 2020-08-25 23:25:00 +02:00
Tomas Votruba
c2cfdaeacd
[DX] Add MethodVisibility value object (#4028) 2020-08-25 21:19:12 +02:00
Tomas Votruba
4553ae9579
[DX] Add TypeMethodWrap, RemovedArgument (#4026)
Co-authored-by: rector-bot <tomas@getrector.org>
2020-08-25 21:05:58 +02:00
Tomas Votruba
44d3ec8b7a
[DX] Add MethodReturnType value object (#4020)
* re-enable rule

* add MethodReturnType value object

* drop sylius deprecated sets, as not maintained for last 2 years
2020-08-25 18:34:49 +00:00
Tomas Votruba
35f61c64b6
[objectize] moving parameter typehint to objects (#4019)
* moving parameter typehint to objects

* rename constnats

* add support for nested configs

* switch to param type value object

* [rector] switch to param type value object

Co-authored-by: rector-bot <tomas@getrector.org>
2020-08-25 02:21:00 +02:00
Tomas Votruba
872f13b27d
rename to value object constants (#4018) 2020-08-24 22:37:12 +00:00
Tomas Votruba
c1653070f5
[phpstan] Add rule for complex config (#4015)
* [phpstan] Add ForbiddenComplexArrayConfigInSetRule

* add MethodCallRename value object

* [SymfonyPhpConfig] Add array to value object configuration rule

* apply first MethodCallRename value object
2020-08-24 22:26:14 +00:00
Tomas Votruba
de4748f935
README + recipe improvements (#4017)
* rector-recipe and README improvements

* ci: add generate command test
2020-08-24 21:25:26 +00:00
Tomas Votruba
41b679cb2a
[DX] Replacing arrays with objects (#4008)
* [phpstan] Add forbidden array destruct to prevent array mess

* use ArrayCallable value object

* add OpeningAndClosingSpace

* drop ConstructorInjectionToActionInjectionRector, antipattern

* use value objects

* [rector] use value objects

Co-authored-by: rector-bot <tomas@getrector.org>
2020-08-23 09:39:09 +00:00
TomasVotruba
6f53f55798 fix cs 2020-08-22 19:13:22 +02:00
Tomas Votruba
766853315e
[Naming] Add MakeIsserClassMethodNameStartWithIsRector (#4005) 2020-08-22 19:04:25 +02:00
Tomas Votruba
9164d46a3b
[Naming] Add MakeGetterClassMethodNameStartWithGetRector (#4003)
* [Naming] Add MakeGetterClassMethodNameStartWithGetRector

* [rector] [Naming] Add MakeGetterClassMethodNameStartWithGetRector

* [cs] [Naming] Add MakeGetterClassMethodNameStartWithGetRector

Co-authored-by: rector-bot <tomas@getrector.org>
2020-08-22 15:46:09 +00:00
Tomas Votruba
6a442eddd9
merge CorrectDatetimeEntityPropertyDefaultToConstructorRector to MoveCurrentDateTimeDefaultInEntityToConstructorRector (#3978)
* merge CorrectDatetimeEntityPropertyDefaultToConstructorRector to MoveCurrentDateTimeDefaultInEntityToConstructorRector

* [rector] merge CorrectDatetimeEntityPropertyDefaultToConstructorRector to MoveCurrentDateTimeDefaultInEntityToConstructorRector

* add Throw Expr to docs

Co-authored-by: rector-bot <tomas@getrector.org>
2020-08-21 09:47:44 +00:00
dobryy
afa7456a05
[DX] Architecture rules respect namespace (#3983) 2020-08-20 13:56:36 +02:00
Tomas Votruba
1f61fe34f0
import repo entity (#3988)
* various fixes

* add import for generic types

* bump to newer phpstan with php-parser 4.9
2020-08-19 13:20:16 +00:00
dobryy
2e7bdca4e2
[DX] Rename namespaces respect node type (#3973) 2020-08-18 17:57:30 +02:00