Abdul Malik Ikhsan
ae1e74a89d
[DeadCode] Failing fixture for not removing method parameter used on RemoveUnusedPrivatePropertyRector ( #5095 )
...
* [DeadCode] Failing fixture for not removing method parameter used on RemoveUnusedPrivatePropertyRector
* Fixes #5088
* return type
* fixture rename
* use findFirstParentInstanceOf as it may inside another, eg: assign
* phpstan
* clean up
* clean up
* skip construct
* instanceof New_ check
* fix
* final touch
* identifier check
* reduce complexity
* use toString()
* final touch
* php 7.3 syntax
2021-01-06 01:28:51 +00:00
Abdul Malik Ikhsan
1ddaf53bee
[DeadCode] Skip RemoveUnusedPrivatePropertyRector on isset as well ( #5085 )
...
* handle isset as well
* method name
* handle under isset
* fix fixture
2021-01-04 18:35:33 +01:00
Abdul Malik Ikhsan
625e3026ff
[DeadCode] Skip RemoveUnusedPrivatePropertyRector on property fetch in unset ( #5084 )
...
* [DeadCode] Fixes #5076 Skip RemoveUnusedPrivatePropertyRector on property fetch in unset
* fixture
* phpstan
2021-01-04 14:08:59 +01:00
Tomas Votruba
e081d8e22c
[DeadCode] Check for child constant usages too ( #5077 )
2021-01-03 10:44:22 +00:00
Abdul Malik Ikhsan
e6dc7c300a
[FlySystem 2.0] Add Upgrade set for MethodCallRename ( #5068 )
2021-01-02 17:13:59 +01:00
Tomas Votruba
6ddb4effd8
[PHPStanStaticTypeMapper] Add closure conversion ( #5043 )
2020-12-29 21:22:48 +00:00
Tomas Votruba
59b71e04a3
respect PHPStan descission to drop & in param docs ( #5035 )
...
* revert phpdoc support for reference in params
* [ci-review] Rector Rectify
Co-authored-by: rector-bot <tomas@getrector.org>
2020-12-29 11:12:32 +00:00
TomasVotruba
7176cd62f8
remove dead half fetch
2020-12-28 19:20:40 +01:00
Tomas Votruba
cdf3c97b60
[RectorGenerator] Test interactive generator ( #5023 )
...
* apply cs
* [RectorGenerator] Add compare dir test for interactive mode
* add PackageNamesProviderTest
* add NodeTypesProviderTest
* [ci-review] Rector Rectify
Co-authored-by: rector-bot <tomas@getrector.org>
2020-12-28 18:20:12 +00:00
Krystian Marcisz
94a4bb7777
[DX] Add Interactive Mode to Generate command ( #4931 )
...
* Add Interactive Mode to Generate command
* CS Fixer
* Unify names
* Unify names
* Fixes
* Fixes
* Fixes
* Check generated tests against the "special hack for PHPUnit"
* Re-use the same input/output in the Generate Command
* Add test for Interactive Mode of Generate Command
* Rename test file
* Use ::class instead of string
* Create Finder instance where it's used
* Create RectorRecipeInteractiveProvider service
* Create RectorRecipeInteractiveProvider service
* Bring back SymfonyStyle as DI service
2020-12-28 18:00:51 +01:00
Tomas Votruba
8ed61a7560
Add support for inheritdoc in parent type use ( #5020 )
...
Co-authored-by: Jan Kuchař <honza@kucharovi.cz>
2020-12-28 17:57:21 +01:00
Tomas Votruba
0f221f92a4
Add template annotation resolving support ( #5019 )
...
Co-authored-by: Jan Kuchař <honza@kucharovi.cz>
2020-12-28 13:01:27 +00:00
Tomas Votruba
a7544e85e1
Cleanup exclusion manager test ( #5012 )
...
* merge CODING_STYLE_ADVANCED to CODE_QUALITY_STIRCT
* rename split ExclusionManager test to single one
2020-12-27 23:24:28 +00:00
Tomas Votruba
34a2a497b3
[scoper] symplify prefix pick ( #5011 )
...
* use local composer.json for scoped dir
* remove dead directory
* remove dynamic return type extension, not used
* [ci] add along phpstan install
* [scoper] add psr-4 prefixing
2020-12-27 20:31:30 +00:00
Tomas Votruba
a4f8a23ecf
[CodeQuality] Move MoveVariableDeclarationNearReferenceRector ( #4992 )
2020-12-25 17:48:15 +01:00
Tomas Votruba
db89b5eefa
[CodeQuality] Move MoveVariableDeclarationNearReferenceRector ( #4989 )
...
* [CodeQuality] Move MoveVariableDeclarationNearReferenceRector
* move code-quality-strict rules to own namespace
* move MoveVariableDeclarationNearReferenceRector to CodeQualityStrict
* add ClassConstFetchFactory
* static fixes
2020-12-25 16:22:19 +00:00
Tomas Votruba
cffd7ea0ac
[CodingStyle] Move PHPStormVarAnnotationRector ( #4985 )
...
* [CodingStyle] Move PHPStormVarAnnotationRector
* [ci-review] Rector Rectify
* [DeadDocBlock] Move RemoveNonExistingVarAnnotationRector here (#4984 )
* [DeadDocBlock] Move RemoveNonExistingVarAnnotationRector here
* [ci-review] Rector Rectify
Co-authored-by: rector-bot <tomas@getrector.org>
* [ci-review] Rector Rectify
* cleanup docs
* static fixes
* [ci-review] Rector Rectify
* remove duplicated
* multi use case
* misc
* [ci-review] Rector Rectify
* fixes
* remove order set, slow
* move UseMessageVariableForSprintfInSymfonyStyleRector from solid set to coding-style
* make unique-named variables to prevent accidental override and improve readability
Co-authored-by: rector-bot <tomas@getrector.org>
2020-12-25 13:20:13 +00:00
Abdul Malik Ikhsan
ec5daad132
[Util] Add StaticInstanceOf ( #4979 )
...
Co-authored-by: rector-bot <tomas@getrector.org>
2020-12-25 12:53:26 +01:00
Tomas Votruba
d465ec83e2
[DeadCode] Move RecastingRemovalRector from PHPStan set ( #4983 )
...
* [DeadCode] Move RecastingRemovalRector from PHPStan set
* [ci-review] Rector Rectify
* [ci-review] Rector Rectify
* [ci-review] Rector Rectify
Co-authored-by: rector-bot <tomas@getrector.org>
2020-12-25 00:22:45 +00:00
Tomas Votruba
5a47e36b72
Add Visibility consts ( #4981 )
2020-12-24 23:01:30 +01:00
Tomas Votruba
319d6bfca1
add phpstan-for-rector config path, consolidate return type extensions - re-use from Symplify ( #4973 )
...
* add phpstan-for-rector config path, to separate phpstan and extensions that help Rector with precise types
* move type value object to value object
* moving
* remove KernelGetContainerAfterBootReturnTypeExtension, use one from symplify
* remove ContainerGetDynamicMethodReturnTypeExtension to ContainerGetReturnTypeExtension
* remove nette extension
* add nette-extension
* removed delegated rule
* delegate implmenets + code sample PHPStan rule to symplify
2020-12-24 16:31:24 +00:00
Abdul Malik Ikhsan
ca0b4cfdc7
[EarlyReturn] Register ChangeOrIfReturnToEarlyReturnRector to early-return set ( #4975 )
...
Co-authored-by: rector-bot <tomas@getrector.org>
2020-12-24 17:28:56 +01:00
Tomas Votruba
61e1ceaf5c
Cover ArrayShape type and other doc nodes ( #4967 )
...
Co-authored-by: rector-bot <tomas@getrector.org>
2020-12-23 22:11:37 +01:00
Tomas Votruba
aa35633c66
use getService() API call over static ( #4970 )
2020-12-23 21:40:46 +01:00
Tomas Votruba
a759f1ffbc
Static fixes 3 ( #4930 )
...
* cleanpu baseline
* static fixes
* staitc fixes
* [Naming] Remove dead classes UnderscoreCamelCaseParamRenamer and MatchTypeParamRenamer
* static fixes
* value object fixes
* [ci-review] Rector Rectify
Co-authored-by: rector-bot <tomas@getrector.org>
2020-12-21 02:12:42 +00:00
Tomas Votruba
d1e48f462a
Static fixes ( #4929 )
...
* static fixes
* fixup! static fixes
* fixup! fixup! static fixes
* fixup! fixup! fixup! static fixes
2020-12-20 21:27:30 +00:00
Tomas Votruba
37b3cecda3
Upgrade to php-parser 4.10.4 and PHPStan 0.12.63 ( #4926 )
...
Co-authored-by: rector-bot <tomas@getrector.org>
2020-12-20 22:05:48 +01:00
Tomas Votruba
2c8a76ef12
[Naming] add failing test case for type property collection name ( #4863 )
...
* add failing test case for type property collection name
* [ci-review] Rector Rectify
Co-authored-by: rector-bot <tomas@getrector.org>
2020-12-20 15:10:06 +00:00
Charlie
c044b8ae97
Keep colon when it's used in Doctrine tag's original content. ( #4924 )
...
Co-authored-by: Charlie <charlie.vieillard@pixelindustries.com>
2020-12-20 13:58:04 +01:00
Tomas Votruba
574c7cd174
[static] Narrow param types, remove duplicated methods ( #4921 )
...
* narrow types and other static fixes
* duplicates static fixes
* [ci-review] Rector Rectify
Co-authored-by: rector-bot <tomas@getrector.org>
2020-12-20 13:50:55 +01:00
TomasVotruba
b7c6e2b7c0
apply cs
2020-12-19 23:37:11 +01:00
Abdul Malik Ikhsan
720b2c34eb
[EarlyReturn] Enable ReturnBinaryAndToEarlyReturnRector in early-return config set ( #4915 )
...
Co-authored-by: rector-bot <tomas@getrector.org>
2020-12-19 16:24:53 +01:00
Abdul Malik Ikhsan
3489c8a9ff
[Utils] Run validate-fixture-namespace/classname to packages ( #4902 )
2020-12-15 20:40:13 +01:00
Tomas Votruba
a8a0030bf9
Move package to 1st position in recipe ( #4882 )
...
* add alias
* [recipe] enable set by default, most contributors are core
* move package to 1st place, close to rule name where we think about package
* [ci-review] Rector Rectify
* fix recipe test
Co-authored-by: rector-bot <tomas@getrector.org>
2020-12-14 16:24:33 +00:00
Tomas Votruba
f197e25793
droping events ( #4865 )
...
* drop unused ReportCollector and releted avain chains
* update fixed comma trail downgrade in php-parser
* add post runner interface
* [CodingStyle] Enabe post-inc-dec
* [ci-review] Rector Rectify
* test ci
* bump phpunit
Co-authored-by: rector-bot <tomas@getrector.org>
2020-12-12 14:58:47 +00:00
Tomas Votruba
56dedb1786
static fixes ( #4864 )
...
Co-authored-by: rector-bot <tomas@getrector.org>
2020-12-12 14:53:10 +01:00
Tomas Votruba
db5e02e724
static fixes ( #4860 )
...
Co-authored-by: rector-bot <tomas@getrector.org>
2020-12-12 13:08:34 +01:00
Tomas Votruba
d27997197b
Static updates ( #4857 )
2020-12-11 18:25:42 +01:00
Leonardo Losoviz
7794d819c4
Fixed typo: Alais => Alias ( #4856 )
2020-12-11 14:55:24 +01:00
Tomas Votruba
d131d804d9
Bump min PHP version to 7.3 ( #4838 )
...
Co-authored-by: rector-bot <tomas@getrector.org>
2020-12-09 23:25:53 +01:00
Krystian Marcisz
fab46dd552
[Symfony 5.2][Mime] Rename Address::fromString() to Address::create() ( #4840 )
2020-12-09 21:38:57 +01:00
Tomas Votruba
e157da77f9
[PHP 8.0] Skip void type in union ( #4835 )
2020-12-09 19:38:45 +01:00
Tomas Votruba
eac130e705
[PHP 8.0] Make Attribute silent keys explicit, with named args ( #4834 )
...
* decouple TagName class
* remove attribute aware from data provider tag value node, as unique class
* add RequiredTagValueNode
* make Attributes explicit, to avoid confusiong
2020-12-09 17:16:36 +00:00
Abdul Malik Ikhsan
143164504e
[CodeQuality] Add UnwrapSprintfOneArgumentRector ( #4827 )
...
Co-authored-by: rector-bot <tomas@getrector.org>
2020-12-09 12:29:01 +01:00
Leonardo Losoviz
7c991a9898
[Downgrade PHP 7.0] Remove param and return types ( #4819 )
...
Co-authored-by: rector-bot <tomas@getrector.org>
2020-12-08 13:02:26 +01:00
Tomas Votruba
db63a96397
[PHP 8.0] CI test fixes ( #4805 )
...
* [Downgrade PHP 8.0] Fix Union type
* run variable rename
* allow test
* fix regex
* allow run
* remove test dependency on DateTime changing api
* normalize
2020-12-06 10:19:17 +00:00
Tomas Votruba
bfd1953f97
move string downgrade types to object classes ( #4801 )
...
* move string downgrade types to object classes
* fix nullable type unwrap
* remove uneeded open tags from samples
* remove uneeded union type check
2020-12-06 00:27:00 +00:00
Tomas Votruba
3b22532794
[Downgrade] [PHP 8.0] Fix static type ( #4800 )
2020-12-06 01:05:21 +01:00
Tomas Votruba
18fdd3313a
[PHP 8.0] get_parent_class() cannot be called on non-existing classes anymore ( #4798 )
...
Co-authored-by: rector-bot <tomas@getrector.org>
2020-12-05 23:16:54 +01:00
Tomas Votruba
8bfb36d0b2
[Downgrade] [PHP 7.3] Downgrade trailing commas in function calls ( #4796 )
...
Co-authored-by: Tommy Quissens <tommy.quissens@storefront.be>
Co-authored-by: rector-bot <tomas@getrector.org>
2020-12-05 22:40:10 +01:00