10822 Commits

Author SHA1 Message Date
Tomas Votruba
7d9fa07c72
import const name attribute (#5158)
* use config over manual creationg

* add attribute test
2021-01-13 01:44:48 +00:00
github-actions[bot]
19c47b9f1f
[automated] Re-Generate Nodes/Rectors Documentation (#5162)
Co-authored-by: kodiakhq <kodiakhq@users.noreply.github.com>
2021-01-13 02:25:45 +01:00
Michal Lulco
3840fb4135
Added usage of composer modifier for nette upgrade to 3.0 (#5161) 2021-01-13 00:23:45 +01:00
Michal Lulco
4bd4a4657b
Full upgrade of codebase including changes in composer.json (#5074)
* Composer changer

* Implemented ChangePackage, ChangePackageVersion and RemovePackage with tests

* Refactored composer processor

* Refaktoring

* Added missing tests

* Added void return type to test

* Changed namespaces and fixed CI tests

* Apply rector rules

* Moved new line to processor from modifier

* Use array copies in tests

* Added descriptions to all construct parameters and inheritDoc to modify methods

* Rewritten ComposerModifierTest to use AbstractKernelTestCase and ComposerModifier as service

* Split MovePackage to 2 classes

* Sort packages if it is set in config

* Rectified

* Rename class ChangePackage to ReplacePackage

* Split class AddPackage to AddPackageToRequire and AddPackageToRequireDev

* Added Version checker and moved modifier classes to separated folder

* Changed array to ComposerJson in modify methods

* Rectifying

* Removed unnecessary docs

* Temporary added fork of composer-json-manipulator

* Removed unused code and replaced InvalidArgumentException to assert
2021-01-12 22:50:42 +01:00
Abdul Malik Ikhsan
0ba497eb71
[DeadCode] Skip when $this->isOpenSourceProjectType() on RemoveUnusedPublicMethodRector (#5155)
* [DeadCode] Skip when $this->isOpenSourceProjectType() on RemoveUnusedPublicMethodRector

* add open source type test
2021-01-12 15:36:13 +01:00
Tomas Votruba
b604e1676c
[Privatization] Add ReplaceStringWithClassConstantRector (#5156)
* [Privatization] Add ReplaceStringWithClassConstantRector

* README: add to scoped
2021-01-12 13:41:47 +00:00
github-actions[bot]
f40d602d43
[automated] Re-Generate Nodes/Rectors Documentation (#5150)
Co-authored-by: kodiakhq <kodiakhq@users.noreply.github.com>
2021-01-12 12:52:10 +01:00
Abdul Malik Ikhsan
9b08d3a924
[DeadCode] Add RemoveUnusedPublicMethodRector (#5151)
* [DeadCode] [WIP] Fixes #3107 Add RemoveUnusedPublicMethodRector

* example

* add failing test

* basic

* use findCallsByClassMethod

* functional

* cs fix

* fix

* failing with place unused method later

* debug

* debug

* getting class name by method call

* checking method call name compare

* works

* check used outside class

* check used outside class

* check used outside class

* clean up

* move up method

* phpstan

* fixture for dependency injection
2021-01-12 12:43:13 +01:00
TomasVotruba
e71a107b1b [SymfonyCodeQuality] Create value object in one step 2021-01-12 01:04:45 +01:00
Leonardo Losoviz
a57d55cd0a
[Downgrade PHP 7.4] Skip downgrading contravariant argument for __construct (#5148)
* Added (failing) test

* Implemented feature
2021-01-12 00:03:29 +01:00
Leonardo Losoviz
9f8f5e9562
[Downgrade PHP 7.4] Remove self return type (#5146)
* Added tests

* Map "self" type

* Implemented Rector

* Use className as param

* Fixed PHPStan

* Added rector to set
2021-01-11 23:14:54 +01:00
Tomas Votruba
1ae44512e9
[PHP 8.0] Add FalseableCountToZeroRector (#5143) 2021-01-11 21:19:55 +01:00
Tomas Votruba
6c11a254aa
[SymfonyCodeQuality] Add ExtractAttributeRouteNameConstantsRector (#5140)
* [SymfonyCodeQuality] Add ExtractAttributeRouteNameConstantsRector

* optimizations
2021-01-11 20:12:10 +00:00
Matthias Noback
73c2a2e28b
InferParamFromClassMethodReturnRector: Don't fail with empty array (#5141)
* Skip empty array

When inferring param from class method return, an empty array should be fine.

* Improve test fixture
2021-01-11 21:00:10 +01:00
Tomas Votruba
2d7b21f3cc
[PHP 8.0] Add new pgsql function names (#5138) 2021-01-11 12:00:34 +00:00
Abdul Malik Ikhsan
de09409152
[mysql-to-mysqli] Handle second parameter on mysqli_query swap for sql - conn variable (#5130)
Co-authored-by: Martin <admin@phpcode.eu>
Co-authored-by: rector-bot <tomas@getrector.org>
2021-01-11 12:12:46 +01:00
Tomas Votruba
20588b78a0
[DeadCode] Remove right part of unused assign (#5135) 2021-01-10 19:13:28 +00:00
Tomas Votruba
8d66581b58
[CodingStyle] Skip on class-string string subtype (#5133)
* [CodingStyle] Skip on class-string string subtype

* [ci-review] Rector Rectify

Co-authored-by: rector-bot <tomas@getrector.org>
2021-01-10 18:57:16 +00:00
Tomas Votruba
d1df8f76cd
drop PHPStanAttributeTypeSyncer, handled by external package (#5131) 2021-01-10 14:51:27 +01:00
Tomas Votruba
074298d35c
static fixes (#5127)
* static fixes

* fix remove class rule for tests
0.9.6
2021-01-10 11:01:40 +00:00
Abdul Malik Ikhsan
edcfe417a4
Another fix weekly code coverage action (#5128)
typo fix `secrets.GITHUB_TOKEN` -> `secrets.ACCESS_TOKEN`
2021-01-10 11:55:11 +01:00
Abdul Malik Ikhsan
6da34f9a35
Fix weekly code coverage github action (#5126)
it got error: 

```

The workflow is not valid. .github/workflows/weekly_code_coverage.yaml (Line: 34, Col: 51): Unrecognized named-value: 'secrets'. Located at position 1 within expression: secrets.GITHUB_TOKEN
```

The `secrets` seems only needed for automatic PR.
2021-01-10 08:54:52 +01:00
TomasVotruba
1aa0cb4550 bump deps 2021-01-10 02:28:32 +01:00
TomasVotruba
859fd4f327 fix forgotten array 2021-01-09 16:07:53 +01:00
TomasVotruba
d59aa8dfd6 use array arguments on privates caller 2021-01-09 15:51:10 +01:00
TomasVotruba
6c740e6df0 remove unused class as file 2021-01-09 15:27:24 +01:00
Tomas Votruba
4756535d2b
[CodingStyle] Improve unspread array (#5120)
* decouple VendorFileDetector

* decouple SpreadVariablesCollector

* [CodingStyle] Improve UnSpreadOperatorRector to join argument to array
2021-01-09 14:08:02 +00:00
github-actions[bot]
f1d4a4a671
[automated] Re-Generate Nodes/Rectors Documentation (#5118)
Co-authored-by: kodiakhq <kodiakhq@users.noreply.github.com>
2021-01-09 12:16:22 +01:00
Tomas Votruba
7d441c1806
fix offset type (#5119)
* fix offset type

* skip ChangeGlobalVariablesToPropertiesRector if empty
2021-01-09 10:50:47 +00:00
Tomas Votruba
2cf2ee3f41
fix exclusion annotation for non-class rector descripton + simplify (#5117)
* fix exclusion annotation for non-class rector descripton + simplify

* add HasOffsetTypemapper

* [ci-review] Rector Rectify

* [ci-review] Rector Rectify

Co-authored-by: rector-bot <tomas@getrector.org>
2021-01-09 00:20:28 +00:00
Tomas Votruba
bc0113dbd7
use templates (#5116) 2021-01-08 23:30:33 +01:00
Tomas Votruba
bd62164c85
[DeadCode] Skip if the methods have api annotation (#5115)
* [DeadCode] Skip if the methods have api annotation

* [ci-review] Rector Rectify

Co-authored-by: rector-bot <tomas@getrector.org>
2021-01-08 20:15:44 +01:00
Tomas Votruba
2872eb095d
[DeadCode] Skip if the methods have api annotation (#5114) 2021-01-08 16:44:27 +00:00
Tomas Votruba
27f2fad0c0
[DeadCode] Fix removing native interface (#5113)
* [Restoratoin] Skip native interface from removing

* move RemoveUselessJustForSakeInterfaceRector to dead code category

* remove interface name pattern

* [ci-review] Rector Rectify

Co-authored-by: rector-bot <tomas@getrector.org>
2021-01-08 14:34:54 +00:00
Tomas Votruba
d478992160
Fix deprecated ref() to service() function, skip empty file (#5112)
* composer: bump to symfony/dependency-injection 5.1, required as minimum by other deps anyway

* use service() over deprecated ref()

* skip empty files

* skip just created props
2021-01-08 14:04:35 +00:00
Abdul Malik Ikhsan
96bd6e2464
Typo fix autolaod -> autoload (#5110) 2021-01-08 11:18:18 +01:00
Abdul Malik Ikhsan
2e5ca7cc34
[ValueObject] Add PHP_80 constant to PhpVersion class (#5109) 2021-01-08 11:17:51 +01:00
Abdul Malik Ikhsan
b82c473e8d
[Downgrade PHP 7.4] Skip DowngradeNumericLiteralSeparatorRector on value contains + char (#5108)
Co-authored-by: rector-bot <tomas@getrector.org>
2021-01-08 11:17:11 +01:00
Abdul Malik Ikhsan
fe639838d5
[BetterStandardPrinter] Improve duplicate comment handling when duplicated in multi parts (#5107)
* [BetterStandardPrinter] Improve duplicate comment handling when duplicated in multi parts

* clean up

* different comment name fixture

* fix
2021-01-07 20:05:19 +01:00
Abdul Malik Ikhsan
3a2d32c7fa
[BetterStandardPrinter] Failing fixture to not duplicate comment (#5106)
* [BetterStandardPrinter] Failing fixture to not duplicate comment

* Closes #4191

* phpstan
2021-01-07 19:33:27 +01:00
Abdul Malik Ikhsan
524b578628
[PostRector] Skip re-import name on callable name node (#5022)
* [PostRector] Fixes #3383 Skip import name on callable node

* check function_exists()

* fix

* [ci-review] Rector Rectify

* make keep working on existing test

* try use isFoundInUse from ClassNameImportSkipper

* use ClassNameImportSkipper usage

* callable check

* try without is_callable() check

* try using ! function_exists() with \ prefix

* try again with is_callable return early

* fixed

* [ci-review] Rector Rectify

* works?

* fix

* fix

* reduce code complexity

* final touch

* namespace fixture fix

Co-authored-by: rector-bot <tomas@getrector.org>
2021-01-07 19:27:31 +01:00
Abdul Malik Ikhsan
b944ee7274
[DeadCode] Failing fixture do not remove variable on comment exists after definition (#5105)
* [DeadCode] Failing fixture do not remove variable on comment exists after definition

* Fixes #5105

* fixture fix
2021-01-07 19:26:15 +01:00
Tomas Votruba
2db8699deb
[CodeQuality] Skip newline (#5103) 2021-01-06 21:10:51 +00:00
Abdul Malik Ikhsan
4622072613
[CodeQuality] Skip ExplicitBoolCompareRector on not variable type (#5101)
* Add failing test fixture for ExplicitBoolCompareRector

# Failing Test for ExplicitBoolCompareRector

Based on https://getrector.org/demo/3cb57eee-954d-4f12-9d0f-7ce703672f60

* Update and rename demo_file.php.inc to UnknownPropertyType.php.inc

* Closes #5100

* fixture

Co-authored-by: Jan Kuchař <honza@kucharovi.cz>
2021-01-06 20:13:48 +01:00
Abdul Malik Ikhsan
756f7dd214
Ensure clean up composer.json & build dir after run coverage weekly (#5099)
* Ensure clean up composer.json after run coverage weekly

as it use require --dev (update composer.json) during run.

* clean build dir as well
2021-01-06 12:08:03 +01:00
Abdul Malik Ikhsan
4f6da168e0
[Nette] Do not Remove Param on RemoveParentAndNameFromComponentConstructorRector when used in Assign (#5098)
* Add failing test fixture for RemoveParentAndNameFromComponentConstructorRector

# Failing Test for RemoveParentAndNameFromComponentConstructorRector

Based on https://getrector.org/demo/12f10dc7-7ffb-4fe1-8004-7bf82e7aa9ce

There are multiple problems in this rule:
1) only $name is removed ($parent should be also removed)
2) $name (and if it would work also $parent) is removed also when there is some future use of it (e.g. assigning to private property $this->name = $name)

* Failing fixtures

* Closes #5052

* cs fix

* rename fixture

* rename fixture

* reduce complexity

* refactor

* use Assign

Co-authored-by: Michal Lulco <michal.lulco@gmail.com>
Co-authored-by: Michal Lulco <lulco@efabrica.sk>
2021-01-06 12:07:13 +01:00
Abdul Malik Ikhsan
ae1e74a89d
[DeadCode] Failing fixture for not removing method parameter used on RemoveUnusedPrivatePropertyRector (#5095)
* [DeadCode] Failing fixture for not removing method parameter used on RemoveUnusedPrivatePropertyRector

* Fixes #5088

* return type

* fixture rename

* use findFirstParentInstanceOf as it may inside another, eg: assign

* phpstan

* clean up

* clean up

* skip construct

* instanceof New_ check

* fix

* final touch

* identifier check

* reduce complexity

* use toString()

* final touch

* php 7.3 syntax
2021-01-06 01:28:51 +00:00
Floris Luiten
39a6b79f30
Fixed typo "lenght" (#5096)
* Fixed typo in docs "lenght" to "length"

* Fixed typo in class constant "lenght" to "length"

* Changed "lenght" instead of "length", fixing bug in class_exists using incorrect classname
2021-01-06 03:06:16 +07:00
Abdul Malik Ikhsan
ff0134b5ca
[CodeQuality] Skip IssetOnPropertyObjectToPropertyExistsRector on null scope (#5094)
* Fixed scope as null on IssetOnPropertyObjectToPropertyExistsRector. Related #5090

* Updated is_null check with !

* Update rules/code-quality/src/Rector/Isset_/IssetOnPropertyObjectToPropertyExistsRector.php

Thanks

Co-authored-by: Abdul Malik Ikhsan <samsonasik@gmail.com>

* Update rules/code-quality/src/Rector/Isset_/IssetOnPropertyObjectToPropertyExistsRector.php

Thanks!

Co-authored-by: Abdul Malik Ikhsan <samsonasik@gmail.com>

* Fixes #5090 Closes 5091 reduce code complexity and add fixture

* fixture

* null check

* null check

* reduce complexity

* fixture fix

Co-authored-by: Lito <lito@eordes.com>
2021-01-05 17:26:39 +01:00
Tomáš Fejfar
1281c67510
Fix for #5086 (#5087) 0.9.5 2021-01-04 18:38:50 +01:00