* Add failing test fixture for RemoveParentAndNameFromComponentConstructorRector
# Failing Test for RemoveParentAndNameFromComponentConstructorRector
Based on https://getrector.org/demo/12f10dc7-7ffb-4fe1-8004-7bf82e7aa9ce
There are multiple problems in this rule:
1) only $name is removed ($parent should be also removed)
2) $name (and if it would work also $parent) is removed also when there is some future use of it (e.g. assigning to private property $this->name = $name)
* Failing fixtures
* Closes#5052
* cs fix
* rename fixture
* rename fixture
* reduce complexity
* refactor
* use Assign
Co-authored-by: Michal Lulco <michal.lulco@gmail.com>
Co-authored-by: Michal Lulco <lulco@efabrica.sk>
* enable file lenght rule
* longer file, just to show ci worked
* [ci] add ValidateFileLengthCommand
* [phpstan] drop PathsAreNotTooLongRule
* [Downgrade] Shorten property promotion rector rule
* [Symfony] Shorten AutoWireWithClassNameSuffixForMethodWithRequiredAnnotationRector name
* shorten fixture name
* rename ChangeControlArrayAccessToAnnotatedControlVariableRector to AnnotateMagicalControlArrayAccessRector
* rename ReplaceMagicEventPropertySubscriberWithEventClassSubscriberRector to ReplaceMagicPropertyWithEventClassRector
* rename GetConfigWithDefaultsArgumentToArrayMergeInCompilerExtensionRector to MergeDefaultsInGetConfigCompilerExtensionRector
* rename ChangeCollectionTypeOptionTypeFromStringToClassReferenceRector to ChangeStringCollectionOptionToConstantRector
* decouple ProjectFilesFinder
* Change file system approach of MultipleClassFileToPsr4ClassesRector to file without namespace node
* update DecoupleClassMethodToOwnClassRector
* [ci] add rebase jobp
* disable fail fast for unit tests
* misc
* [CI] Add type-declaration set
* [rector] [CI] Add type-declaration set
* [cs] [CI] Add type-declaration set
* skip nullable void
* add anonymous parent/interface support
* refactor MultiExceptionCatchRector to use Catch_ over integers
* type fixes
* fix unoin array type override
* remove unused test cases
* drop overcomplicated InlineValidationRulesToArrayDefinitionRector
* skip assign on var
* [rector] skip assign on var
* [cs] skip assign on var
* [rector] [cs] skip assign on var
* skip assign on var
* fixes
* [rector] fixes
* [cs] fixes
Co-authored-by: rector-bot <tomas@getrector.org>
* [phpstan] Add forbidden array destruct to prevent array mess
* use ArrayCallable value object
* add OpeningAndClosingSpace
* drop ConstructorInjectionToActionInjectionRector, antipattern
* use value objects
* [rector] use value objects
Co-authored-by: rector-bot <tomas@getrector.org>
* [Order] Make OrderPrivateMethodsByUseRector process file in one run using while loop
* [Order] Enable rule in CI
* [rector] [Order] Enable rule in CI
* [cs] [Order] Enable rule in CI
* [Order] Use constant for number of max attempts and throw exception when exceeded.
* [rector] [Order] Use constant for number of max attempts and throw exception when exceeded.
* [cs] [Order] Use constant for number of max attempts and throw exception when exceeded.
Co-authored-by: rector-bot <tomas@getrector.org>
* [MagicDisclosure] Add MethodCallOnSetterMethodCallToStandaloneAssignRector
* merge ChainMethodCallManipulator to ChainMethodCallNodeAnalyzer for better DX
* [MagicDisclosure] Add in arg defluent
* rebase
