* decouple TagName class
* remove attribute aware from data provider tag value node, as unique class
* add RequiredTagValueNode
* make Attributes explicit, to avoid confusiong
* added a failing testcase
* initial try to fix 4693
* fix existing if_in_foreach test with wrong expected result
* Restore if_in_foreach.php.inc
* adusted wrong test expectation of if_in_foreach.php
* use betterNodeFinder->findFirstParentInstanceOf
* fix test expectation in if_in_foreach fixture
* fixed method name which was misleading
* fix variable name
* adjust impl
* Restore if_in_foreach.php.inc
* rm unused use
* fix impl
* [Solid] Improve MoveVariableDeclarationNearReferenceRector : skip variabel with usage in multiple level
* function name and var name
* stop calling parent attribute when previous of parent is an Expression with Assign with same variable
* phpstan
* deep up usage
* deeeeep level
* stop while when previous is Expression with Assign same var
* final touch
* [ci-review] Rector Rectify
* keep comment
* cast isFoundNext
* fixed
* separate method
* [ci-review] Rector Rectify
* clean up fixtures
Co-authored-by: rector-bot <tomas@getrector.org>
* Change file system approach of MultipleClassFileToPsr4ClassesRector to file without namespace node
* update DecoupleClassMethodToOwnClassRector
* [ci] add rebase jobp
* disable fail fast for unit tests
* misc
* embed skip fixture of same before/after
* [Testing] Add exception on identical second half of the fixture, that should not change
* [ci] use composer 2 for code_analysis
* [ci-review] Rector Rectify
Co-authored-by: rector-bot <tomas@getrector.org>
* Create test cases
* Create rector
* Add closure to possible parent scopes
* Register in SOLID set
* Document the feature
* fix adding variable in closure
* move MoveVariableDeclarationNearReferenceRector to Assign category, based on getNodeTypes()
* ci: drop phpunit matcher, not much helpful
* ignore for now, many cases to cover
* prepare release
Co-authored-by: Anna Filina <afilina@gmail.com>
* [CodeQuality] Register MoveOutMethodCallInsideIfConditionRector to config code-quality set
* rename use string parameter
* phpstan
* fix false positive string param to be var === variable name
* fix false positive
* phpstan
* ensure not same variable
* phpstan
* add ucfirst after var
* add fixture failing test for variable exists to be skipped
* add fixture failing test for variable exists in previuos statement
* phpstan space
* add handling variable exists in previous statement and in ClassMethod/Functions args
* handle exists but inside if
* reduce complexity
* clean up
* clean up
* cs fix
* phpstan
* remove - in variable
* use fallback when first character is numeric
* using regex to check string start alpha for variable
* cs fix
* use ClassConstFetch name to set variable name
* [ci-review] Rector Rectify
* [ci-review] Rector Rectify
* [ci-review] Rector Rectify
* clean up
* fix
* [ci-review] Rector Rectify
* Update rules/code-quality/src/Rector/If_/MoveOutMethodCallInsideIfConditionRector.php
* Update rules/code-quality/src/Rector/If_/MoveOutMethodCallInsideIfConditionRector.php
Co-authored-by: rector-bot <tomas@getrector.org>
Co-authored-by: Tomas Votruba <tomas.vot@gmail.com>
* [SOLID] Change if && to early return (process nested ifs)
* Skip if with void return
* Skip if parent if has void return
* [rector] Skip if parent if has void return
* [cs] Skip if parent if has void return
Co-authored-by: rector-bot <tomas@getrector.org>
* add monorepo split for symfony-php-config
* [SOLID] Prevent replacing referenced parametes with inlined constnat value
* make Symfon 5.0- compatible
* add support for reference skip in constructor
* [rector] add support for reference skip in constructor
* [cs] add support for reference skip in constructor
* improve misisng rule feedback
* underscore
* Fix ChangeReadOnlyVariableWithDefaultValueToConstantRector for new
* add clear-cache to all commands
* colors
* [rector] colors
* [cs] colors
Co-authored-by: rector-bot <tomas@getrector.org>
* [CI] Add type-declaration set
* [rector] [CI] Add type-declaration set
* [cs] [CI] Add type-declaration set
* skip nullable void
* add anonymous parent/interface support
* refactor MultiExceptionCatchRector to use Catch_ over integers
* type fixes
* fix unoin array type override
* remove unused test cases
* drop overcomplicated InlineValidationRulesToArrayDefinitionRector
* skip assign on var
* [rector] skip assign on var
* [cs] skip assign on var
* [rector] [cs] skip assign on var
* skip assign on var
* fixes
* [rector] fixes
* [cs] fixes
Co-authored-by: rector-bot <tomas@getrector.org>
