57 Commits

Author SHA1 Message Date
Tomas Votruba
cffd7ea0ac
[CodingStyle] Move PHPStormVarAnnotationRector (#4985)
* [CodingStyle] Move PHPStormVarAnnotationRector

* [ci-review] Rector Rectify

* [DeadDocBlock] Move RemoveNonExistingVarAnnotationRector here (#4984)

* [DeadDocBlock] Move RemoveNonExistingVarAnnotationRector here

* [ci-review] Rector Rectify

Co-authored-by: rector-bot <tomas@getrector.org>

* [ci-review] Rector Rectify

* cleanup docs

* static fixes

* [ci-review] Rector Rectify

* remove duplicated

* multi use case

* misc

* [ci-review] Rector Rectify

* fixes

* remove order set, slow

* move UseMessageVariableForSprintfInSymfonyStyleRector from solid set to coding-style

* make unique-named variables to prevent accidental override and improve readability

Co-authored-by: rector-bot <tomas@getrector.org>
2020-12-25 13:20:13 +00:00
Abdul Malik Ikhsan
ec5daad132
[Util] Add StaticInstanceOf (#4979)
Co-authored-by: rector-bot <tomas@getrector.org>
2020-12-25 12:53:26 +01:00
Tomas Votruba
d465ec83e2
[DeadCode] Move RecastingRemovalRector from PHPStan set (#4983)
* [DeadCode] Move RecastingRemovalRector from PHPStan set

* [ci-review] Rector Rectify

* [ci-review] Rector Rectify

* [ci-review] Rector Rectify

Co-authored-by: rector-bot <tomas@getrector.org>
2020-12-25 00:22:45 +00:00
Tomas Votruba
319d6bfca1
add phpstan-for-rector config path, consolidate return type extensions - re-use from Symplify (#4973)
* add phpstan-for-rector config path, to separate phpstan and extensions that help Rector with precise types

* move type value object to value object

* moving

* remove KernelGetContainerAfterBootReturnTypeExtension, use one from symplify

* remove ContainerGetDynamicMethodReturnTypeExtension to ContainerGetReturnTypeExtension

* remove nette extension

* add nette-extension

* removed delegated rule

* delegate implmenets + code sample PHPStan rule to symplify
2020-12-24 16:31:24 +00:00
Abdul Malik Ikhsan
ca0b4cfdc7
[EarlyReturn] Register ChangeOrIfReturnToEarlyReturnRector to early-return set (#4975)
Co-authored-by: rector-bot <tomas@getrector.org>
2020-12-24 17:28:56 +01:00
Abdul Malik Ikhsan
24e17588c1
[Utils] Run validate-fixture-namespace/classname to rules/ directories (#4935) 2020-12-22 18:12:20 +01:00
Tomas Votruba
d131d804d9
Bump min PHP version to 7.3 (#4838)
Co-authored-by: rector-bot <tomas@getrector.org>
2020-12-09 23:25:53 +01:00
Abdul Malik Ikhsan
35d8693187
[NetteUtilsCodeQuality] Fixes #4686 Add SubstrMinusToStringEndsWithRector (#4687)
Co-authored-by: rector-bot <tomas@getrector.org>
2020-11-26 13:33:51 +01:00
Tomas Votruba
a7705ed0a5
[Symplify 9] First update + switch to RuleDocGenerator (#4616)
* [composer] bump to Symplify 9

* [Symplify 9] Update phpstan rules

* bump to Symplify 9 BETA2

* update AbstractKernel from Tests to Testing namespace

* decoupling removing node trait

* remove fluent calls

* removing variadic

* [CodingStyle] Improve AnnotateThrowablesRector

* bump deps

* Make use of RuleDocGenerator

* first short

* [DocumentationGenerator] Drop deprecated package, RuleSetGenerator now handles it

* import namespace

* update docs
2020-11-16 17:50:38 +00:00
Tomas Votruba
0513315056
Change file system approach of MultipleClassFileToPsr4ClassesRector to file without namespace node (#4522)
* Change file system approach of MultipleClassFileToPsr4ClassesRector to file without namespace node

* update DecoupleClassMethodToOwnClassRector

* [ci] add rebase jobp

* disable fail fast for unit tests

* misc
2020-10-31 12:59:40 +00:00
Tomas Votruba
91a354c080
[NetteCodeQuality] Fix ChangeFormArrayAccessToAnnotatedControlVariableRector for in-closure (#4506)
* [NetteCodeQuality] Fix ChangeFormArrayAccessToAnnotatedControlVariableRector for in-closure

* [ci-review] Rector Rectify

* [ci-review] Rector Rectify

* [ci-review] Rector Rectify

* fix name

* fix unknown mixed type on fluent

* [ci-review] Rector Rectify

Co-authored-by: rector-bot <tomas@getrector.org>
2020-10-29 21:25:35 +00:00
Tomas Votruba
0f2e6d407e
[DoctrineAnnotaitonGenerated] Update to doctrine/annotations 1.11 + fix static (#4479) 2020-10-25 14:43:05 +01:00
Igor
f2ecdeb0b1
[Naming] Foreach over "data", renames to "datum" (#4221)
Co-authored-by: rector-bot <tomas@getrector.org>
2020-09-15 10:23:13 +02:00
Tomas Votruba
59c5a5e5ba
[NodeRepository] Merge function like finder to NodeRepository (#4186)
Co-authored-by: rector-bot <tomas@getrector.org>
2020-09-11 00:09:05 +02:00
Tomas Votruba
7ac228c638
[CI] Add type-declaration set (#4089)
* [CI] Add type-declaration set

* [rector] [CI] Add type-declaration set

* [cs] [CI] Add type-declaration set

* skip nullable void

* add anonymous parent/interface support

* refactor MultiExceptionCatchRector to use Catch_ over integers

* type fixes

* fix unoin array type override

* remove unused test cases

* drop overcomplicated InlineValidationRulesToArrayDefinitionRector

* skip assign on var

* [rector] skip assign on var

* [cs] skip assign on var

* [rector] [cs] skip assign on var

* skip assign on var

* fixes

* [rector] fixes

* [cs] fixes

Co-authored-by: rector-bot <tomas@getrector.org>
2020-09-01 17:56:30 +00:00
Tom Pavelec
36b24b2bfc
fix: swapped naming of camel and pascal cases (#4047) 2020-08-28 18:07:15 +02:00
Tomas Votruba
8784a81ff7
[Fluent] Add factory case (#3950) 2020-08-12 20:24:52 +02:00
dobryy
411d76f9a9
[Order] Make OrderPrivateMethodsByUseRector process file in one run u… (#3889)
* [Order] Make OrderPrivateMethodsByUseRector process file in one run using while loop

* [Order] Enable rule in CI

* [rector] [Order] Enable rule in CI

* [cs] [Order] Enable rule in CI

* [Order] Use constant for number of max attempts and throw exception when exceeded.

* [rector] [Order] Use constant for number of max attempts and throw exception when exceeded.

* [cs] [Order] Use constant for number of max attempts and throw exception when exceeded.

Co-authored-by: rector-bot <tomas@getrector.org>
2020-08-05 22:45:36 +02:00
Tomas Votruba
2bd1eac705
use dev nette deps to resolve form/application types (#3879) 2020-08-03 08:51:44 +00:00
Tomas Votruba
39ec802963
[NetteCodeQuality] Fix unset, on purpose (#3877) 2020-08-02 19:54:15 +02:00
Tomas Votruba
552b97d90e
add param type test case (#3876) 2020-08-02 16:58:56 +00:00
Tomas Votruba
e7429d96a4
make use of constant (#3875) 2020-08-02 13:17:33 +00:00
Tomas Votruba
b99a3cbdb2
add case with type form (#3874) 2020-08-02 12:58:14 +00:00
Tomas Votruba
bb6a53fef0
[NetteCodeQuality] Skip isset on form input + multiplier check (#3872) 2020-08-02 12:57:05 +02:00
Tomas Votruba
ee957111c4
fix import slash (#3871) 2020-08-02 10:04:46 +00:00
Tomas Votruba
91bda1b75b
[NetteCodeQuality] Get component (#3870) 2020-08-02 11:39:52 +02:00
Tomas Votruba
6186cdeab7
skip form (#3869) 2020-08-02 01:24:58 +02:00
Tomas Votruba
62ac58e60d
add failing test case + add support for previous assign type dim fetch (#3868) 2020-08-02 00:57:35 +02:00
Tomas Votruba
fa2caf77ed
[NetteCodeQuality] Add ArrayAccessSetControlToAddComponentMethodCallRector (#3867) 2020-08-02 00:18:40 +02:00
Tomas Votruba
55acb3578a
[MagicDisclosure] Add SetterOnSetterMethodCallToStandaloneAssignRector (#3860)
* [MagicDisclosure] Add MethodCallOnSetterMethodCallToStandaloneAssignRector

* merge ChainMethodCallManipulator to ChainMethodCallNodeAnalyzer for better DX

* [MagicDisclosure] Add in arg defluent

* rebase
2020-08-01 11:41:16 +00:00
TomasVotruba
1c2045e710 add assign to root stmt to prevent non-existing variable 2020-07-30 23:33:13 +02:00
TomasVotruba
fd6f905651 cover parent createComponent() too 2020-07-30 23:00:55 +02:00
TomasVotruba
b9fd318ac2 skip on method call 2020-07-30 22:16:38 +02:00
TomasVotruba
bdb7256626 [Nette] Add ArrayDimFetchControlToGetComponentMethodCallRector 2020-07-30 22:11:52 +02:00
TomasVotruba
9f51a32d36 [Nette] Rename follow up variables too 2020-07-30 20:29:09 +02:00
TomasVotruba
2da8e94ef1 [Nette] Skip nested control access to /ChangeControlArrayAccessToAnnotatedControlVariableRector 2020-07-30 17:57:22 +02:00
TomasVotruba
747f3cd45c addJSelect to form options 2020-07-29 11:06:47 +02:00
TomasVotruba
9488eb5d07 add debug notes 2020-07-29 03:39:48 +02:00
dobryy
dd9eda12c6 Apply rule 2020-07-27 16:39:34 +02:00
TomasVotruba
9e7c30cef3 fix create component method name 2020-07-27 14:44:23 +02:00
TomasVotruba
955f7a7e76 refactor arra dim fetch to exclusive rules 2020-07-27 13:18:18 +02:00
TomasVotruba
e647b8f003 decopule PropertyDocBlockManipulator 2020-07-27 12:56:13 +02:00
TomasVotruba
99db894192 restore types 2020-07-27 10:44:51 +02:00
TomasVotruba
42decbb0c5 add nested callback case 2020-07-27 07:27:17 +02:00
TomasVotruba
63c515a834 [Nette] Load data from __construct of same class 2020-07-27 02:07:36 +02:00
TomasVotruba
16e3745eac decopule AbstractArrayDimFetchToAnnotatedControlVariableRector 2020-07-27 01:30:16 +02:00
TomasVotruba
f2e6968396 prevent duplicated form assign adding 2020-07-27 01:17:17 +02:00
TomasVotruba
d6624f343e add duplicated assign case 2020-07-27 01:10:39 +02:00
TomasVotruba
496934818a [Nette] skip non contorl adding add methods 2020-07-27 00:25:03 +02:00
TomasVotruba
b377b73ad4 decouple NetteFormMethodNameToControlType value object 2020-07-27 00:04:53 +02:00