* Move duplicated getAttributableItems() method to abstract parent
* Add removeItem() method to AbstractTagValueNode class
* Add RemoveRedundantDefaultAnnotationValuesRector rule with tests
* Link second test case of RemoveRedundantDefaultAnnotationValuesRector
* Add to set and docs
* Rename variable in DoctrineClassAnalyzer::matchDoctrineEntityTagValueNode()
* Remove redundant docblocks in RemoveRedundantDefaultAnnotationValuesRector
* Extract hasItemWithDefaultValue method in RemoveRedundantDefaultAnnotationValuesRector
* Optimize RemoveRedundantDefaultAnnotationValuesRector
* Split rule into two separate: one for Property and one for Class_
* PHP CS Fixer
* PHPStan
* Change file system approach of MultipleClassFileToPsr4ClassesRector to file without namespace node
* update DecoupleClassMethodToOwnClassRector
* [ci] add rebase jobp
* disable fail fast for unit tests
* misc
* embed skip fixture of same before/after
* [Testing] Add exception on identical second half of the fixture, that should not change
* [ci] use composer 2 for code_analysis
* [ci-review] Rector Rectify
Co-authored-by: rector-bot <tomas@getrector.org>
* Create test cases
* Create rector
* Add closure to possible parent scopes
* Register in SOLID set
* Document the feature
* fix adding variable in closure
* move MoveVariableDeclarationNearReferenceRector to Assign category, based on getNodeTypes()
* ci: drop phpunit matcher, not much helpful
* ignore for now, many cases to cover
* prepare release
Co-authored-by: Anna Filina <afilina@gmail.com>
* nette-30 config cleanup
* [TypeDeclaratoin] Move AddReturnTypeDeclarationRector from generic
* add Type support to AddReturnTypeDeclaration
* make AddParamTypeDeclarationRector use PHPStan type objects over strings
* [SymfonyPhpConfig] Add support for nested types
* drop StringTypeToPhpParserNodeMapper
* [ci-review] Rector Rectify
Co-authored-by: rector-bot <tomas@getrector.org>
* skip rename
* add method call and variable name for MoveOutMethodCallInsideIfConditionRector
* decouple MethodCallToVariableNameResolver
* use trick with Scope if variable is already defined
* fixup! use trick with Scope if variable is already defined
* cover case with variable name and method call
* add decopule note future
* [ci-review] Rector Rectify
* [ci] try re-trigger ci-review after push automatically
Co-authored-by: rector-bot <tomas@getrector.org>
* [set] decouple new code-quality-strict
* decopule early-return set [closes#4464]
* [docker] drop prestissimo, as composer v2 does not need it
* [ci] move coding standard to ci_review
* [ci] try to run rector-ci on contributors
* [CodeQuality] Register MoveOutMethodCallInsideIfConditionRector to config code-quality set
* rename use string parameter
* phpstan
* fix false positive string param to be var === variable name
* fix false positive
* phpstan
* ensure not same variable
* phpstan
* add ucfirst after var
* add fixture failing test for variable exists to be skipped
* add fixture failing test for variable exists in previuos statement
* phpstan space
* add handling variable exists in previous statement and in ClassMethod/Functions args
* handle exists but inside if
* reduce complexity
* clean up
* clean up
* cs fix
* phpstan
* remove - in variable
* use fallback when first character is numeric
* using regex to check string start alpha for variable
* cs fix
* use ClassConstFetch name to set variable name
* [ci-review] Rector Rectify
* [ci-review] Rector Rectify
* [ci-review] Rector Rectify
* clean up
* fix
* [ci-review] Rector Rectify
* Update rules/code-quality/src/Rector/If_/MoveOutMethodCallInsideIfConditionRector.php
* Update rules/code-quality/src/Rector/If_/MoveOutMethodCallInsideIfConditionRector.php
Co-authored-by: rector-bot <tomas@getrector.org>
Co-authored-by: Tomas Votruba <tomas.vot@gmail.com>
* Add MoveOutMethodCallInsideIfConditionRector
* cs fix
* implemented handling pass constant to arg 0
* phpstan
* final touch: no need strtolower() before ucfirst on fallback var name