75 Commits

Author SHA1 Message Date
Tomas Votruba
ba1444959d
[TypeDeclaration] Improve param by caller type #2 (#5787) 2021-03-07 14:27:17 +00:00
Abdul Malik Ikhsan
d7592f59ec
[Naming] Register RenameForeachValueVariableToMatchExprVariableRector to naming config set (#5696)
* [Naming] Register RenameForeachValueVariableToMatchExprVariableRector to naming config set

* fix property fetch not from this

* [ci-review] Rector Rectify

* [ci-review] Rector Rectify

* [ci-review] Rector Rectify

* fix

* [ci-review] Rector Rectify

* [ci-review] Rector Rectify

* fixture fix

* phpstan

* [ci-review] Rector Rectify

* phpstan

* extract to separate method for collect assigns by name

* adding InflectorSingularResolver service

* skip single prefix and length >= 40

* add failing fixture to skip plural camel case

* use regex to get camel cases

* implemented singularize camel cased

* [ci-review] Rector Rectify

* [ci-review] Rector Rectify

* [ci-review] Rector Rectify

* phpstan

* handle singular verb news -> new

* [ci-review] Rector Rectify

* fixture fix

* handle has

* [ci-review] Rector Rectify

* [ci-review] Rector Rectify

* [ci-review] Rector Rectify

* phpstan

* phpstan

* handle left side By

* [ci-review] Rector Rectify

* re-use resolve call

* [ci-review] Rector Rectify

* phpstan

* [ci-review] Rector Rectify

* final touch

* final touch

* [ci-review] Rector Rectify

* [ci-review] Rector Rectify

* use previous By in the middle

* update $childClassReflection->hasProperty($propertyName)

* [ci-review] Rector Rectify

* catchKeys

* regex fix

* fixture

* [ci-review] Rector Rectify

* try use check array

* Revert "try use check array"

This reverts commit adb9f767f20ea2544e5ccfc9cfe361ecc929912a.

* use files

Co-authored-by: kaizen-ci <info@kaizen-ci.org>
2021-03-05 11:55:40 +01:00
Tomas Votruba
a63b232eca
cleanup (#5763) 2021-03-03 21:51:04 +00:00
Tomas Votruba
382f146eaf
Merge CoreRectorInterface (#5762) 2021-03-03 22:28:27 +01:00
TomasVotruba
c6bf799da4 simplify complexity 2021-03-02 14:44:18 +01:00
Tomas Votruba
d5bf66f9cd
[CI] run rules dir by dir to identify static reflection weak sposts (#5720)
* [CI] run rules dir by dir to identify static reflection weak sposts

* [ci-review] Rector Rectify

* consistency

* remove unused property

* add data provider test fixture

* add InvertedIfFactory to lower complexity

* [DeadCode] Skip unused public method if data provider

* misc

* [DeadCode] Do not remove class method if required by parent ocntract

* make use of ContextAnalyzer to find the loop

* narrow dirs one level

* narrow packages

* narrow

* use directly

* narrow

* correct constant name to keep BC

* bump deps

* add version_compare to removed extra params, just to be sure

* do not return function node on unchanged name

* narrow

* add support for multiple variants

* widen

* remove double check [skip ci]

Co-authored-by: kaizen-ci <info@kaizen-ci.org>
2021-03-02 14:43:36 +01:00
Tomas Votruba
4909e63a1d
Make use of static reflection from PHPStan (#5665)
* break test without autoload

* PHPStanServiceFactory - add tests directory as analysed paths

* use ReflectionProvider instead of class_exists

* use native reflections for annotation reader

* use native class and method reflections

* add RectorBetterReflectionSourceLocatorFactory

* add DynamicSourceLocator that is shared by PHPStan and Rector

* use ReflectoinProvider instead of class_exists()

* resolve native ClassMethodReflection

* make AnonymousFunctionFactory use reflection

* [DowngradePHP74] Improve DowngradeCovariantReturnTypeRector

* phsptan: avoid ClassReflection

* ProcessCommand: add file infos to source locator

* [DeadCode] Skip RemoveUnusedPublicMethodRector for test

* remove autolaod from tests

* misc

* remove is_a()

* [CI] enable only few dirs to avoid fails

* misc

* [ci-review] Rector Rectify

* [ci-review] Rector Rectify

Co-authored-by: kaizen-ci <info@kaizen-ci.org>
2021-02-28 08:47:48 +01:00
Tomas Votruba
a61a2c6e5e
use getNodeTypes() with class-string generic type (#5692)
Co-authored-by: kaizen-ci <info@kaizen-ci.org>
2021-02-27 00:06:15 +00:00
Abdul Malik Ikhsan
f1f14c25d8
[EarlyReturn] Handle ChangeAndIfToEarlyReturnRector has Return expr in if stmt fixture (#5627)
Co-authored-by: kaizen-ci <info@kaizen-ci.org>
2021-02-21 10:32:45 +01:00
Tomas Votruba
362ebbea46
[TypeDeclaration] Add ReturnTypeFromReturnNewRector (#5624)
Co-authored-by: kaizen-ci <info@kaizen-ci.org>
2021-02-19 12:01:23 +00:00
Tomas Votruba
9f5bc8fa16
use ->getNativeType() to get native types (#5601) 2021-02-18 21:34:07 +01:00
Tomas Votruba
c609697f14
[TypeDeclarationStrict] Add AddMethodCallBasedStrictParamTypeRector (#5580) 2021-02-17 16:40:29 +01:00
Tomas Votruba
de8fa30257
[cs] apply indent of call in configs (#5547) 2021-02-14 21:28:21 +00:00
Tomas Votruba
afdf5839e7
[testing] change provideConfigFileInfo() to provideConfigFilePath() (#5518) 2021-02-12 19:19:40 +01:00
Tomas Votruba
ecbef2bcaa
[Tests] remove getPhpVersion() helped method, use configs instead (#5477) 2021-02-09 17:25:16 +00:00
Tomas Votruba
e0ad0f960f
[Tests] Move from getRectorsWithConfiguration() to provideConfigFileInfo() to make test configs more intuitive (#5468)
Co-authored-by: kaizen-ci <info@kaizen-ci.org>
2021-02-09 15:02:29 +01:00
Tomas Votruba
5e95bbb294
Remove NotifyingNodeRemover, RemovedAndAddedFilesTrait, merge traits to AbstractRector (#5466)
Co-authored-by: kaizen-ci <info@kaizen-ci.org>
2021-02-09 01:52:35 +00:00
Tomas Votruba
50f6adf47e
consolidate AbstractRectorTrait (#5464)
Co-authored-by: kaizen-ci <info@kaizen-ci.org>
2021-02-08 21:00:45 +00:00
Tomas Votruba
d7353baf2c
Misc cleanup (#5456)
Co-authored-by: kaizen-ci <info@kaizen-ci.org>
2021-02-08 12:33:17 +00:00
Tomas Votruba
7293c3c2a8
less traits 2 (#5384) 2021-01-30 23:20:05 +00:00
Tomas Votruba
734972d4b0
less traits (#5383) 2021-01-30 21:41:25 +00:00
Tomas Votruba
fa3af124b0
[DeadDocBlock] Add RemoveUselessVarTagRector (#5382)
Co-authored-by: rector-bot <tomas@getrector.org>
2021-01-30 22:16:37 +01:00
Tomas Votruba
e2757242be
Various stabilizations (#5381) 2021-01-30 20:30:37 +00:00
Tomas Votruba
024ec4ba93
[Generics] Add GenericsPHPStormMethodAnnotationRector (#5365)
Co-authored-by: rector-bot <tomas@getrector.org>
2021-01-29 17:24:20 +01:00
Tomas Votruba
53835a751e
[PHP 7.1] Fix AssignArrayToStringRector for dynamic property fetch names (#5305) 2021-01-24 21:43:15 +00:00
Abdul Malik Ikhsan
c2c5228199
[TypeDeclaration] Improve FlipTypeControlToUseExclusiveTypeRector : add Nullable support for Assign expr (#5254)
Co-authored-by: rector-bot <tomas@getrector.org>
2021-01-20 11:41:35 +00:00
Tomas Votruba
014c019449
[fixtures] require skip prefix on skipped files (#5079)
* skip unnecesary test case

* namespace corrections, skip prefix corrections

* hide for now

* skip new phpstan cases
2021-01-03 15:54:27 +00:00
Tomas Votruba
a2dbaedb0e
[Privatization] Move MakeUnusedClassesWithChildrenAbstractRector here (#4987) 2020-12-25 15:45:17 +01:00
Tomas Votruba
cffd7ea0ac
[CodingStyle] Move PHPStormVarAnnotationRector (#4985)
* [CodingStyle] Move PHPStormVarAnnotationRector

* [ci-review] Rector Rectify

* [DeadDocBlock] Move RemoveNonExistingVarAnnotationRector here (#4984)

* [DeadDocBlock] Move RemoveNonExistingVarAnnotationRector here

* [ci-review] Rector Rectify

Co-authored-by: rector-bot <tomas@getrector.org>

* [ci-review] Rector Rectify

* cleanup docs

* static fixes

* [ci-review] Rector Rectify

* remove duplicated

* multi use case

* misc

* [ci-review] Rector Rectify

* fixes

* remove order set, slow

* move UseMessageVariableForSprintfInSymfonyStyleRector from solid set to coding-style

* make unique-named variables to prevent accidental override and improve readability

Co-authored-by: rector-bot <tomas@getrector.org>
2020-12-25 13:20:13 +00:00
Tomas Votruba
61b72a8d7c
[DeadDocBlock] Move RemoveNonExistingVarAnnotationRector here (#4984)
* [DeadDocBlock] Move RemoveNonExistingVarAnnotationRector here

* [ci-review] Rector Rectify

Co-authored-by: rector-bot <tomas@getrector.org>
2020-12-25 00:56:59 +00:00
Tomas Votruba
d465ec83e2
[DeadCode] Move RecastingRemovalRector from PHPStan set (#4983)
* [DeadCode] Move RecastingRemovalRector from PHPStan set

* [ci-review] Rector Rectify

* [ci-review] Rector Rectify

* [ci-review] Rector Rectify

Co-authored-by: rector-bot <tomas@getrector.org>
2020-12-25 00:22:45 +00:00
Abdul Malik Ikhsan
ca0b4cfdc7
[EarlyReturn] Register ChangeOrIfReturnToEarlyReturnRector to early-return set (#4975)
Co-authored-by: rector-bot <tomas@getrector.org>
2020-12-24 17:28:56 +01:00
Abdul Malik Ikhsan
24e17588c1
[Utils] Run validate-fixture-namespace/classname to rules/ directories (#4935) 2020-12-22 18:12:20 +01:00
Abdul Malik Ikhsan
720b2c34eb
[EarlyReturn] Enable ReturnBinaryAndToEarlyReturnRector in early-return config set (#4915)
Co-authored-by: rector-bot <tomas@getrector.org>
2020-12-19 16:24:53 +01:00
Tomas Votruba
db5e02e724
static fixes (#4860)
Co-authored-by: rector-bot <tomas@getrector.org>
2020-12-12 13:08:34 +01:00
Leonardo Losoviz
e6ca54bdce
Fixed inconsistent naming: PHP_7_3 to PHP_73 (#4849) 2020-12-11 10:04:50 +01:00
Tomas Votruba
d131d804d9
Bump min PHP version to 7.3 (#4838)
Co-authored-by: rector-bot <tomas@getrector.org>
2020-12-09 23:25:53 +01:00
Tomas Votruba
080e5cbe00
use symplify/skipper (#4689) 2020-11-26 23:09:21 +01:00
Abdul Malik Ikhsan
a38debb672
[DX] Fixes #4205 Change phpversion from string to php constant int type (#4679)
Co-authored-by: rector-bot <tomas@getrector.org>
2020-11-24 16:32:49 +01:00
Tomas Votruba
a7705ed0a5
[Symplify 9] First update + switch to RuleDocGenerator (#4616)
* [composer] bump to Symplify 9

* [Symplify 9] Update phpstan rules

* bump to Symplify 9 BETA2

* update AbstractKernel from Tests to Testing namespace

* decoupling removing node trait

* remove fluent calls

* removing variadic

* [CodingStyle] Improve AnnotateThrowablesRector

* bump deps

* Make use of RuleDocGenerator

* first short

* [DocumentationGenerator] Drop deprecated package, RuleSetGenerator now handles it

* import namespace

* update docs
2020-11-16 17:50:38 +00:00
Tomas Votruba
0513315056
Change file system approach of MultipleClassFileToPsr4ClassesRector to file without namespace node (#4522)
* Change file system approach of MultipleClassFileToPsr4ClassesRector to file without namespace node

* update DecoupleClassMethodToOwnClassRector

* [ci] add rebase jobp

* disable fail fast for unit tests

* misc
2020-10-31 12:59:40 +00:00
Abdul Malik Ikhsan
9e0b632e4e
[CodeQualityStrict] Add CountArrayToEmptyArrayComparisonRector to CodeQualityStrict (#4496)
Co-authored-by: rector-bot <tomas@getrector.org>
Co-authored-by: Tomas Votruba <tomas.vot@gmail.com>
2020-10-29 09:59:39 +01:00
Tomas Votruba
a1e50263d2
[cs] improve configured rules types (#4491)
* [cs] improve configured rules types

* [ci] update env variable
2020-10-27 14:00:39 +00:00
Abdul Malik Ikhsan
7a1ea1328b
[CodeQuality] Register MoveOutMethodCallInsideIfConditionRector to config code-quality set (#4477)
* [CodeQuality] Register MoveOutMethodCallInsideIfConditionRector to config code-quality set

* rename use string parameter

* phpstan

* fix false positive string param to be var === variable name

* fix false positive

* phpstan

* ensure not same variable

* phpstan

* add ucfirst after var

* add fixture failing test for variable exists to be skipped

* add fixture failing test for variable exists in previuos statement

* phpstan space

* add handling variable exists in previous statement and in ClassMethod/Functions args

* handle exists but inside if

* reduce complexity

* clean up

* clean up

* cs fix

* phpstan

* remove - in variable

* use fallback when first character is numeric

* using regex to check string start alpha for variable

* cs fix

* use ClassConstFetch name to set variable name

* [ci-review] Rector Rectify

* [ci-review] Rector Rectify

* [ci-review] Rector Rectify

* clean up

* fix

* [ci-review] Rector Rectify

* Update rules/code-quality/src/Rector/If_/MoveOutMethodCallInsideIfConditionRector.php

* Update rules/code-quality/src/Rector/If_/MoveOutMethodCallInsideIfConditionRector.php

Co-authored-by: rector-bot <tomas@getrector.org>
Co-authored-by: Tomas Votruba <tomas.vot@gmail.com>
2020-10-26 14:03:26 +00:00
Tomas Votruba
0f2e6d407e
[DoctrineAnnotaitonGenerated] Update to doctrine/annotations 1.11 + fix static (#4479) 2020-10-25 14:43:05 +01:00
TomasVotruba
7c303021c4 [PHP 7.1] Skip variable arguments count for RemoveExtraParametersRector 2020-10-20 15:05:37 +02:00
Tomas Votruba
fd9bd00713
[DoctrineCodeQuality] Fix oveCurrentDateTimeDefaultInEntityToConstructorRector for default value (#4436)
* [DoctrineCodeQuality] Fix oveCurrentDateTimeDefaultInEntityToConstructorRector for default value

* re-use local property method

* improve new_ nesting

* [rector] improve new_ nesting

* static fixes

* bump deps

Co-authored-by: rector-bot <tomas@getrector.org>
2020-10-18 08:45:56 +00:00
Igor
874baec836
[SOLID] Change if && to early return (more than two conditions) (#4390)
Co-authored-by: rector-bot <tomas@getrector.org>
2020-10-11 11:43:51 +02:00
TomasVotruba
4103cbce07 fix cs 2020-10-02 12:07:55 +02:00
Igor
19f700ba4e
[Naming] Factory to create PropertyRename (#4255)
* [Naming] Use factory to create PropertyRename

* Ignore new phpstan issues

* Move fixture to FixtureBasic to solve CI issue

* fix setUp vs dataProvider race condition

* fix autoload

Co-authored-by: TomasVotruba <tomas.vot@gmail.com>
2020-09-21 20:45:43 +00:00