From 1d1b79b6cf7ce4181ef7dd4c2a4d118da78786e7 Mon Sep 17 00:00:00 2001 From: ldsink Date: Tue, 8 Dec 2015 21:19:36 +0800 Subject: [PATCH 1/4] update PHPDoc comments --- var/Typecho/Router.php | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/var/Typecho/Router.php b/var/Typecho/Router.php index 483ee820..49956f4e 100644 --- a/var/Typecho/Router.php +++ b/var/Typecho/Router.php @@ -110,9 +110,8 @@ class Typecho_Router /** * 路由分发函数 * - * @param string $path 目的文件所在目录 * @return void - * @throws Typecho_Route_Exception + * @throws Typecho_Router_Exception */ public static function dispatch() { @@ -159,7 +158,7 @@ class Typecho_Router * 路由反解析函数 * * @param string $name 路由配置表名称 - * @param string $value 路由填充值 + * @param array $value 路由填充值 * @param string $prefix 最终合成路径的前缀 * @return string */ @@ -200,7 +199,7 @@ class Typecho_Router * @param string $routeName 路由名称 * @static * @access public - * @return void + * @return mixed */ public static function get($routeName) { From e3cdc44edc5e21aabd22cd691e46d81af8170f7a Mon Sep 17 00:00:00 2001 From: ldsink Date: Tue, 8 Dec 2015 21:36:13 +0800 Subject: [PATCH 2/4] process Widget --- var/Typecho/Widget.php | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/var/Typecho/Widget.php b/var/Typecho/Widget.php index 9f45cdbf..5636b3d4 100644 --- a/var/Typecho/Widget.php +++ b/var/Typecho/Widget.php @@ -91,7 +91,7 @@ abstract class Typecho_Widget * config对象 * * @access public - * @var public + * @var Typecho_Config */ public $parameter; @@ -102,7 +102,6 @@ abstract class Typecho_Widget * @param mixed $request request对象 * @param mixed $response response对象 * @param mixed $params 参数列表 - * @return void */ public function __construct($request, $response, $params = NULL) { @@ -244,7 +243,7 @@ abstract class Typecho_Widget * 将类本身赋值 * * @param string $variable 变量名 - * @return void + * @return self */ public function to(&$variable) { @@ -285,7 +284,6 @@ abstract class Typecho_Widget * 根据余数输出 * * @access public - * @param string $param 需要输出的值 * @return void */ public function alt() From a498669ad86839dabd37d394b6bb29f382454c58 Mon Sep 17 00:00:00 2001 From: ldsink Date: Tue, 8 Dec 2015 21:42:02 +0800 Subject: [PATCH 3/4] add excption throws --- var/Typecho/Router.php | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/var/Typecho/Router.php b/var/Typecho/Router.php index 49956f4e..927a6772 100644 --- a/var/Typecho/Router.php +++ b/var/Typecho/Router.php @@ -46,6 +46,7 @@ class Typecho_Router * @param string $pathInfo 全路径 * @param mixed $parameter 输入参数 * @return mixed + * @throws Exception */ public static function match($pathInfo, $parameter = NULL) { @@ -111,7 +112,7 @@ class Typecho_Router * 路由分发函数 * * @return void - * @throws Typecho_Router_Exception + * @throws Exception */ public static function dispatch() { From 925daaeb6352a5adb409f649e92727c1bca7b04b Mon Sep 17 00:00:00 2001 From: ldsink Date: Tue, 8 Dec 2015 21:50:59 +0800 Subject: [PATCH 4/4] constructors, the @return tag MAY be omitted here, in which case @return self is implied. --- var/Typecho/Router/Parser.php | 1 - 1 file changed, 1 deletion(-) diff --git a/var/Typecho/Router/Parser.php b/var/Typecho/Router/Parser.php index 3f1a715c..9aed8192 100644 --- a/var/Typecho/Router/Parser.php +++ b/var/Typecho/Router/Parser.php @@ -48,7 +48,6 @@ class Typecho_Router_Parser * * @access public * @param array $routingTable 路由器映射表 - * @return void */ public function __construct(array $routingTable) {