jacobdekeizer
3a28771c2c
Fix registerSchedule typehint in PluginBase ( #4871 )
2020-01-10 11:55:54 +08:00
Luke Towers
64d7464ed3
Improve cms.combiner.beforePrepare event docs
...
Related: #4865
2020-01-06 11:40:20 -06:00
Samuel Georges
adb303a53c
Always sort plugins by key, then dependencies
...
This has been benchmarked and appears to have minimal impact on performance and solves unnecessary randomness and race conditions during the app's registration and boot cycle
Fixes #4826
2019-12-21 20:50:28 +11:00
Samuel Georges
70e57120d0
ApplicationException -> SystemException
...
This appears to be a typoe. It doesn't make sense to ever log "user errors", only "system errors"
Fixes #4569
2019-12-10 19:59:49 +11:00
Larry Barker
2b05d01c6c
Support additional file name and path characters in media manager ( #4564 )
...
* Support additional file name and path characters in media manager
When working with abstract file names that may contain additional characters, such as quotes or ampersands, the media manager would throw an error. This PR adds two additional characters to the character whitelist.
* Add unicode filename to tests
2019-12-05 19:44:04 +11:00
Luke Towers
7e98e199a4
Revert #4567 , fixes #4648 .
...
If including the asset extension is important, this can be done by listening to the `system.assets.beforeAddAsset(&$type, &$path, &$attributes)` event introduced in Build 460.
2019-11-28 10:32:34 -06:00
Ben Thomson
e9abdf7783
Parenthesise some double ternary conditions in Asset Combiner.
...
Improve compatibility with PHP 7.4, where "Unparenthesized `a ? b : c ?: d` is deprecated"
Fixes #4790 .
2019-11-28 09:21:03 +08:00
Marc Jauvin
992e84e602
Add missing documentation comment blocks for fired events ( #4788 )
...
Credit to @mjauvin.
2019-11-24 23:59:00 -06:00
Samuel Georges
1b22b851f6
Merge pull request #4428 from alxy/patch-27
...
Fix error when $user is null
2019-09-21 13:36:30 +10:00
alekseyp
5afb1ee04f
Include file extension in combiner URLs ( #4567 )
...
Credit to @alekseyp.
2019-08-25 19:52:14 -06:00
Dan Harrin
9521dd795c
Minor Formatting Corrections in Usage Comments ( #4541 )
...
Credit to @DanHarrin
2019-08-15 09:14:54 -06:00
Dan Harrin
67c9decb20
Standardise use of [] vs array() ( #4548 )
...
Credit to @DanHarrin
2019-08-14 20:46:36 -06:00
Ben Thomson
a59d3b83eb
Code quality clean up ( #4449 )
...
Credit to @bennothommo
2019-07-18 08:50:37 -06:00
Alexander Guth
7c6631f2d4
Fix error when $user is null
...
I have no idea why the $user variable can ever be null in the first place, but for me it happens if I remove all main menu items (including the settings). The same check is already in place at the navigation manager: https://github.com/octobercms/october/blob/master/modules/backend/classes/NavigationManager.php#L509-L511
The change shouldn't brake anything.
2019-07-03 22:17:36 +02:00
Tobias Kündig
604f0d060d
Make plugin dependency checks case-insensitive ( #4337 )
...
Normalize the plugin identifier before lookup in the `hasPlugin` call, which should allow plugin dependencies to resolve if mis-cased in the Plugin `$require` property.
Credit to @tobias-kuendig.
2019-07-02 22:12:29 +08:00
Jim Cottrell
e2c89fb3a2
If using database, don't call plugin task scheduling until initial system migration runs. ( #3712 )
...
Fixes #3208 . Replaces #3706 . Credit to @jimcottrell
2019-04-19 14:54:48 -06:00
Siarhei Karavai
2e0d2d3888
Allow subdirectories in migration file names ( #4225 )
...
Credit to @GinoPane. Fixes #4224 .
2019-03-31 08:46:33 -06:00
Samuel Georges
c5bc804d73
Remove redundant header_remove() call
...
The response is returned directly to the route so this is not needed, it was likely added as an artefact of a previous implementation
Refs #3773
Refs #3746
2019-03-29 06:02:06 +11:00
Luke Towers
bb872f331c
Merge pull request #4218 from octobercms/fix/4209
...
Fixes #4209 , replaces #4215
2019-03-28 09:43:09 -06:00
Samuel Georges
adc74ac02e
Add changelog link to updates screen - Fixes #4101
2019-03-29 00:21:51 +11:00
Luke Towers
c86bec7f08
Replace deprecated Twig class references, refs: #4209 .
2019-03-27 13:15:17 -06:00
Siarhei Karavai
8606db9e77
Add support for file names with multiple dots ( #4211 )
...
Fixes #4210 . Credit to @GinoPane
2019-03-25 09:57:06 -06:00
alekseyp
8ea36eac9c
Return 500 on exception during asset combining ( #4142 )
...
Credit to @alekseyp
2019-02-27 14:33:48 -06:00
Luke Towers
7f3fb06945
Support custom 500 page when debug mode disabled and CMS module not present
2019-02-26 14:26:56 -06:00
Siarhei Karavai
9581b23d1e
Allow multiline changelog messages, preserve correct order of updates ( #4083 )
...
Credit to @GinoPane
2019-02-19 11:11:43 -06:00
Adam Sandström
d5eca59dc6
Remove application root relative to domain root from $mediaFinder->storagePath ( #4055 )
...
This gets added later through the use of Url::to(). Credit to @adsa95. Fixes #4065 , fixes #4039
2019-01-23 01:25:16 -06:00
Aleksey Bobkov
d701e65652
Minor improvement in the update gateway API calls.
2019-01-09 17:24:25 -08:00
Aleksey Bobkov
4fa237eadf
Added update gateway client name.
2019-01-05 15:39:46 -08:00
Aleksey Bobkov
bff2f1d59e
Minor improvement in the update gateway API calls.
2019-01-05 15:18:04 -08:00
Ben Thomson
2002fd6b4b
Prevent plugins that cannot be instantiated from being loaded ( #3956 )
...
Credit to @bennothommo
2018-12-04 11:22:07 -06:00
Adam Sandström
bd2f14d510
Make media URLs in accordance with the Link Policy ( #3536 )
...
Credit to @adsa95
2018-12-01 15:08:04 -06:00
Antonie Hogewoning
e481206b49
Add file specific aliases for framework.extras ( #3936 )
...
This commit adds two new aliases for the files associated with `framework.extras`. One to load the CSS (`framework.extras.css`) and for JS (`framework.extras.js`). Credit to @CptMeatball. Resolves #3909 . Related: https://github.com/octobercms/docs/pull/334
2018-11-22 09:25:51 -06:00
Antonie Hogewoning
0e9b3ce786
Combine jQuery and migrate into the same file ( #3919 )
...
Fixes #3917 . This fixes the double alias that was introduced when jquery was updated and migrate was added. Credit to @CptMeatball
2018-11-17 16:22:51 -06:00
Ayumi Hamasaki
567f415e1e
Updated jQuery from V2 to V3.3.1, added jQuery Migrate ( #3886 )
...
Credit to @ayumihamsaki. Fixes #3230 .
2018-10-30 19:36:44 -06:00
Tobias Kündig
7b4e293074
Added registerMailLayouts method to PluginBase ( #3850 )
...
Fixes #3820 . Credit to @tobias-kuendig
2018-10-08 08:18:43 -06:00
Tobias Kündig
0415e4133d
Allow plugins to register their own mail partials ( #3847 )
...
Credit to @tobias-kuendig
* Added registerMailPartials method to PluginBase
2018-10-06 22:00:43 -06:00
Levente Huszko
edcc4af68a
Properly utilize the plainOnly flag in mail.beforeAddContent ( #3479 )
...
Credit to @hlev
2018-09-24 16:54:16 -06:00
TimFoerster
51d79ffaba
Make auto inline brand CSS for email layouts optional ( #3192 )
...
Fixes #3133 . Credit to @TimFoerster. Thanks to all the reviewers from #3192 .
2018-09-23 20:49:19 -06:00
Rike-cz
a03a76ee52
Finish implementing localPath in combineToFile ( #3727 )
...
Fixes #3721 . Credit to @Rike-cz
2018-09-23 14:38:59 -06:00
chrisbethelepb
0ffdbc5efd
Relax restrictions on MediaLibrary filenames ( #3778 )
...
Fixes #3741 . Credit to @chrisbethelepb
2018-09-12 11:37:21 -06:00
Nathan van der Werf
8fd16d4db6
Merge branch 'develop' into feature/cleanup
...
# Conflicts:
# modules/backend/formwidgets/FileUpload.php
2018-08-24 19:52:54 +02:00
Nathan van der Werf
0f0d108da0
Remove unused imports
2018-08-24 19:51:59 +02:00
Nathan van der Werf
66fa03f17e
Revert "Remove unused imports"
...
This reverts commit 742a5f415bc45819b11c77402efc114fa2f4451e.
2018-08-24 19:40:40 +02:00
Samuel Georges
bf841b4340
Minor peer review
2018-08-21 13:24:59 +10:00
Samuel Georges
ab4074cec1
Extra table check
...
Fixes #3706
2018-08-18 12:52:05 +10:00
Samuel Georges
ab7dda260b
User disabled plugins now stay disabled after sign in
...
Fixes #1795
Fixes #3691
2018-08-16 14:11:05 +10:00
Nathan van der Werf
ee9414f3fd
Simplify ternary operators
2018-08-15 19:26:20 +02:00
Nathan van der Werf
8b6f11e6ac
Extract child instructions
2018-08-15 19:25:42 +02:00
Nathan van der Werf
fbca3bea92
Remove redundant variables
2018-08-15 19:23:12 +02:00
Nathan van der Werf
62c59a4903
Refactor ternary operators to null coalescing operators
2018-08-15 19:15:13 +02:00