winter

mirror of https://github.com/wintercms/winter.git synced 2024-06-28 05:33:29 +02:00

History

Luke Towers 812c0552e8 Avoid logging SystemExceptions twice

SystemExceptions are already logged when the System ServiceProvider listens to the Message Logged event, this code used to be for ApplicationExceptions to bypass the fact that they were explicitly ignored by October's core exception handler.

ApplicationExceptions were added 27 Jan 2015 in 6a68036260
ApplicationExceptions were explicitly ignored in the core exception handler on 16 Feb 2015 in 237d97d87a (diff-b6bf0348130fdd1311473a97536310cdR20) and were explicitly logged in the System exception handler on the same day in 7b52e07b65 (diff-547f5794a63e9f138c33b20de8649b7eR20-R31)

Not sure why that was originally the case, but we've made the decision that ApplicationExceptions shouldn't be logged by default as they should occur semi-regularly in a healthy application (mostly as an expression of complex logical validation that triggers them based on bad user input): https://github.com/octobercms/october/pull/4569#issuecomment-550172508

Fixes octobercms/october#5253.

2020-08-28 13:57:12 -06:00

CombineAssets.php

Switch to October Rain assetic

2020-02-27 20:07:42 +11:00

ComposerManager.php

Code quality clean up (#4449 )

2019-07-18 08:50:37 -06:00

ErrorHandler.php

Avoid logging SystemExceptions twice

2020-08-28 13:57:12 -06:00

ImageResizer.php

Remove unnecessary $sourceDisk & $sourcePath variables.