2020-10-15 19:40:33 +00:00
|
|
|
name: Coding Standards
|
|
|
|
|
|
|
|
on:
|
2021-02-24 19:34:41 +00:00
|
|
|
# JSHint was introduced in WordPress 3.8.
|
|
|
|
# PHPCS checking was introduced in WordPress 5.1.
|
2020-10-15 19:40:33 +00:00
|
|
|
push:
|
|
|
|
branches:
|
2021-03-02 15:26:03 +00:00
|
|
|
- trunk
|
2021-02-12 16:01:54 +00:00
|
|
|
- '3.[89]'
|
|
|
|
- '[4-9].[0-9]'
|
|
|
|
tags:
|
2022-07-20 18:39:16 +00:00
|
|
|
- '[0-9]+.[0-9]'
|
|
|
|
- '[0-9]+.[0-9].[0-9]+'
|
|
|
|
- '!3.7.[0-9]+'
|
2020-10-15 19:40:33 +00:00
|
|
|
pull_request:
|
2021-02-24 19:34:41 +00:00
|
|
|
branches:
|
2021-03-02 15:26:03 +00:00
|
|
|
- trunk
|
2021-02-24 19:34:41 +00:00
|
|
|
- '3.[89]'
|
|
|
|
- '[4-9].[0-9]'
|
2021-03-02 19:57:15 +00:00
|
|
|
paths:
|
|
|
|
# Any change to a PHP or JavaScript file should run checks.
|
|
|
|
- '**.js'
|
|
|
|
- '**.php'
|
|
|
|
# These files configure NPM. Changes could affect the outcome.
|
|
|
|
- 'package*.json'
|
|
|
|
# These files configure Composer. Changes could affect the outcome.
|
|
|
|
- 'composer.*'
|
|
|
|
# This file configures JSHint. Changes could affect the outcome.
|
|
|
|
- '.jshintrc'
|
|
|
|
# This file configures PHPCS. Changes could affect the outcome.
|
|
|
|
- 'phpcs.xml.dist'
|
|
|
|
# Changes to workflow files should always verify all workflows are successful.
|
|
|
|
- '.github/workflows/*.yml'
|
2021-03-26 13:06:43 +00:00
|
|
|
workflow_dispatch:
|
2020-10-15 19:40:33 +00:00
|
|
|
|
2021-05-19 17:36:54 +00:00
|
|
|
# Cancels all previous workflow runs for pull requests that have not completed.
|
|
|
|
concurrency:
|
|
|
|
# The concurrency group contains the workflow name and the branch name for pull requests
|
|
|
|
# or the commit hash for any other events.
|
|
|
|
group: ${{ github.workflow }}-${{ github.event_name == 'pull_request' && github.head_ref || github.sha }}
|
|
|
|
cancel-in-progress: true
|
|
|
|
|
2020-10-15 19:40:33 +00:00
|
|
|
jobs:
|
|
|
|
# Runs PHP coding standards checks.
|
|
|
|
#
|
|
|
|
# Violations are reported inline with annotations.
|
|
|
|
#
|
|
|
|
# Performs the following steps:
|
|
|
|
# - Checks out the repository.
|
|
|
|
# - Sets up PHP.
|
|
|
|
# - Logs debug information.
|
2021-11-16 14:17:26 +00:00
|
|
|
# - Configures caching for PHPCS scans.
|
2021-01-05 19:21:50 +00:00
|
|
|
# - Installs Composer dependencies (use cache if possible).
|
|
|
|
# - Make Composer packages available globally.
|
2020-10-15 19:40:33 +00:00
|
|
|
# - Logs PHP_CodeSniffer debug information.
|
|
|
|
# - Runs PHPCS on the full codebase with warnings suppressed.
|
|
|
|
# - Runs PHPCS on the `tests` directory without warnings suppressed.
|
2021-07-06 18:36:46 +00:00
|
|
|
# - Ensures version-controlled files are not modified or deleted.
|
2020-10-15 19:40:33 +00:00
|
|
|
phpcs:
|
|
|
|
name: PHP coding standards
|
|
|
|
runs-on: ubuntu-latest
|
2021-11-23 17:40:00 +00:00
|
|
|
timeout-minutes: 20
|
2020-12-09 20:05:01 +00:00
|
|
|
if: ${{ github.repository == 'WordPress/wordpress-develop' || github.event_name == 'pull_request' }}
|
|
|
|
|
2020-10-15 19:40:33 +00:00
|
|
|
steps:
|
|
|
|
- name: Checkout repository
|
2022-06-27 18:57:00 +00:00
|
|
|
uses: actions/checkout@2541b1294d2704b0964813337f33b291d3f8596b # v3.0.2
|
2020-10-15 19:40:33 +00:00
|
|
|
|
|
|
|
- name: Set up PHP
|
2022-08-24 16:30:31 +00:00
|
|
|
uses: shivammathur/setup-php@e04e1d97f0c0481c6e1ba40f8a538454fe5d7709 # v2.21.2
|
2020-10-15 19:40:33 +00:00
|
|
|
with:
|
|
|
|
php-version: '7.4'
|
|
|
|
coverage: none
|
|
|
|
tools: composer, cs2pr
|
|
|
|
|
|
|
|
- name: Log debug information
|
|
|
|
run: |
|
|
|
|
php --version
|
|
|
|
composer --version
|
|
|
|
|
2021-11-16 14:17:26 +00:00
|
|
|
# This date is used to ensure that the PHPCS cache is cleared at least once every week.
|
|
|
|
# http://man7.org/linux/man-pages/man1/date.1.html
|
|
|
|
- name: "Get last Monday's date"
|
|
|
|
id: get-date
|
|
|
|
run: echo "::set-output name=date::$(/bin/date -u --date='last Mon' "+%F")"
|
|
|
|
|
|
|
|
- name: Cache PHPCS scan cache
|
2022-08-24 16:30:31 +00:00
|
|
|
uses: actions/cache@fd5de65bc895cf536527842281bea11763fefd77 # v3.0.8
|
2021-11-16 14:17:26 +00:00
|
|
|
with:
|
|
|
|
path: .cache/phpcs.json
|
2021-11-19 19:21:36 +00:00
|
|
|
key: ${{ runner.os }}-date-${{ steps.get-date.outputs.date }}-phpcs-cache-${{ hashFiles('**/composer.json', 'phpcs.xml.dist') }}
|
2021-11-16 14:17:26 +00:00
|
|
|
|
2020-10-15 19:40:33 +00:00
|
|
|
- name: Install Composer dependencies
|
2022-04-08 18:37:20 +00:00
|
|
|
uses: ramsey/composer-install@f680dac46551dffb2234a240d65ae806c2999dd6 # v2.1.0
|
2021-01-05 19:21:50 +00:00
|
|
|
with:
|
2022-09-26 19:15:05 +00:00
|
|
|
composer-options: "--no-progress --no-ansi"
|
2021-01-05 19:21:50 +00:00
|
|
|
|
|
|
|
- name: Make Composer packages available globally
|
|
|
|
run: echo "${PWD}/vendor/bin" >> $GITHUB_PATH
|
2020-10-15 19:40:33 +00:00
|
|
|
|
|
|
|
- name: Log PHPCS debug information
|
|
|
|
run: phpcs -i
|
|
|
|
|
|
|
|
- name: Run PHPCS on all Core files
|
2020-10-16 17:12:16 +00:00
|
|
|
run: phpcs -q -n --report=checkstyle | cs2pr
|
2020-10-15 19:40:33 +00:00
|
|
|
|
|
|
|
- name: Check test suite files for warnings
|
2020-10-16 17:12:16 +00:00
|
|
|
run: phpcs tests -q --report=checkstyle | cs2pr
|
2020-10-15 19:40:33 +00:00
|
|
|
|
2021-07-06 18:36:46 +00:00
|
|
|
- name: Ensure version-controlled files are not modified during the tests
|
|
|
|
run: git diff --exit-code
|
|
|
|
|
2020-10-15 19:40:33 +00:00
|
|
|
# Runs the JavaScript coding standards checks.
|
|
|
|
#
|
2021-02-09 14:15:50 +00:00
|
|
|
# JSHint violations are not currently reported inline with annotations.
|
|
|
|
#
|
2020-10-15 19:40:33 +00:00
|
|
|
# Performs the following steps:
|
|
|
|
# - Checks out the repository.
|
2022-06-30 15:07:49 +00:00
|
|
|
# - Logs debug information about the GitHub Action runner.
|
|
|
|
# - Installs NodeJS.
|
2020-10-15 19:40:33 +00:00
|
|
|
# - Logs updated debug information.
|
2022-06-30 15:07:49 +00:00
|
|
|
# _ Installs NPM dependencies.
|
2020-10-15 19:40:33 +00:00
|
|
|
# - Run the WordPress JSHint checks.
|
2021-07-06 18:36:46 +00:00
|
|
|
# - Ensures version-controlled files are not modified or deleted.
|
2020-10-15 19:40:33 +00:00
|
|
|
jshint:
|
|
|
|
name: JavaScript coding standards
|
|
|
|
runs-on: ubuntu-latest
|
2021-11-23 17:40:00 +00:00
|
|
|
timeout-minutes: 20
|
2020-12-09 20:05:01 +00:00
|
|
|
if: ${{ github.repository == 'WordPress/wordpress-develop' || github.event_name == 'pull_request' }}
|
2020-10-20 13:52:28 +00:00
|
|
|
env:
|
|
|
|
PUPPETEER_SKIP_CHROMIUM_DOWNLOAD: ${{ true }}
|
2020-12-09 20:05:01 +00:00
|
|
|
|
2020-10-15 19:40:33 +00:00
|
|
|
steps:
|
|
|
|
- name: Checkout repository
|
2022-06-27 18:57:00 +00:00
|
|
|
uses: actions/checkout@2541b1294d2704b0964813337f33b291d3f8596b # v3.0.2
|
2020-10-15 19:40:33 +00:00
|
|
|
|
|
|
|
- name: Log debug information
|
|
|
|
run: |
|
|
|
|
npm --version
|
|
|
|
node --version
|
|
|
|
git --version
|
|
|
|
svn --version
|
|
|
|
|
|
|
|
- name: Install NodeJS
|
2022-08-24 16:30:31 +00:00
|
|
|
uses: actions/setup-node@2fddd8803e2f5c9604345a0b591c3020ee971a93 # v3.4.1
|
2020-10-15 19:40:33 +00:00
|
|
|
with:
|
2022-04-08 18:37:20 +00:00
|
|
|
node-version-file: '.nvmrc'
|
2021-07-06 13:12:13 +00:00
|
|
|
cache: npm
|
2020-10-15 19:40:33 +00:00
|
|
|
|
|
|
|
- name: Log debug information
|
|
|
|
run: |
|
|
|
|
npm --version
|
|
|
|
node --version
|
|
|
|
|
|
|
|
- name: Install Dependencies
|
2021-02-26 22:47:33 +00:00
|
|
|
run: npm ci
|
2020-10-15 19:40:33 +00:00
|
|
|
|
|
|
|
- name: Run JSHint
|
|
|
|
run: npm run grunt jshint
|
2021-07-06 18:36:46 +00:00
|
|
|
|
|
|
|
- name: Ensure version-controlled files are not modified or deleted
|
|
|
|
run: git diff --exit-code
|
2021-10-20 14:40:47 +00:00
|
|
|
|
|
|
|
slack-notifications:
|
|
|
|
name: Slack Notifications
|
2021-11-10 20:58:15 +00:00
|
|
|
uses: WordPress/wordpress-develop/.github/workflows/slack-notifications.yml@trunk
|
2021-10-20 14:40:47 +00:00
|
|
|
needs: [ phpcs, jshint ]
|
2021-10-25 20:26:45 +00:00
|
|
|
if: ${{ github.repository == 'WordPress/wordpress-develop' && github.event_name != 'pull_request' && always() }}
|
2021-11-03 14:54:20 +00:00
|
|
|
with:
|
|
|
|
calling_status: ${{ needs.phpcs.result == 'success' && needs.jshint.result == 'success' && 'success' || ( needs.phpcs.result == 'cancelled' || needs.jshint.result == 'cancelled' ) && 'cancelled' || 'failure' }}
|
2021-10-20 19:51:00 +00:00
|
|
|
secrets:
|
2021-10-20 19:25:12 +00:00
|
|
|
SLACK_GHA_SUCCESS_WEBHOOK: ${{ secrets.SLACK_GHA_SUCCESS_WEBHOOK }}
|
|
|
|
SLACK_GHA_CANCELLED_WEBHOOK: ${{ secrets.SLACK_GHA_CANCELLED_WEBHOOK }}
|
|
|
|
SLACK_GHA_FIXED_WEBHOOK: ${{ secrets.SLACK_GHA_FIXED_WEBHOOK }}
|
|
|
|
SLACK_GHA_FAILURE_WEBHOOK: ${{ secrets.SLACK_GHA_FAILURE_WEBHOOK }}
|
2022-08-26 19:19:11 +00:00
|
|
|
|
|
|
|
failed-workflow:
|
|
|
|
name: Failed workflow tasks
|
|
|
|
runs-on: ubuntu-latest
|
|
|
|
needs: [ phpcs, jshint, slack-notifications ]
|
|
|
|
if: |
|
|
|
|
always() &&
|
|
|
|
github.repository == 'WordPress/wordpress-develop' &&
|
|
|
|
github.event_name != 'pull_request' &&
|
2022-08-31 14:29:22 +00:00
|
|
|
github.run_attempt < 2 &&
|
2022-08-26 19:19:11 +00:00
|
|
|
(
|
|
|
|
needs.phpcs.result == 'cancelled' || needs.phpcs.result == 'failure' ||
|
|
|
|
needs.jshint.result == 'cancelled' || needs.jshint.result == 'failure'
|
|
|
|
)
|
|
|
|
|
|
|
|
steps:
|
|
|
|
- name: Dispatch workflow run
|
|
|
|
uses: actions/github-script@c713e510dbd7d213d92d41b7a7805a986f4c5c66 # v6.2.0
|
|
|
|
with:
|
|
|
|
script: |
|
|
|
|
github.rest.actions.createWorkflowDispatch({
|
|
|
|
owner: context.repo.owner,
|
|
|
|
repo: context.repo.repo,
|
|
|
|
workflow_id: 'failed-workflow.yml',
|
|
|
|
ref: '${{ github.ref_name }}',
|
|
|
|
inputs: {
|
|
|
|
run_id: '${{ github.run_id }}'
|
|
|
|
}
|
|
|
|
});
|