mirror_php/wordpress
1
0
Fork 0
mirror of git://develop.git.wordpress.org/ synced 2025-04-04 20:23:27 +02:00
Code Issues Actions 10 Packages Projects Releases Wiki Activity

Template: Fix "undefined index: 00" when archive month query is empty in wp_title().

Browse Source 
When `m` query_tag has a valid year, i.e. `?m=2021`, and there are posts for that year, `substr()` returns a `false` on PHP 5.6 and an empty string on PHP 7.0+. Passing either of those values to `$wp_locale->get_month()` results in a PHP notice on PHP 5.6 to PHP 7.4 and a PHP Warning on PHP 8.0+.

Why? The `$month` lookup table has zeroized keys from '01' to '12'. A empty value is passed to `zeroise()` returns `'00'` which is directly passed as a key in the month property. That key does not exist.

While `$wp_locale->get_month()` would benefit from guarding/validation, this fix ensures a falsey value is not passed as a month.

Tests are added including a test that fails with this fix not applied.

Follow-up to [801], [35294], [35624].

Props antpb, audrasjb, costdev, davidmosterd, drewapicture, herregroen, hellofromTonya, michelwppi, sergeybiryukov.
Fixes #31521.

git-svn-id: https://develop.svn.wordpress.org/trunk@52136 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Tonya Mork 2021-11-11 16:27:44 +00:00
parent d2ddc42e6d
commit 06dc5e170f
2 changed files with 66 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/wp-includes/general-template.php
View File

@ -1376,9 +1376,11 @@ function wp_title( $sep = '»', $display = true, $seplocation = '' ) {
// If there's a month.
if ( is_archive() && ! empty( $m ) ) {
$my_year = substr( $m, 0, 4 );
$my_month = $wp_locale->get_month( substr( $m, 4, 2 ) );
$my_month = substr( $m, 4, 2 );
$my_day = (int) substr( $m, 6, 2 );
$title = $my_year . ( $my_month ? $t_sep . $my_month : '' ) . ( $my_day ? $t_sep . $my_day : '' );
$title = $my_year .
( $my_month ? $t_sep . $wp_locale->get_month( $my_month ) : '' ) .
( $my_day ? $t_sep . $my_day : '' );
}
// If there's a year.

62
tests/phpunit/tests/general/wpTitle.php Normal file
View File

@ -0,0 +1,62 @@
<?php
/**
* @group general
* @group template
* @covers ::wp_title
*/
class Tests_General_WpTitle extends WP_UnitTestCase {
/**
* @ticket 31521
*
* @dataProvider data_wp_title_archive
*/
public function test_wp_title_archive( $query, $expected ) {
self::factory()->post->create(
array(
'post_status' => 'publish',
'post_title' => 'Test Post',
'post_type' => 'post',
'post_date' => '2021-11-01 18:52:17',
)
);
$this->go_to( '?m=' . $query );
$this->assertSame( $expected, wp_title( '&raquo;', false ) );
}
/**
* Data provider.
*
* @return array
*/
public function data_wp_title_archive() {
return array(
'year with posts' => array(
'query' => '2021',
'expected' => ' &raquo; 2021',
),
'year without posts' => array(
'query' => '1910',
'expected' => ' &raquo; Page not found',
),
'year and month with posts' => array(
'query' => '202111',
'expected' => ' &raquo; 2021 &raquo; November',
),
'year and month without posts' => array(
'query' => '202101',
'expected' => ' &raquo; Page not found',
),
'year, month, day with posts' => array(
'query' => '20211101',
'expected' => ' &raquo; 2021 &raquo; November &raquo; 1',
),
'year, month, day without posts' => array(
'query' => '20210101',
'expected' => ' &raquo; Page not found',
),
);
}
}