From 0ee45ae9178dc21de46607a119eceb56dcc8f334 Mon Sep 17 00:00:00 2001
From: Sergey Biryukov <sergeybiryukov@git.wordpress.org>
Date: Wed, 26 Jan 2022 13:09:52 +0000
Subject: [PATCH] Upgrade/Install: Make sure the "Show hidden updates" button
is visible and works as expected.
The [https://api.jquery.com/toggle-event/ .toggle( handler, handler )] method signature was deprecated in jQuery 1.8 and removed in jQuery 1.9.
This commit updates the click handler function to work with jQuery 1.9+.
Follow-up to [9441], [9543], [42785], [48323].
Props malinevskiy, SergeyBiryukov.
Fixes #54886.
git-svn-id: https://develop.svn.wordpress.org/trunk@52644 602fd350-edb4-49c9-b593-d223f7449a82
---
src/wp-admin/update-core.php | 24 ++++++++++++++++--------
1 file changed, 16 insertions(+), 8 deletions(-)
diff --git a/src/wp-admin/update-core.php b/src/wp-admin/update-core.php
index ea9df4eeba..783fc601ce 100644
--- a/src/wp-admin/update-core.php
+++ b/src/wp-admin/update-core.php
@@ -206,18 +206,26 @@ function dismissed_updates() {
'available' => false,
)
);
- if ( $dismissed ) {
+ if ( $dismissed ) {
$show_text = esc_js( __( 'Show hidden updates' ) );
$hide_text = esc_js( __( 'Hide hidden updates' ) );
?>
- <script type="text/javascript">
- jQuery(function( $ ) {
- $( 'dismissed-updates' ).show();
- $( '#show-dismissed' ).toggle( function() { $( this ).text( '<?php echo $hide_text; ?>' ).attr( 'aria-expanded', 'true' ); }, function() { $( this ).text( '<?php echo $show_text; ?>' ).attr( 'aria-expanded', 'false' ); } );
- $( '#show-dismissed' ).click( function() { $( '#dismissed-updates' ).toggle( 'fast' ); } );
- });
- </script>
+ <script type="text/javascript">
+ jQuery( function( $ ) {
+ $( '#show-dismissed' ).on( 'click', function() {
+ var isExpanded = ( 'true' === $( this ).attr( 'aria-expanded' ) );
+
+ if ( isExpanded ) {
+ $( this ).text( '<?php echo $show_text; ?>' ).attr( 'aria-expanded', 'false' );
+ } else {
+ $( this ).text( '<?php echo $hide_text; ?>' ).attr( 'aria-expanded', 'true' );
+ }
+
+ $( '#dismissed-updates' ).toggle( 'fast' );
+ });
+ });
+ </script>
<?php
echo '<p class="hide-if-no-js"><button type="button" class="button" id="show-dismissed" aria-expanded="false">' . __( 'Show hidden updates' ) . '</button></p>';
echo '<ul id="dismissed-updates" class="core-updates dismissed">';