mirror_php/wordpress
1
0
Fork 0
mirror of git://develop.git.wordpress.org/ synced 2025-04-08 14:13:27 +02:00
Code Issues Actions 18 Packages Projects Releases Wiki Activity

Code Modernization: Use file_get_contents() in wp_get_image_mime().

Browse Source 
`file_get_contents()` is faster than `fread()`, because the PHP core can decide how to best read the remaining file; it could decide to issue just one `read()` call or `mmap()` the file first.

Per the PHP manual, `file_get_contents()` or `stream_get_contents()` is the preferred way to read the contents of a file into a string. It will use memory mapping techniques if supported by the OS to enhance performance.

Reference: [https://www.php.net/manual/en/function.file-get-contents.php PHP Manual: file_get_contents()].

Follow-up to [50810], [52696], [52698].

Props maxkellermann.
See #55069.

git-svn-id: https://develop.svn.wordpress.org/trunk@52701 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Sergey Biryukov 2022-02-11 15:48:44 +00:00
parent 4689322d44
commit 13485e11c5
1 changed files with 1 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/wp-includes/functions.php
View File

@ -3265,12 +3265,8 @@ function wp_get_image_mime( $file ) {
return $mime;
}
$handle = fopen( $file, 'rb' );
if ( false === $handle ) {
return false;
}
$magic = file_get_contents( $file, false, null, 0, 12 );
$magic = fread( $handle, 12 );
if ( false === $magic ) {
return false;
}
@ -3289,8 +3285,6 @@ function wp_get_image_mime( $file ) {
) {
$mime = 'image/webp';
}
fclose( $handle );
} catch ( Exception $e ) {
$mime = false;
}