mirror_php/wordpress
1
0
Fork 0
mirror of git://develop.git.wordpress.org/ synced 2025-03-22 21:09:51 +01:00
Code Issues Actions 9 Packages Projects Releases Wiki Activity

Query: Ensure preview links show autosave content to logged in users.

Browse Source 
Ensures that the global post object is populated with the autosave post when a preview link is used for a published post. This allows post authors to preview the changes to a post prior to publication.

This modifies `WP_Query::the_post()` to only call `get_post()` if `WP_Query::$posts` does not contain `WP_Post` objects. Other data types (`stdClass` or numeric) indicates partial data was queried, a `WP_Post` object indicates the full data was queried and populated.

Props peterwilsoncc, mamaduka, wildworks, audrasjb.
Fixes #56992.


git-svn-id: https://develop.svn.wordpress.org/trunk@59937 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Peter Wilson 2025-03-05 22:12:06 +00:00
parent e641b06f0f
commit 1cd5c21c43
2 changed files with 145 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/wp-includes/class-wp-query.php
View File

@ -3779,15 +3779,16 @@ class WP_Query {
$post = $this->next_post();
// Get the post ID.
if ( is_object( $post ) ) {
$global_post_id = $post->ID;
} else {
$global_post_id = $post;
// Ensure a full post object is available.
if ( $post instanceof stdClass ) {
// stdClass indicates that a partial post object was queried.
$post = get_post( $post->ID );
} elseif ( is_numeric( $post ) ) {
// Numeric indicates that only post IDs were queried.
$post = get_post( $post );
}
// Ensure the global $post is the full post object.
$post = get_post( $global_post_id );
// Set up the global post object for the loop.
$this->setup_postdata( $post );
}

137
tests/phpunit/tests/query/thePost.php
View File

@ -191,4 +191,141 @@ class Tests_Query_ThePost extends WP_UnitTestCase {
'post ids and parent' => array( 'id=>parent', 4 ),
);
}
/**
* Ensure draft content is shown for post previews and permalinks for logged in users.
*
* @ticket 56992
*/
public function test_post_preview_links_draft_posts() {
$user_id = self::$author_ids[0];
wp_set_current_user( $user_id );
$draft_post = $this->factory()->post->create(
array(
'post_status' => 'draft',
'post_author' => $user_id,
'post_content' => 'ticket 56992',
)
);
// Ensure the global post is populated with the draft content for the preview link.
$this->go_to( get_preview_post_link( $draft_post ) );
if ( have_posts() ) {
the_post();
}
$this->assertSame( 'ticket 56992', get_the_content(), 'Preview link should show draft content to logged in user' );
// Ensure the global post is populated with the draft content for the permalink.
$this->go_to( get_permalink( $draft_post ) );
if ( have_posts() ) {
the_post();
}
$this->assertSame( 'ticket 56992', get_the_content(), 'Permalink should show draft content to logged in user' );
// Ensure the global post is not populated with the draft content for the preview link when logged out.
wp_set_current_user( 0 );
$this->go_to( get_preview_post_link( $draft_post ) );
if ( have_posts() ) {
the_post();
}
$this->assertEmpty( get_the_content(), 'Preview link should not show draft content to logged out users' );
// Ensure the global post is not populated with the draft content for the permalink when logged out.
$this->go_to( get_permalink( $draft_post ) );
if ( have_posts() ) {
the_post();
}
$this->assertEmpty( get_the_content(), 'Permalink should not show draft content to logged out users' );
}
/**
* Ensure autosave content is shown for post previews.
*
* @ticket 56992
*/
public function test_post_preview_links_autosaves() {
$user_id = self::$author_ids[0];
wp_set_current_user( $user_id );
$published_post = $this->factory()->post->create(
array(
'post_status' => 'publish',
'post_author' => $user_id,
'post_content' => 'ticket 56992',
)
);
// Create an autosave for the published post.
$autosave = get_post( $published_post, ARRAY_A );
$autosave['post_ID'] = $published_post;
$autosave['post_content'] = 'ticket 56992 edited';
wp_create_post_autosave( $autosave );
// Set up the preview $_GET parameters.
$nonce = wp_create_nonce( 'post_preview_' . $published_post );
$query_args['preview_id'] = $published_post;
$query_args['preview_nonce'] = $nonce;
$post_preview_link = get_preview_post_link( $published_post, $query_args );
/*
* Set up the GET parameters for the preview link.
*
* _show_post_preview() checks the $_GET super global for preview
* and nonce parameters. It needs to run prior to the global query
* being set up in WP_Query (via $this->go_to()), so the preview
* parameters are created here to ensure _show_post_preview()
* runs correctly.
*/
$_GET['preview_id'] = $published_post;
$_GET['preview_nonce'] = $nonce;
_show_post_preview();
// Ensure the global post is populated with the autosave content for the preview link.
$this->go_to( $post_preview_link );
if ( have_posts() ) {
the_post();
}
$this->assertSame( 'ticket 56992 edited', get_the_content(), 'Preview link should show autosave content to logged in user' );
// Ensure the global post is populated with the published content for the permalink.
$this->go_to( get_permalink( $published_post ) );
if ( have_posts() ) {
the_post();
}
$this->assertSame( 'ticket 56992', get_the_content(), 'Permalink should show published content to logged in user' );
wp_set_current_user( 0 );
// New user, new nonce; set up the preview $_GET parameters.
$nonce = wp_create_nonce( 'post_preview_' . $published_post );
$query_args['preview_id'] = $published_post;
$query_args['preview_nonce'] = $nonce;
$post_preview_link = get_preview_post_link( $published_post, $query_args );
/*
* Set up the GET parameters for the preview link.
*
* _show_post_preview() checks the $_GET super global for preview
* and nonce parameters. It needs to run prior to the global query
* being set up in WP_Query (via $this->go_to()), so the preview
* parameters are created here to ensure _show_post_preview()
* runs correctly.
*/
$_GET['preview_id'] = $published_post;
$_GET['preview_nonce'] = $nonce;
_show_post_preview();
// Ensure the global post is not populated with the draft content for the preview link when logged out.
$this->go_to( $post_preview_link );
if ( have_posts() ) {
the_post();
}
$this->assertSame( 'ticket 56992', get_the_content(), 'Preview link should show published content to logged out users' );
// Ensure the global post is not populated with the draft content for the permalink when logged out.
$this->go_to( get_permalink( $published_post ) );
if ( have_posts() ) {
the_post();
}
$this->assertSame( 'ticket 56992', get_the_content(), 'Permalink should show published content to logged out users' );
}
}