From 1d77cfa438d2b3318f8a4ddbca199e4e46b28e27 Mon Sep 17 00:00:00 2001 From: Jb Audras Date: Fri, 21 Feb 2025 14:50:17 +0000 Subject: [PATCH] Site Health: Improve fonts directory check. This changeset enhances the filesystem checks in the Site Health debug data by addressing the following: - Existence Check: Before checking if the fonts directory is writable, it first verifies whether the directory exists. - Improved Messaging: If the fonts directory does not exist, the debug output now reflects this scenario as "Does not exist". If the directory exists, it shows whether it is writable or not. Props zodiac1978, samiamnot, sainathpoojary, abcd95, ankitkumarshah, im3dabasia1. Fixes #62633. git-svn-id: https://develop.svn.wordpress.org/trunk@59853 602fd350-edb4-49c9-b593-d223f7449a82 --- src/wp-admin/includes/class-wp-debug-data.php | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/src/wp-admin/includes/class-wp-debug-data.php b/src/wp-admin/includes/class-wp-debug-data.php index f227c9fdd2..8f959d6c49 100644 --- a/src/wp-admin/includes/class-wp-debug-data.php +++ b/src/wp-admin/includes/class-wp-debug-data.php @@ -1646,12 +1646,13 @@ class WP_Debug_Data { */ private static function get_wp_filesystem(): array { $upload_dir = wp_upload_dir(); + $fonts_dir_exists = file_exists( wp_get_font_dir()['basedir'] ); $is_writable_abspath = wp_is_writable( ABSPATH ); $is_writable_wp_content_dir = wp_is_writable( WP_CONTENT_DIR ); $is_writable_upload_dir = wp_is_writable( $upload_dir['basedir'] ); $is_writable_wp_plugin_dir = wp_is_writable( WP_PLUGIN_DIR ); $is_writable_template_directory = wp_is_writable( get_theme_root( get_template() ) ); - $is_writable_fonts_dir = wp_is_writable( wp_get_font_dir()['basedir'] ); + $is_writable_fonts_dir = $fonts_dir_exists ? wp_is_writable( wp_get_font_dir()['basedir'] ) : false; $fields = array( 'wordpress' => array( @@ -1681,8 +1682,12 @@ class WP_Debug_Data { ), 'fonts' => array( 'label' => __( 'The fonts directory' ), - 'value' => ( $is_writable_fonts_dir ? __( 'Writable' ) : __( 'Not writable' ) ), - 'debug' => ( $is_writable_fonts_dir ? 'writable' : 'not writable' ), + 'value' => $fonts_dir_exists + ? ( $is_writable_fonts_dir ? __( 'Writable' ) : __( 'Not writable' ) ) + : __( 'Does not exist' ), + 'debug' => $fonts_dir_exists + ? ( $is_writable_fonts_dir ? 'writable' : 'not writable' ) + : 'does not exist', ), );