From 388b59319e42657ca156c15c3838dabf9ffc2a13 Mon Sep 17 00:00:00 2001
From: Jb Audras <audrasjb@git.wordpress.org>
Date: Thu, 25 Nov 2021 08:34:01 +0000
Subject: [PATCH] Media: Replace some array keys with their numeric equivalent.
This change replaces `['0']` with `[0]` which brings better consistency, readability and performance.
Props chintan1896, adamsilverstein, costdev.
Fixes #53540.
git-svn-id: https://develop.svn.wordpress.org/trunk@52245 602fd350-edb4-49c9-b593-d223f7449a82
---
src/wp-admin/includes/media.php | 12 ++++++------
src/wp-includes/media.php | 2 +-
2 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/src/wp-admin/includes/media.php b/src/wp-admin/includes/media.php
index 186769dd36..816107a3ff 100644
--- a/src/wp-admin/includes/media.php
+++ b/src/wp-admin/includes/media.php
@@ -3740,17 +3740,17 @@ function wp_get_media_creation_timestamp( $metadata ) {
case 'matroska':
case 'webm':
- if ( isset( $metadata['matroska']['comments']['creation_time']['0'] ) ) {
- $creation_date = strtotime( $metadata['matroska']['comments']['creation_time']['0'] );
- } elseif ( isset( $metadata['matroska']['info']['0']['DateUTC_unix'] ) ) {
- $creation_date = (int) $metadata['matroska']['info']['0']['DateUTC_unix'];
+ if ( isset( $metadata['matroska']['comments']['creation_time'][0] ) ) {
+ $creation_date = strtotime( $metadata['matroska']['comments']['creation_time'][0] );
+ } elseif ( isset( $metadata['matroska']['info'][0]['DateUTC_unix'] ) ) {
+ $creation_date = (int) $metadata['matroska']['info'][0]['DateUTC_unix'];
}
break;
case 'quicktime':
case 'mp4':
- if ( isset( $metadata['quicktime']['moov']['subatoms']['0']['creation_time_unix'] ) ) {
- $creation_date = (int) $metadata['quicktime']['moov']['subatoms']['0']['creation_time_unix'];
+ if ( isset( $metadata['quicktime']['moov']['subatoms'][0]['creation_time_unix'] ) ) {
+ $creation_date = (int) $metadata['quicktime']['moov']['subatoms'][0]['creation_time_unix'];
}
break;
}
diff --git a/src/wp-includes/media.php b/src/wp-includes/media.php
index 01543b9dcd..0450b4512f 100644
--- a/src/wp-includes/media.php
+++ b/src/wp-includes/media.php
@@ -1129,7 +1129,7 @@ function wp_get_attachment_image( $attachment_id, $size = 'thumbnail', $icon = f
*/
function wp_get_attachment_image_url( $attachment_id, $size = 'thumbnail', $icon = false ) {
$image = wp_get_attachment_image_src( $attachment_id, $size, $icon );
- return isset( $image['0'] ) ? $image['0'] : false;
+ return isset( $image[0] ) ? $image[0] : false;
}
/**