mirror_php/wordpress
1
0
Fork 0
mirror of git://develop.git.wordpress.org/ synced 2025-03-24 05:49:49 +01:00
Code Issues Actions 11 Packages Projects Releases Wiki Activity

Media: disable "Insert Gallery" button during uploads.

Browse Source 
Ensure that the button to insert a gallery is disabled until all image uploads have completed on the Edit Gallery screen.  Prevents an issue where users could insert a gallery with some images missing.

Props: adamsilverstein, gonom9, rishavdutta.
Fixes: #39824.



git-svn-id: https://develop.svn.wordpress.org/trunk@60031 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Adam Silverstein 2025-03-17 17:46:51 +00:00
parent 6f9d8e6c69
commit 4a12552742
2 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/js/media/views/frame/post.js
View File

@ -580,7 +580,7 @@ Post = Select.extend(/** @lends wp.media.view.MediaFrame.Post.prototype */{
style: 'primary',
text: editing ? l10n.updateGallery : l10n.insertGallery,
priority: 80,
requires: { library: true },
requires: { library: true, uploadingComplete: true },
/**
* @fires wp.media.controller.State#update

6
src/js/media/views/toolbar.js
View File

@ -143,7 +143,8 @@ Toolbar = View.extend(/** @lends wp.media.view.Toolbar.prototype */{
}
var requires = button.options.requires,
disabled = false;
disabled = false,
modelsUploading = ! _.isEmpty( library.findWhere( { 'uploading': true } ) );
// Prevent insertion of attachments if any of them are still uploading.
if ( selection && selection.models ) {
@ -151,6 +152,9 @@ Toolbar = View.extend(/** @lends wp.media.view.Toolbar.prototype */{
return attachment.get('uploading') === true;
});
}
if ( requires.uploadingComplete && modelsUploading ) {
disabled = true;
}
if ( requires.selection && selection && ! selection.length ) {
disabled = true;