From 50fb4086b7afbfa012c5d1f2eeff79b1bae3b00e Mon Sep 17 00:00:00 2001 From: Aaron Jorbin Date: Wed, 12 Mar 2025 20:14:21 +0000 Subject: [PATCH] Menus: Fix JS Warning when removing menu items. Move the updateParentDropdown and updateOrderDropdown methods to be called on the jQuery menu object instead of on the menus translations object. Reviewed by jorbin. Merges [59950] to the 6.7 branch. Props joedolson, abcd95, audrasjb. Fixes #63059. git-svn-id: https://develop.svn.wordpress.org/branches/6.7@59977 602fd350-edb4-49c9-b593-d223f7449a82 --- src/js/_enqueues/lib/nav-menu.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/js/_enqueues/lib/nav-menu.js b/src/js/_enqueues/lib/nav-menu.js index 398f54ecfd..e3d6afd23f 100644 --- a/src/js/_enqueues/lib/nav-menu.js +++ b/src/js/_enqueues/lib/nav-menu.js @@ -1221,8 +1221,8 @@ deletionSpeech = menus.itemsDeleted.replace( '%s', itemsPendingDeletion ); wp.a11y.speak( deletionSpeech, 'polite' ); that.disableBulkSelection(); - menus.updateParentDropdown(); - menus.updateOrderDropdown(); + $( '#menu-to-edit' ).updateParentDropdown(); + $( '#menu-to-edit' ).updateOrderDropdown(); } }); }, @@ -1762,8 +1762,8 @@ } api.refreshAdvancedAccessibility(); wp.a11y.speak( menus.itemRemoved ); - menus.updateParentDropdown(); - menus.updateOrderDropdown(); + $( '#menu-to-edit' ).updateParentDropdown(); + $( '#menu-to-edit' ).updateOrderDropdown(); }); },