mirror_php/wordpress
1
0
Fork 0
mirror of git://develop.git.wordpress.org/ synced 2025-03-24 13:59:48 +01:00
Code Issues Actions 11 Packages Projects Releases Wiki Activity

Widgets: Improve unit tests for RSS Widget.

Browse Source 
Prevent unit tests from making HTTP requests to wordpress.org. Specify URLs as https rather than http.

Follow up to [51107].

Props hellofromTonya.
Fixes #53278.


git-svn-id: https://develop.svn.wordpress.org/trunk@51136 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Peter Wilson 2021-06-09 23:50:14 +00:00
parent 81e84e12e8
commit 5bee644258
1 changed files with 119 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

119
tests/phpunit/tests/widgets/wpWidgetRss.php Normal file
View File

@ -0,0 +1,119 @@
<?php
/**
* Unit tests covering WP_Widget_RSS functionality.
*
* @package WordPress
* @subpackage widgets
*/
/**
* Test wp-includes/widgets/class-wp-widget-rss.php
*
* @group widgets
*/
class Test_Widgets_wpWidgetRss extends WP_UnitTestCase {
/**
* @ticket 53278
* @covers WP_Widget_RSS::widget
* @dataProvider data_url_unhappy_path
*
* @param mixed $url When null, unsets 'url' arg, else, sets to given value.
*/
public function test_url_unhappy_path( $url ) {
$widget = new WP_Widget_RSS();
$args = array(
'before_title' => '<h2>',
'after_title' => "</h2>\n",
'before_widget' => '<section id="widget_rss-5" class="widget widget_rss">',
'after_widget' => "</section>\n",
);
$instance = array(
'title' => 'Foo',
'url' => $url,
);
if ( is_null( $url ) ) {
unset( $instance['ur'] );
}
$this->expectOutputString( '' );
$widget->widget( $args, $instance );
}
public function data_url_unhappy_path() {
return array(
'when unset' => array(
'url' => null,
),
'when empty string' => array(
'url' => '',
),
'when boolean false' => array(
'url' => false,
),
);
}
/**
* @ticket 53278
* @covers WP_Widget_RSS::widget
* @dataProvider data_url_happy_path
*
* @param mixed $url URL argument.
* @param string $expected Expected output.
*/
public function test_url_happy_path( $url, $expected ) {
add_filter( 'pre_http_request', array( $this, 'mocked_rss_response' ) );
$widget = new WP_Widget_RSS();
$args = array(
'before_title' => '<h2>',
'after_title' => "</h2>\n",
'before_widget' => '<section id="widget_rss-5" class="widget widget_rss">',
'after_widget' => "</section>\n",
);
$instance = array(
'title' => 'Foo',
'url' => $url,
);
if ( is_null( $url ) ) {
unset( $instance['ur'] );
}
ob_start();
$widget->widget( $args, $instance );
$actual = ob_get_clean();
$this->assertContains( $expected, $actual );
}
public function data_url_happy_path() {
return array(
'when url is given' => array(
'url' => 'https://wordpress.org/news/feed/',
'<section id="widget_rss-5" class="widget widget_rss"><h2><a class="rsswidget" href="https://wordpress.org/news/feed/">',
),
);
}
public function mocked_rss_response() {
$single_value_headers = array(
'content-type' => 'application/rss+xml; charset=UTF-8',
'link' => '<https://wordpress.org/news/wp-json/>; rel="https://api.w.org/"',
);
return array(
'headers' => new Requests_Utility_CaseInsensitiveDictionary( $single_value_headers ),
'body' => file_get_contents( DIR_TESTDATA . '/feed/wordpress-org-news.xml' ),
'response' => array(
'code' => 200,
'message' => 'OK',
),
'cookies' => array(),
'filename' => null,
);
}
}