mirror of
git://develop.git.wordpress.org/
synced 2025-04-05 04:33:18 +02:00
Code Modernization: Pass correct default value to http_build_query()
in get_core_checksums()
and wp_version_check()
.
The `get_core_checksums()` and `wp_version_check()` functions call the PHP native `http_build_query()` function, the second parameter of which is the ''optional'' `$numeric_prefix` parameter which expects a non-nullable `string`. A parameter being optional, however, does not automatically make it nullable. As of PHP 8.1, passing `null` to a non-nullable PHP native function will generate a deprecation notice. In this case, this function call yielded a `http_build_query(): Passing null to parameter #2 ($numeric_prefix) of type string is deprecated` notice. Changing the `null` to an empty string fixes this without a backward compatibility break. References: * [https://www.php.net/manual/en/function.http-build-query.php PHP Manual: http_build_query()] * [https://wiki.php.net/rfc/deprecate_null_to_scalar_internal_arg PHP RFC: Deprecate passing null to non-nullable arguments of internal functions] Follow-up to [18697], [25540]. Props bjorsch, kraftbj, hellofromTonya, jrf. See #54229. git-svn-id: https://develop.svn.wordpress.org/trunk@52019 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
parent
18e9b9a135
commit
68b5fffc49
@ -120,7 +120,7 @@ function find_core_auto_update() {
|
||||
* @return array|false An array of checksums on success, false on failure.
|
||||
*/
|
||||
function get_core_checksums( $version, $locale ) {
|
||||
$http_url = 'http://api.wordpress.org/core/checksums/1.0/?' . http_build_query( compact( 'version', 'locale' ), null, '&' );
|
||||
$http_url = 'http://api.wordpress.org/core/checksums/1.0/?' . http_build_query( compact( 'version', 'locale' ), '', '&' );
|
||||
$url = $http_url;
|
||||
|
||||
$ssl = wp_http_supports( array( 'ssl' ) );
|
||||
|
@ -143,7 +143,7 @@ function wp_version_check( $extra_stats = array(), $force_check = false ) {
|
||||
$query['channel'] = WP_AUTO_UPDATE_CORE;
|
||||
}
|
||||
|
||||
$url = 'http://api.wordpress.org/core/version-check/1.7/?' . http_build_query( $query, null, '&' );
|
||||
$url = 'http://api.wordpress.org/core/version-check/1.7/?' . http_build_query( $query, '', '&' );
|
||||
$http_url = $url;
|
||||
$ssl = wp_http_supports( array( 'ssl' ) );
|
||||
|
||||
|
Loading…
x
Reference in New Issue
Block a user