mirror_php/wordpress
1
0
Fork 0
mirror of git://develop.git.wordpress.org/ synced 2025-03-20 20:09:53 +01:00
Code Issues Actions 16 Packages Projects Releases Wiki Activity

Coding Standards: Break the $path reference after a foreach loop in block_editor_rest_api_preload().

Browse Source 
When using a `foreach` loop with a value assigned by reference, the variable continues to point to the last array element even after the loop, so it is recommended to destroy it by `unset()` to avoid unexpected behavior later on.

See [https://www.php.net/manual/en/control-structures.foreach.php PHP Manual: foreach].

Follow-up to [52312], [52313].

Props TobiasBg.
See #54558.

git-svn-id: https://develop.svn.wordpress.org/trunk@52322 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Sergey Biryukov 2021-12-04 17:18:48 +00:00
parent 4eee8105c8
commit 76357a2936
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/wp-includes/block-editor.php
View File

@ -83,6 +83,7 @@ function get_block_categories( $post_or_block_editor_context ) {
* @param WP_Block_Editor_Context $block_editor_context The current block editor context.
*/
$block_categories = apply_filters( 'block_categories_all', $block_categories, $block_editor_context );
if ( ! empty( $block_editor_context->post ) ) {
$post = $block_editor_context->post;
@ -123,6 +124,7 @@ function get_allowed_block_types( $block_editor_context ) {
* @param WP_Block_Editor_Context $block_editor_context The current block editor context.
*/
$allowed_block_types = apply_filters( 'allowed_block_types_all', $allowed_block_types, $block_editor_context );
if ( ! empty( $block_editor_context->post ) ) {
$post = $block_editor_context->post;
@ -397,6 +399,7 @@ function get_block_editor_settings( array $custom_settings, $block_editor_contex
* @param WP_Block_Editor_Context $block_editor_context The current block editor context.
*/
$editor_settings = apply_filters( 'block_editor_settings_all', $editor_settings, $block_editor_context );
if ( ! empty( $block_editor_context->post ) ) {
$post = $block_editor_context->post;
@ -440,6 +443,7 @@ function block_editor_rest_api_preload( array $preload_paths, $block_editor_cont
* @param WP_Block_Editor_Context $block_editor_context The current block editor context.
*/
$preload_paths = apply_filters( 'block_editor_rest_api_preload_paths', $preload_paths, $block_editor_context );
if ( ! empty( $block_editor_context->post ) ) {
$selected_post = $block_editor_context->post;
@ -479,6 +483,8 @@ function block_editor_rest_api_preload( array $preload_paths, $block_editor_cont
}
}
unset( $path );
$preload_data = array_reduce(
$preload_paths,
'rest_preload_api_request',