mirror_php/wordpress
1
0
Fork 0
mirror of git://develop.git.wordpress.org/ synced 2025-02-25 00:52:55 +01:00
Code Issues Actions 10 Packages Projects Releases Wiki Activity

Revert change from true to false in multisite upload test

Browse Source 
This change was introduced in [34601]. 0 is a special snowflake. The code treats it as if it should fall back to the default, rather than respecting 0 as 0.  Essentially, 0 means 100.  WAT? This has been discussed previusly in https://core.trac.wordpress.org/ticket/19538#comment:10.  This test should return True right now, but the behavior should be discussed and in the future 0 may mean 0.

See #34037
Props jorbin, boonebgorges



git-svn-id: https://develop.svn.wordpress.org/trunk@34606 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Aaron Jorbin 2015-09-26 20:58:22 +00:00
parent ab7d1ae62d
commit 7894562b50
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
tests/phpunit/tests/multisite/site.php
View File

@ -1107,7 +1107,7 @@ class Tests_Multisite_Site extends WP_UnitTestCase {
function test_is_upload_space_available_upload_space_0() {
update_site_option( 'upload_space_check_disabled', false );
update_site_option( 'blog_upload_space', 0 );
$this->assertFalse( is_upload_space_available() );
$this->assertTrue( is_upload_space_available() );
}
function test_is_upload_space_available_upload_space_negative() {