mirror_php/wordpress
1
0
Fork 0
mirror of git://develop.git.wordpress.org/ synced 2025-04-05 04:33:18 +02:00
Code Issues Actions 10 Packages Projects Releases Wiki Activity

Docs: Add a @since tag for the pre_wp_setup_nav_menu_item filter.

Browse Source 
Includes moving the unit test next to the other `wp_setup_nav_menu_item()` tests and using the `MockAction` class to confirm that the filter runs.

Follow-up to [55867].

Props TobiasBg.
Fixes #56577.

git-svn-id: https://develop.svn.wordpress.org/trunk@55868 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Sergey Biryukov 2023-05-30 14:11:46 +00:00
parent 28eaeaed40
commit 7b97d8c74e
2 changed files with 29 additions and 30 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/wp-includes/nav-menu.php
View File

@ -822,10 +822,12 @@ function update_menu_item_cache( $menu_items ) {
function wp_setup_nav_menu_item( $menu_item ) {
/**
* Short-circuit the wp_setup_nav_menu_item() output.
* Filters whether to short-circuit the wp_setup_nav_menu_item() output.
*
* Returning a non-null value from the filter will short-circuit wp_setup_nav_menu_item(),
* and return that value.
* returning that value instead.
*
* @since 6.3.0
*
* @param object|null $modified_menu_item Modified menu item. Default null.
* @param object $menu_item The menu item to modify.

53
tests/phpunit/tests/post/nav-menu.php
View File

@ -591,6 +591,31 @@ class Tests_Post_Nav_Menu extends WP_UnitTestCase {
$this->assertTrue( ! _is_valid_nav_menu_item( $menu_item ) );
}
/**
* @ticket 56577
*/
public function test_wp_setup_nav_menu_item_short_circuit_filter() {
$post_id = self::factory()->post->create();
$menu_item_id = wp_update_nav_menu_item(
$this->menu_id,
0,
array(
'menu-item-type' => 'post_type',
'menu-item-object' => 'post',
'menu-item-object-id' => $post_id,
'menu-item-status' => 'publish',
)
);
$filter = new MockAction();
add_filter( 'pre_wp_setup_nav_menu_item', array( &$filter, 'filter' ) );
wp_setup_nav_menu_item( get_post( $menu_item_id ) );
$this->assertSame( 1, $filter->get_call_count() );
}
/**
* @ticket 35206
*/
@ -1344,32 +1369,4 @@ class Tests_Post_Nav_Menu extends WP_UnitTestCase {
$post = get_post( $menu_item_id );
$this->assertEqualsWithDelta( strtotime( gmdate( 'Y-m-d H:i:s' ) ), strtotime( $post->post_date ), 2, 'The dates should be equal' );
}
/**
* @ticket 56577
*/
public function test_nav_menu_item_short_circuit_filter() {
// Create a nav menu item.
$menu_item_args = array(
'menu-item-type' => 'custom',
'menu-item-title' => 'Wordpress.org',
'menu-item-url' => 'http://wordpress.org',
'menu-item-status' => 'publish',
);
$custom_item_id = wp_update_nav_menu_item( 0, 0, $menu_item_args );
$pre_setup_callback = function() {
return '--empty nav menu item--';
};
add_filter( 'pre_wp_setup_nav_menu_item', $pre_setup_callback );
// Confirm the short-circuit.
$custom_item = wp_setup_nav_menu_item( get_post( $custom_item_id ) );
$this->assertSame( '--empty nav menu item--', $custom_item );
remove_filter( 'pre_wp_setup_nav_menu_item', $pre_setup_callback );
}
}