From 7c6678f2c20a09edc10d10ab14665d26ebb01754 Mon Sep 17 00:00:00 2001 From: Joe Dolson Date: Thu, 30 Jan 2025 23:36:38 +0000 Subject: [PATCH] Administration: Fix undefined element JS error in pagination handler. Follow up to [59727]. Handle cases where the `#current-page-selector` is not present on the page to prevent a JS warning. Props tobiasbg, mamaduka, jorbin, joedolson. See #62534. git-svn-id: https://develop.svn.wordpress.org/trunk@59746 602fd350-edb4-49c9-b593-d223f7449a82 --- src/js/_enqueues/admin/common.js | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/src/js/_enqueues/admin/common.js b/src/js/_enqueues/admin/common.js index c7415d02c3..590796f4b2 100644 --- a/src/js/_enqueues/admin/common.js +++ b/src/js/_enqueues/admin/common.js @@ -1310,16 +1310,12 @@ $( function() { $document.trigger( 'wp-notice-added' ); }; - // Stores initial pagination value for comparison. - var initialPagedValue = document.querySelector( '#current-page-selector' ).value; - $( '.bulkactions' ).parents( 'form' ).on( 'submit', function( event ) { var form = this, - submitterName = event.originalEvent && event.originalEvent.submitter ? event.originalEvent.submitter.name : false; + submitterName = event.originalEvent && event.originalEvent.submitter ? event.originalEvent.submitter.name : false, + currentPageSelector = form.querySelector( '#current-page-selector' ); - var currentPagedValue = form.querySelector( '#current-page-selector' ).value; - - if ( initialPagedValue !== currentPagedValue ) { + if ( currentPageSelector && currentPageSelector.defaultValue !== currentPageSelector.value ) { return; // Pagination form submission. }