mirror_php/wordpress
1
0
Fork 0
mirror of git://develop.git.wordpress.org/ synced 2025-02-24 16:43:06 +01:00
Code Issues Actions 11 Packages Projects Releases Wiki Activity

Editor: Fix a PHP notice appearing when adding a new template part.

Browse Source 
This changeset fixes a PHP notice appearing when a template part is created in the site editor. It also adds a unit test case to cover 
`WP_REST_Templates_Controller::prepare_item_for_database`.

Props wildworks, dunhakdis, Rahmohn, oglekler, audrasjb, mukesh27, costdev, dunhakdis.
Fixes #57851.




git-svn-id: https://develop.svn.wordpress.org/trunk@56248 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Jb Audras 2023-07-17 14:20:42 +00:00
parent fb9814474e
commit 7df1b8366d
2 changed files with 41 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/wp-includes/rest-api/endpoints/class-wp-rest-templates-controller.php
View File

@ -596,7 +596,7 @@ class WP_REST_Templates_Controller extends WP_REST_Controller {
$changes->tax_input['wp_template_part_area'] = _filter_block_template_part_area( $request['area'] );
} elseif ( null !== $template && 'custom' !== $template->source && $template->area ) {
$changes->tax_input['wp_template_part_area'] = _filter_block_template_part_area( $template->area );
} elseif ( ! $template->area ) {
} elseif ( empty( $template->area ) ) {
$changes->tax_input['wp_template_part_area'] = WP_TEMPLATE_PART_AREA_UNCATEGORIZED;
}
}

40
tests/phpunit/tests/rest-api/wpRestTemplatesController.php
View File

@ -845,4 +845,44 @@ class Tests_REST_WpRestTemplatesController extends WP_Test_REST_Controller_Testc
$response = rest_get_server()->dispatch( $request );
$this->assertSame( 'index', $response->get_data()['slug'], 'Should fallback to `index.html` when ignore_empty is `true`.' );
}
/**
* @ticket 57851
*
* @covers WP_REST_Templates_Controller::prepare_item_for_database
*/
public function test_prepare_item_for_database() {
$endpoint = new WP_REST_Templates_Controller( 'wp_template_part' );
$prepare_item_for_database = new ReflectionMethod( $endpoint, 'prepare_item_for_database' );
$prepare_item_for_database->setAccessible( true );
$body_params = array(
'title' => 'Untitled Template Part',
'slug' => 'untitled-template-part',
'content' => '',
);
$request = new WP_REST_Request( 'POST', '/wp/v2/template-parts' );
$request->set_body_params( $body_params );
$prepared = $prepare_item_for_database->invoke( $endpoint, $request );
$this->assertInstanceOf( 'stdClass', $prepared, 'The item could not be prepared for the database.' );
$this->assertObjectHasAttribute( 'post_type', $prepared, 'The "post_type" was not included in the prepared template part.' );
$this->assertObjectHasAttribute( 'post_status', $prepared, 'The "post_status" was not included in the prepared template part.' );
$this->assertObjectHasAttribute( 'tax_input', $prepared, 'The "tax_input" was not included in the prepared template part.' );
$this->assertArrayHasKey( 'wp_theme', $prepared->tax_input, 'The "wp_theme" tax was not included in the prepared template part.' );
$this->assertArrayHasKey( 'wp_template_part_area', $prepared->tax_input, 'The "wp_template_part_area" tax was not included in the prepared template part.' );
$this->assertObjectHasAttribute( 'post_content', $prepared, 'The "post_content" was not included in the prepared template part.' );
$this->assertObjectHasAttribute( 'post_title', $prepared, 'The "post_title" was not included in the prepared template part.' );
$this->assertSame( 'wp_template_part', $prepared->post_type, 'The "post_type" in the prepared template part should be "wp_template_part".' );
$this->assertSame( 'publish', $prepared->post_status, 'The post status in the prepared template part should be "publish".' );
$this->assertSame( WP_TEMPLATE_PART_AREA_UNCATEGORIZED, $prepared->tax_input['wp_template_part_area'], 'The area in the prepared template part should be uncategorized.' );
$this->assertSame( 'Untitled Template Part', $prepared->post_title, 'The title was not correct in the prepared template part.' );
$this->assertEmpty( $prepared->post_content, 'The content was not correct in the prepared template part.' );
}
}