mirror_php/wordpress
1
0
Fork 0
mirror of git://develop.git.wordpress.org/ synced 2025-04-04 20:23:27 +02:00
Code Issues Actions 10 Packages Projects Releases Wiki Activity

Site Health: Improve vertical alignment of icons in test result descriptions.

Browse Source 
This change removes redundant CSS properties for different health check statuses in favor of utilizing the `.dashicons` class already in Core to define them more consistently. This also fixes the vertical alignment issues.

Props chetan200891, Clorith, desrosj.
Fixes #46940.

git-svn-id: https://develop.svn.wordpress.org/trunk@45309 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Jonathan Desrosiers 2019-05-15 14:24:15 +00:00
parent f10ea0702a
commit 851cb8b8f2
2 changed files with 2 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/wp-admin/css/site-health.css
View File

@ -153,32 +153,23 @@
.health-check-body .pass::before,
.health-check-body .good::before {
content: "\f147";
display: inline-block;
color: #46b450;
font-family: dashicons;
vertical-align: top;
}
.health-check-body .warning::before {
content: "\f460";
display: inline-block;
color: #ffb900;
font-family: dashicons;
}
.health-check-body .info::before {
content: "\f348";
display: inline-block;
color: #00a0d2;
font-family: dashicons;
}
.health-check-body .fail::before,
.health-check-body .error::before {
content: "\f335";
display: inline-block;
color: #dc3232;
font-family: dashicons;
}
.site-health-copy-buttons {

4
src/wp-admin/includes/class-wp-site-health.php
View File

@ -889,7 +889,7 @@ class WP_Site_Health {
$result['status'] = 'recommended';
}
$failures[ $library ] = "<span class='$class'><span class='screen-reader-text'>$screen_reader</span></span> $message";
$failures[ $library ] = "<span class='dashicons $class'><span class='screen-reader-text'>$screen_reader</span></span> $message";
}
}
@ -1487,7 +1487,7 @@ class WP_Site_Health {
}
$output .= sprintf(
'<li><span class="%s"><span class="screen-reader-text">%s</span></span> %s</li>',
'<li><span class="dashicons %s"><span class="screen-reader-text">%s</span></span> %s</li>',
esc_attr( $test->severity ),
$severity_string,
$test->description