mirror_php/wordpress
1
0
Fork 0
mirror of git://develop.git.wordpress.org/ synced 2025-04-11 15:42:03 +02:00
Code Issues Actions 11 Packages Projects Releases Wiki Activity

REST API: Remove duplicates in the widget types endpoint.

Browse Source 
Props noisysocks, spacedmonkey, imath, isabel_brison.
Fixes #53305.


git-svn-id: https://develop.svn.wordpress.org/trunk@51049 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Timothy Jacobs 2021-05-31 20:56:22 +00:00
parent 712ca22293
commit 8edfb80800
2 changed files with 47 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/wp-includes/rest-api/endpoints/class-wp-rest-widget-types-controller.php
View File

@ -225,7 +225,7 @@ class WP_REST_Widget_Types_Controller extends WP_REST_Controller {
}
$widget['classname'] = ltrim( $classname, '_' );
$widgets[] = $widget;
$widgets[ $widget['id'] ] = $widget;
}
return $widgets;

46
tests/phpunit/tests/rest-api/rest-widget-types-controller.php
View File

@ -61,6 +61,22 @@ class WP_Test_REST_Widget_Types_Controller extends WP_Test_REST_Controller_Testc
self::delete_user( self::$subscriber_id );
}
private function setup_widget( $id_base, $number, $settings ) {
global $wp_widget_factory;
$option_name = "widget_$id_base";
update_option(
$option_name,
array(
$number => $settings,
)
);
$widget_object = $wp_widget_factory->get_widget_object( $id_base );
$widget_object->_set( $number );
$widget_object->_register_one( $number );
}
/**
* @ticket 41683
*/
@ -106,7 +122,37 @@ class WP_Test_REST_Widget_Types_Controller extends WP_Test_REST_Controller_Testc
$widget_type = $endpoint->get_widget( $item['name'] );
$this->check_widget_type_object( $widget_type, $item, $item['_links'] );
}
}
/**
* @ticket 53305
*/
public function test_get_items_removes_duplicates() {
wp_set_current_user( self::$admin_id );
$this->setup_widget(
'text',
1,
array(
'text' => 'Custom text test',
)
);
$this->setup_widget(
'text',
2,
array(
'text' => 'Custom text test',
)
);
$request = new WP_REST_Request( 'GET', '/wp/v2/widget-types' );
$response = rest_get_server()->dispatch( $request );
$data = $response->get_data();
$text_widgets = array_filter(
$data,
function( $widget ) {
return 'text' === $widget['id'];
}
);
$this->assertCount( 1, $text_widgets );
}
/**