mirror_php/wordpress
1
0
Fork 0
mirror of git://develop.git.wordpress.org/ synced 2025-01-29 10:38:22 +01:00
Code Issues Actions 23 Packages Projects Releases Wiki Activity

REST API: Pass correct number of arguments to the comment_text filter.

Browse Source 
This ensures that `WP_REST_Comments_Controller::prepare_item_for_response()` passes three arguments to the `comment_text` filter, for consistency with all the other instances in core.

Follow-up to [15957], [16357], [25555], [38832], [40664].

Props sjregan, SergeyBiryukov.
Fixes #58238.

git-svn-id: https://develop.svn.wordpress.org/trunk@57176 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Sergey Biryukov 2023-12-09 22:11:45 +00:00
parent 1325c63a0a
commit 9bfb30462a
2 changed files with 16 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/wp-includes/rest-api/endpoints/class-wp-rest-comments-controller.php
View File

@ -1091,7 +1091,7 @@ class WP_REST_Comments_Controller extends WP_REST_Controller {
if ( in_array( 'content', $fields, true ) ) {
$data['content'] = array(
/** This filter is documented in wp-includes/comment-template.php */
'rendered' => apply_filters( 'comment_text', $comment->comment_content, $comment ),
'rendered' => apply_filters( 'comment_text', $comment->comment_content, $comment, array() ),
'raw' => $comment->comment_content,
);
}

15
tests/phpunit/tests/rest-api/rest-comments-controller.php
View File

@ -966,6 +966,21 @@ class WP_Test_REST_Comments_Controller extends WP_Test_REST_Controller_Testcase
);
}
/**
* @ticket 58238
*/
public function test_prepare_item_comment_text_filter() {
$filter = new MockAction();
add_filter( 'comment_text', array( $filter, 'filter' ), 10, 3 );
$request = new WP_REST_Request( 'GET', sprintf( '/wp/v2/comments/%d', self::$approved_id ) );
$response = rest_get_server()->dispatch( $request );
$this->assertSame( 1, $filter->get_call_count() );
$this->assertCount( 3, $filter->get_args()[0] );
}
public function test_get_comment_author_avatar_urls() {
$request = new WP_REST_Request( 'GET', sprintf( '/wp/v2/comments/%d', self::$approved_id ) );