From 9d9854594b7561c6fe11fdbba93166cecc5b79f5 Mon Sep 17 00:00:00 2001 From: Gary Pendergast Date: Mon, 12 Nov 2018 23:37:31 +0000 Subject: [PATCH] Scripts: Fix a PHP error in admin-ajax calls. When making an ajax request, `wp_enqueue_registered_block_scripts_and_styles()` checked if `is_admin()` was true before accessing `$current_screen`, rather than checking if `$current_screen` was defined. This is usually fine, execept for in ajax requests. Props ocean90, foreverpinetree, pento. See #45203. git-svn-id: https://develop.svn.wordpress.org/branches/5.0@43893 602fd350-edb4-49c9-b593-d223f7449a82 --- src/wp-includes/script-loader.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/wp-includes/script-loader.php b/src/wp-includes/script-loader.php index 1e814a324f..b31c0b1700 100644 --- a/src/wp-includes/script-loader.php +++ b/src/wp-includes/script-loader.php @@ -2252,7 +2252,7 @@ function script_concat_settings() { function wp_common_block_scripts_and_styles() { global $current_screen; - if ( is_admin() && ! $current_screen->is_block_editor() ) { + if ( ( $current_screen instanceof WP_Screen ) && ! $current_screen->is_block_editor() ) { return; } @@ -2286,7 +2286,7 @@ function wp_common_block_scripts_and_styles() { function wp_enqueue_registered_block_scripts_and_styles() { global $current_screen; - $is_editor = ( is_admin() && $current_screen->is_block_editor() ); + $is_editor = ( ( $current_screen instanceof WP_Screen ) && $current_screen->is_block_editor() ); $block_registry = WP_Block_Type_Registry::get_instance(); foreach ( $block_registry->get_all_registered() as $block_name => $block_type ) {