mirror_php/wordpress
1
0
Fork 0
mirror of git://develop.git.wordpress.org/ synced 2025-04-04 20:23:27 +02:00
Code Issues Actions 10 Packages Projects Releases Wiki Activity

Tests: Use more specific assertions in a few tests.

Browse Source 
Follow-up to [121/tests], [915/tests], [34903], [36307], [43548], [44154], [52286], [57337].

See #60705.

git-svn-id: https://develop.svn.wordpress.org/trunk@58235 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Sergey Biryukov 2024-05-29 12:20:56 +00:00
parent 4b91a597b7
commit a6f91faa79
6 changed files with 11 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
tests/phpunit/tests/block-template-utils.php
View File

@ -379,7 +379,7 @@ class Tests_Block_Template_Utils extends WP_UnitTestCase {
public function test_wp_generate_block_templates_export_file() {
$filename = wp_generate_block_templates_export_file();
$this->assertFileExists( $filename, 'zip file is created at the specified path' );
$this->assertTrue( filesize( $filename ) > 0, 'zip file is larger than 0 bytes' );
$this->assertGreaterThan( 0, filesize( $filename ), 'zip file is larger than 0 bytes' );
// Open ZIP file and make sure the directories exist.
$zip = new ZipArchive();

2
tests/phpunit/tests/formatting/utf8UriEncode.php
View File

@ -22,7 +22,7 @@ class Tests_Formatting_Utf8UriEncode extends WP_UnitTestCase {
*/
public function test_output_is_not_longer_than_optional_length_argument( $utf8, $unused_for_this_test ) {
$max_length = 30;
$this->assertTrue( strlen( utf8_uri_encode( $utf8, $max_length ) ) <= $max_length );
$this->assertLessThanOrEqual( $max_length, strlen( utf8_uri_encode( $utf8, $max_length ) ) );
}
public function data() {

2
tests/phpunit/tests/l10n/wpTranslationsConvert.php
View File

@ -501,7 +501,7 @@ class WP_Translation_Controller_Convert_Tests extends WP_UnitTestCase {
$this->assertInstanceOf( WP_Translation_File::class, $destination );
$this->assertNull( $destination->error() );
$this->assertTrue( filesize( $destination_file ) > 0 );
$this->assertGreaterThan( 0, filesize( $destination_file ) );
$destination_read = WP_Translation_File::create( $destination_file, $destination_format );

2
tests/phpunit/tests/multisite/site.php
View File

@ -1213,7 +1213,7 @@ if ( is_multisite() ) :
if ( isset( $expected_data[ $key ] ) ) {
$this->assertEquals( $expected_data[ $key ], $value );
} elseif ( 'last_updated' === $key ) {
$this->assertTrue( $old_site->last_updated <= $value );
$this->assertLessThanOrEqual( $value, $old_site->last_updated );
} else {
$this->assertSame( $old_site->$key, $value );
}

10
tests/phpunit/tests/oembed/controller.php
View File

@ -342,7 +342,7 @@ class Test_oEmbed_Controller extends WP_UnitTestCase {
$this->assertSame( get_author_posts_url( $user->ID, $user->user_nicename ), $data['author_url'] );
$this->assertSame( $post->post_title, $data['title'] );
$this->assertSame( 'rich', $data['type'] );
$this->assertTrue( $data['width'] <= $request['maxwidth'] );
$this->assertLessThanOrEqual( $request['maxwidth'], $data['width'] );
}
/**
@ -385,7 +385,7 @@ class Test_oEmbed_Controller extends WP_UnitTestCase {
$this->assertSame( home_url(), $data['author_url'] );
$this->assertSame( $post->post_title, $data['title'] );
$this->assertSame( 'rich', $data['type'] );
$this->assertTrue( $data['width'] <= $request['maxwidth'] );
$this->assertLessThanOrEqual( $request['maxwidth'], $data['width'] );
update_option( 'show_on_front', 'posts' );
}
@ -430,7 +430,7 @@ class Test_oEmbed_Controller extends WP_UnitTestCase {
$this->assertSame( get_author_posts_url( $user->ID, $user->user_nicename ), $data['author_url'] );
$this->assertSame( $post->post_title, $data['title'] );
$this->assertSame( 'rich', $data['type'] );
$this->assertTrue( $data['width'] <= $request['maxwidth'] );
$this->assertLessThanOrEqual( $request['maxwidth'], $data['width'] );
}
/**
@ -716,7 +716,7 @@ class Test_oEmbed_Controller extends WP_UnitTestCase {
$this->assertSame( get_author_posts_url( $user->ID, $user->user_nicename ), $data['author_url'] );
$this->assertSame( $post->post_title, $data['title'] );
$this->assertSame( 'rich', $data['type'] );
$this->assertTrue( $data['width'] <= $request['maxwidth'] );
$this->assertLessThanOrEqual( $request['maxwidth'], $data['width'] );
}
/**
@ -765,7 +765,7 @@ class Test_oEmbed_Controller extends WP_UnitTestCase {
$this->assertSame( home_url(), $data['author_url'] );
$this->assertSame( $post->post_title, $data['title'] );
$this->assertSame( 'rich', $data['type'] );
$this->assertTrue( $data['width'] <= $request['maxwidth'] );
$this->assertLessThanOrEqual( $request['maxwidth'], $data['width'] );
update_option( 'show_on_front', 'posts' );
}

4
tests/phpunit/tests/oembed/getResponseData.php
View File

@ -248,7 +248,7 @@ class Tests_oEmbed_Response_Data extends WP_UnitTestCase {
$this->assertArrayHasKey( 'thumbnail_url', $data );
$this->assertArrayHasKey( 'thumbnail_width', $data );
$this->assertArrayHasKey( 'thumbnail_height', $data );
$this->assertTrue( 400 >= $data['thumbnail_width'] );
$this->assertLessThanOrEqual( 400, $data['thumbnail_width'] );
}
public function test_get_oembed_response_data_for_attachment() {
@ -267,6 +267,6 @@ class Tests_oEmbed_Response_Data extends WP_UnitTestCase {
$this->assertArrayHasKey( 'thumbnail_url', $data );
$this->assertArrayHasKey( 'thumbnail_width', $data );
$this->assertArrayHasKey( 'thumbnail_height', $data );
$this->assertTrue( 400 >= $data['thumbnail_width'] );
$this->assertLessThanOrEqual( 400, $data['thumbnail_width'] );
}
}