From b2f9e67757a5d2501bb8ba03526071e56a536363 Mon Sep 17 00:00:00 2001 From: Jonathan Desrosiers Date: Wed, 22 Jun 2022 00:18:42 +0000 Subject: [PATCH] Build/Test Tools: Return an error when uploading a test coverage report fails. `true` is now passed to the `fail_ci_if_error` input when the `codecov/codecov-action` action is used. When uploading a code coverage report is unsuccessful, the action will now fail and return an error. This will help avoid situations like #56022 where the report was suddenly failing to upload even though the workflow itself appeared to be successful. See #55652. git-svn-id: https://develop.svn.wordpress.org/trunk@53554 602fd350-edb4-49c9-b593-d223f7449a82 --- .github/workflows/test-coverage.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/test-coverage.yml b/.github/workflows/test-coverage.yml index c8c0ea29ab..29479e460d 100644 --- a/.github/workflows/test-coverage.yml +++ b/.github/workflows/test-coverage.yml @@ -164,6 +164,7 @@ jobs: with: file: wp-code-coverage-single-clover-${{ github.sha }}.xml flags: single,php + fail_ci_if_error: true - name: Run tests as a multisite install if: ${{ matrix.multisite }} @@ -178,6 +179,7 @@ jobs: with: file: wp-code-coverage-multisite-clover-${{ github.sha }}.xml flags: multisite,php + fail_ci_if_error: true slack-notifications: name: Slack Notifications