mirror_php/wordpress
1
0
Fork 0
mirror of git://develop.git.wordpress.org/ synced 2025-04-04 04:02:36 +02:00
Code Issues Actions 19 Packages Projects Releases Wiki Activity

Script Loader: Prevent normalizing HTML IDs in _wp_normalize_relative_css_links().

Browse Source 
This change fixes an issue where `_wp_normalize_relative_css_links()` was not only matching urls, but also HTML IDs.

Follow-up to [52036].

Props mahype, costdev, audrasjb, SergeyBiryukov.
Fixes #54922.


git-svn-id: https://develop.svn.wordpress.org/trunk@52695 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Jb Audras 2022-02-08 23:39:32 +00:00
parent eefd34a7fa
commit b8f97013df
2 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/wp-includes/script-loader.php
View File

@ -2770,6 +2770,11 @@ function _wp_normalize_relative_css_links( $css, $stylesheet_url ) {
continue;
}
// Skip if the URL is an HTML ID.
if ( str_starts_with( $src_result, '#' ) ) {
continue;
}
// Build the absolute URL.
$absolute_url = dirname( $stylesheet_url ) . '/' . $src_result;
$absolute_url = str_replace( '/./', '/', $absolute_url );

5
tests/phpunit/tests/dependencies/styles.php
View File

@ -195,6 +195,7 @@ class Tests_Dependencies_Styles extends WP_UnitTestCase {
* @dataProvider data_normalize_relative_css_links
*
* @ticket 54243
* @ticket 54922
*
* @covers ::_wp_normalize_relative_css_links
*
@ -231,6 +232,10 @@ class Tests_Dependencies_Styles extends WP_UnitTestCase {
'css' => 'p {background-image: url(\'http://foo.com/image2.png\');}',
'expected' => 'p {background-image: url(\'http://foo.com/image2.png\');}',
),
'An HTML ID' => array(
'css' => 'clip-path: url(#image1);',
'expected' => 'clip-path: url(#image1);',
),
);
}