mirror_php/wordpress
1
0
Fork 0
mirror of git://develop.git.wordpress.org/ synced 2025-04-05 20:53:07 +02:00
Code Issues Actions 11 Packages Projects Releases Wiki Activity

Themes: Make block themes support HTML5 by default.

Browse Source 
For block themes, [52369] added HTML5 support for `'comment-list'`, `'comment-form'`, `'style'`, and `'script'`. However, when sites upgrade to 5.9 with non-block content such as a gallery and caption, the markup was not HTML5. 

This commit adds full HTML5 theme feature support for block themes. Non-block content such as a `[gallery]` and `[caption]` shortcodes will natively be in HMTL5 markup without block themes needing to specifically add `add_theme_support( 'html5, .. )` to the theme. 

Follow-up to [24417], [27302], [34261], [52369], [52383], [52386].

Props @joyously, costdev, hellofromTonya, audrasjb, Mamaduka, ocean90.
Fixes #54731. See #54597.

git-svn-id: https://develop.svn.wordpress.org/trunk@52439 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Tonya Mork 2022-01-04 18:38:52 +00:00
parent e1e9bd5657
commit ba7d3a52b1
2 changed files with 38 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/wp-includes/theme.php
View File

@ -4181,7 +4181,12 @@ function _add_default_theme_supports() {
add_theme_support( 'post-thumbnails' );
add_theme_support( 'responsive-embeds' );
add_theme_support( 'editor-styles' );
add_theme_support( 'html5', array( 'comment-form', 'comment-list', 'style', 'script' ) );
/*
* Makes block themes support HTML5 by default for the comment block and search form
* (which use default template functions) and `[caption]` and `[gallery]` shortcodes.
* Other blocks contain their own HTML5 markup.
*/
add_theme_support( 'html5', array( 'comment-form', 'comment-list', 'search-form', 'gallery', 'caption', 'style', 'script' ) );
add_theme_support( 'automatic-feed-links' );
add_filter( 'should_load_separate_core_block_assets', '__return_true' );

32
tests/phpunit/tests/theme.php
View File

@ -706,6 +706,8 @@ class Tests_Theme extends WP_UnitTestCase {
* Tests that block themes support a feature by default.
*
* @ticket 54597
* @ticket 54731
*
* @dataProvider data_block_theme_has_default_support
*
* @covers ::_add_default_theme_supports
@ -763,6 +765,36 @@ class Tests_Theme extends WP_UnitTestCase {
'feature' => 'editor-styles',
),
),
'html5: comment-list' => array(
'support' => array(
'feature' => 'html5',
'sub_feature' => 'comment-list',
),
),
'html5: comment-form' => array(
'support' => array(
'feature' => 'html5',
'sub_feature' => 'comment-form',
),
),
'html5: search-form' => array(
'support' => array(
'feature' => 'html5',
'sub_feature' => 'search-form',
),
),
'html5: gallery' => array(
'support' => array(
'feature' => 'html5',
'sub_feature' => 'gallery',
),
),
'html5: caption' => array(
'support' => array(
'feature' => 'html5',
'sub_feature' => 'caption',
),
),
'html5: style' => array(
'support' => array(
'feature' => 'html5',