mirror of
git://develop.git.wordpress.org/
synced 2025-04-26 23:22:25 +02:00
Build/Test Tools: Resolve access failure to continue sending commit performance data to Code Vitals dashboard.
This originally broke in [58165] and unfortunately went unnoticed for a while because the failing request to send the data did not cause the GitHub workflows to fail. This changeset resolves the underlying access problem, which was happening because reusable GitHub workflows do not automatically receive secrets from the calling workflow. More concretely, the relevant `CODEVITALS_PROJECT_TOKEN` was not being explicitly passed to the reusable workflow. The changeset also includes a change so that in the future a failing request would cause the workflow to fail, which ensures a similar problem further down the road wouldn't go unnoticed. Props joemcgill, flixos90, swissspidy, mukesh27, sergeybiryukov Fixes #62153. See #61213. git-svn-id: https://develop.svn.wordpress.org/trunk@59170 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
parent
b59d154705
commit
c3b9b39b8d
2
.github/workflows/performance.yml
vendored
2
.github/workflows/performance.yml
vendored
@ -43,6 +43,8 @@ jobs:
|
||||
memcached: [ true, false ]
|
||||
with:
|
||||
memcached: ${{ matrix.memcached }}
|
||||
secrets:
|
||||
CODEVITALS_PROJECT_TOKEN: ${{ secrets.CODEVITALS_PROJECT_TOKEN }}
|
||||
|
||||
slack-notifications:
|
||||
name: Slack Notifications
|
||||
|
4
.github/workflows/reusable-performance.yml
vendored
4
.github/workflows/reusable-performance.yml
vendored
@ -26,6 +26,10 @@ on:
|
||||
required: false
|
||||
type: 'boolean'
|
||||
default: false
|
||||
secrets:
|
||||
CODEVITALS_PROJECT_TOKEN:
|
||||
description: 'The authorization token for https://www.codevitals.run/project/wordpress.'
|
||||
required: true
|
||||
|
||||
env:
|
||||
PUPPETEER_SKIP_DOWNLOAD: ${{ true }}
|
||||
|
@ -108,6 +108,7 @@ const req = https.request( options, ( res ) => {
|
||||
|
||||
req.on( 'error', ( error ) => {
|
||||
console.error( error );
|
||||
process.exit( 1 );
|
||||
} );
|
||||
|
||||
req.write( data );
|
||||
|
Loading…
x
Reference in New Issue
Block a user