mirror_php/wordpress
1
0
Fork 0
mirror of git://develop.git.wordpress.org/ synced 2025-01-18 05:18:42 +01:00
Code Issues Actions 10 Packages Projects Releases Wiki Activity

Comments: Use wp_cache_get_multiple in WP_Comment_Query.

Browse Source 
In the `fill_descendants` method in `WP_Comment_Query`, there is a loop the calls `wp_cache_get` to get `child comments. Instead of getting one key at a time, use `wp_cache_get_multiple` and get all keys at once.

Props spacedmonkey, tillkruess, mukesh27.
Fixes #57803.

git-svn-id: https://develop.svn.wordpress.org/trunk@55607 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Jonny Harris 2023-03-29 10:18:34 +00:00
parent 69667798f4
commit c46a30eb1f
1 changed files with 13 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
src/wp-includes/class-wp-comment-query.php
View File

@ -1030,13 +1030,19 @@ class WP_Comment_Query {
$child_ids = array(); $child_ids = array();
$uncached_parent_ids = array(); $uncached_parent_ids = array();
$_parent_ids = $levels[ $level ]; $_parent_ids = $levels[ $level ];
foreach ( $_parent_ids as $parent_id ) { if ( $_parent_ids ) {
$cache_key = "get_comment_child_ids:$parent_id:$key:$last_changed"; $cache_keys = array();
$parent_child_ids = wp_cache_get( $cache_key, 'comment-queries' ); foreach ( $_parent_ids as $parent_id ) {
if ( false !== $parent_child_ids ) { $cache_keys[ $parent_id ] = "get_comment_child_ids:$parent_id:$key:$last_changed";
$child_ids = array_merge( $child_ids, $parent_child_ids ); }
} else { $cache_data = wp_cache_get_multiple( array_values( $cache_keys ), 'comment-queries' );
$uncached_parent_ids[] = $parent_id; foreach ( $_parent_ids as $parent_id ) {
$parent_child_ids = $cache_data[ $cache_keys[ $parent_id ] ];
if ( false !== $parent_child_ids ) {
$child_ids = array_merge( $child_ids, $parent_child_ids );
} else {
$uncached_parent_ids[] = $parent_id;
}
} }
} }