From ca539afd545ec5df803babecdbe2cb332ac766e2 Mon Sep 17 00:00:00 2001 From: Sergey Biryukov Date: Tue, 15 Jun 2021 10:23:57 +0000 Subject: [PATCH] Docs: Document the usage of `$wp_embed` global in `WP_oEmbed_Controller::get_proxy_item()`. Follow-up to [48135]. Fixes #52628. git-svn-id: https://develop.svn.wordpress.org/trunk@51151 602fd350-edb4-49c9-b593-d223f7449a82 --- src/wp-includes/class-wp-oembed-controller.php | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/wp-includes/class-wp-oembed-controller.php b/src/wp-includes/class-wp-oembed-controller.php index 3e93a8e87a..046c5c0a3a 100644 --- a/src/wp-includes/class-wp-oembed-controller.php +++ b/src/wp-includes/class-wp-oembed-controller.php @@ -159,10 +159,14 @@ final class WP_oEmbed_Controller { * @since 4.8.0 * * @see WP_oEmbed::get_html() + * @global WP_Embed $wp_embed + * * @param WP_REST_Request $request Full data about the request. * @return object|WP_Error oEmbed response data or WP_Error on failure. */ public function get_proxy_item( $request ) { + global $wp_embed; + $args = $request->get_params(); // Serve oEmbed data from cache if set. @@ -195,8 +199,6 @@ final class WP_oEmbed_Controller { if ( false === $data ) { // Try using a classic embed, instead. - global $wp_embed; - /* @var WP_Embed $wp_embed */ $html = $wp_embed->get_embed_handler_html( $args, $url );