Tests: Use more appropriate assertions in a few tests.

Follow-up to [34804], [41376], [50959], [51124].

See #52625.

git-svn-id: https://develop.svn.wordpress.org/trunk@51196 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Sergey Biryukov 2021-06-22 04:34:29 +00:00
parent 302d50e62c
commit d920d56923
4 changed files with 10 additions and 6 deletions

View File

@ -380,6 +380,6 @@ class Test_WP_Customize_Custom_CSS_Setting extends WP_UnitTestCase {
// Check for markup.
$unclosed_comment = $basic_css . '</style>';
$result = $this->setting->validate( $unclosed_comment );
$this->assertTrue( array_key_exists( 'illegal_markup', $result->errors ) );
$this->assertArrayHasKey( 'illegal_markup', $result->errors );
}
}

View File

@ -623,6 +623,7 @@ class Tests_Post_Revisions extends WP_UnitTestCase {
return $generic;
}
);
$this->assertSame( $generic, wp_revisions_to_keep( $post ) );
$expected = $generic + 1;
@ -633,6 +634,7 @@ class Tests_Post_Revisions extends WP_UnitTestCase {
return $expected;
}
);
$this->assertSame( $expected, wp_revisions_to_keep( $post ) );
}
@ -642,12 +644,14 @@ class Tests_Post_Revisions extends WP_UnitTestCase {
* @ticket 30009
*/
public function test_wp_save_post_revision_error() {
$post = self::factory()->post->create_and_get(
$post = self::factory()->post->create_and_get(
array(
'ID' => PHP_INT_MAX,
)
);
$revision = _wp_put_post_revision( $post );
$this->assertTrue( is_wp_error( $revision ) );
$this->assertWPError( $revision );
}
}

View File

@ -157,8 +157,8 @@ class Tests_Theme_wpThemeJsonResolver extends WP_UnitTestCase {
switch_theme( 'fse' );
$fse = WP_Theme_JSON_Resolver::theme_has_support();
$this->assertSame( false, $default );
$this->assertSame( true, $fse );
$this->assertFalse( $default );
$this->assertTrue( $fse );
}
}

View File

@ -1296,7 +1296,7 @@ class Tests_User_Query extends WP_UnitTestCase {
remove_action( 'pre_get_users', array( $this, 'filter_pre_get_users_args' ) );
foreach ( $query_vars as $query_var ) {
$this->assertTrue( array_key_exists( $query_var, $q->query_vars ), "$query_var does not exist." );
$this->assertArrayHasKey( $query_var, $q->query_vars, "$query_var does not exist." );
}
}