mirror_php/wordpress
1
0
Fork 0
mirror of git://develop.git.wordpress.org/ synced 2025-04-05 04:33:18 +02:00
Code Issues Actions 10 Packages Projects Releases Wiki Activity

External Libraries: Append .1 to react/react-dom versions.

Browse Source 
In 6.7, [58775] changed the way react and react-dom are bundled in Core. This commit resulted in some changes to the built files that are distributed in WordPress even though the actual version of the libraries remained the same. The result can be a blank white screen when trying to edit a post when those two script files are heavily cached.

This uses `.1` as the appendage to prevent issues with third party code expecting the version number in the form `/^[\d\.]+$/`.

Updates include tests in `Tests_Dependencies_Scripts::test_vendor_script_versions_registered_manually` to include the modified version used for cache busting.

Reviewed by jorbin.
Merges [59536] and [59540] to 6.7 branch.

Props levskipg, get_dave, smerriman, jdnd, juanwp22, seanlanglands, robertstaddon, azaozz, peterwilsoncc, desrosj.
Fixes #62422.


git-svn-id: https://develop.svn.wordpress.org/branches/6.7@59741 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Aaron Jorbin 2025-01-30 20:42:03 +00:00
parent 937206b88c
commit f59e023b62
2 changed files with 17 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/wp-includes/script-loader.php
View File

@ -106,8 +106,8 @@ function wp_default_packages_vendor( $scripts ) {
);
$vendor_scripts_versions = array(
'react' => '18.3.1',
'react-dom' => '18.3.1',
'react' => '18.3.1.1', // Final .1 due to switch to UMD build, can be removed in the next update.
'react-dom' => '18.3.1.1', // Final .1 due to switch to UMD build, can be removed in the next update.
'react-jsx-runtime' => '18.3.1',
'regenerator-runtime' => '0.14.1',
'moment' => '2.30.1',

15
tests/phpunit/tests/dependencies/scripts.php
View File

@ -3413,6 +3413,21 @@ HTML
$handle = $script;
}
/*
* Append '.1' to the version number for React and ReactDOM.
*
* This is due to a change in the build to use the UMD version of the
* scripts, requiring a different version number in order to break the
* caches of some CDNs.
*
* This can be removed in the next update to the packages.
*
* See https://core.trac.wordpress.org/ticket/62422
*/
if ( in_array( $handle, array( 'react', 'react-dom' ), true ) ) {
$package_json[ $script ] .= '.1';
}
$script_query = $wp_scripts->query( $handle, 'registered' );
$this->assertNotFalse( $script_query, "The script '{$handle}' should be registered." );