mirror_php/wordpress
1
0
Fork 0
mirror of git://develop.git.wordpress.org/ synced 2025-02-25 00:52:55 +01:00
Code Issues Actions 10 Packages Projects Releases Wiki Activity

Code Modernization: Declare dynamic properties on WP_Text_Diff_Renderer_Table.

Browse Source 
Core uses 3 known, named, dynamic properties on the `WP_Text_Diff_Renderer_Table` class:

* `_title`
* `_title_left`
* `_title_right`

When reviewing revisions (within the admin UI), `wp_text_diff()` passes the arguments (without the leading `_`) to a new instance, which raised deprecation notices (see [56354]).

Note: the parent class adds the leading `_` to each of these properties (see [7747]).

The deprecation notices are resolved by declaring each of these known, named, dynamic properties on the class, per the #56034 mitigation strategy. These new properties are not initialized to retain their previous `null` behavior.

Follow-up to [56354], [23506], [7747].

Props wildworks, antonvlasenko, hellofromTonya, ironprogrammer, kafleg, mukesh27, nicolefurlan, presskopp, sabernhardt.
Fixes #59431.
See #58898, #56034.

git-svn-id: https://develop.svn.wordpress.org/trunk@56938 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Tonya Mork 2023-10-15 14:53:12 +00:00
parent 39e28173d5
commit f5e171652f
1 changed files with 24 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
src/wp-includes/class-wp-text-diff-renderer-table.php
View File

@ -30,6 +30,30 @@ class WP_Text_Diff_Renderer_Table extends Text_Diff_Renderer {
*/
public $_trailing_context_lines = 10000;
/**
* Title of the item being compared.
*
* @since 6.4.0 Declared a previously dynamic property.
* @var string|null
*/
public $_title;
/**
* Title for the left column.
*
* @since 6.4.0 Declared a previously dynamic property.
* @var string|null
*/
public $_title_left;
/**
* Title for the right column.
*
* @since 6.4.0 Declared a previously dynamic property.
* @var string|null
*/
public $_title_right;
/**
* Threshold for when a diff should be saved or omitted.
*