mirror of
git://develop.git.wordpress.org/
synced 2025-03-14 17:09:47 +01:00
Customize: Safeguard a check on the customize_validate_{$setting_id}
filter value to ensure it is a WP_Error
.
While the filter is documented to only support a `WP_Error`, it has been a common practice to return true in a validation function if no errors have occurred. This was already caught when the same filter was executed in `WP_Customize_Setting`, it was however missing in `WP_Customize_Manager::validate_setting_values()`. Props flixos90. Merges [43578] to the 4.9 branch. Fixes #44809. git-svn-id: https://develop.svn.wordpress.org/branches/4.9@43619 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
parent
0839d324af
commit
f8b390c4ff
@ -2284,7 +2284,7 @@ final class WP_Customize_Manager {
|
||||
if ( ! is_wp_error( $validity ) ) {
|
||||
/** This filter is documented in wp-includes/class-wp-customize-setting.php */
|
||||
$late_validity = apply_filters( "customize_validate_{$setting->id}", new WP_Error(), $unsanitized_value, $setting );
|
||||
if ( ! empty( $late_validity->errors ) ) {
|
||||
if ( is_wp_error( $late_validity ) && ! empty( $late_validity->errors ) ) {
|
||||
$validity = $late_validity;
|
||||
}
|
||||
}
|
||||
|
Loading…
x
Reference in New Issue
Block a user