From f95ddbcee54f2e4eaa4f55add3062be35450272b Mon Sep 17 00:00:00 2001
From: Pascal Birchler <swissspidy@git.wordpress.org>
Date: Tue, 17 Oct 2023 11:27:24 +0000
Subject: [PATCH] Build/Test Tools: Reinstate `PUPPETEER_SKIP_DOWNLOAD` for
 most CI workflows.

The `PUPPETEER_SKIP_DOWNLOAD` environment variable is used to prevent Puppeteer from automatically downloading browser binaries.
It was removed in [56926] due to the migration to Playwright. However, because of the QUnit tests, Puppeteer is actually still a dependency.

Until those tests change, we have to keep this environment variable to prevent unnecessary downloads on CI.

Props SergeyBiryukov.
Fixes #59517.

git-svn-id: https://develop.svn.wordpress.org/trunk@56954 602fd350-edb4-49c9-b593-d223f7449a82
---
 .github/workflows/coding-standards.yml  | 2 ++
 .github/workflows/end-to-end-tests.yml  | 1 +
 .github/workflows/performance.yml       | 2 ++
 .github/workflows/phpunit-tests-run.yml | 1 +
 .github/workflows/test-coverage.yml     | 1 +
 .github/workflows/test-npm.yml          | 3 +++
 6 files changed, 10 insertions(+)

diff --git a/.github/workflows/coding-standards.yml b/.github/workflows/coding-standards.yml
index 79ebf67416..0709194d35 100644
--- a/.github/workflows/coding-standards.yml
+++ b/.github/workflows/coding-standards.yml
@@ -142,6 +142,8 @@ jobs:
       contents: read
     timeout-minutes: 20
     if: ${{ github.repository == 'WordPress/wordpress-develop' || github.event_name == 'pull_request' }}
+    env:
+      PUPPETEER_SKIP_DOWNLOAD: ${{ true }}
 
     steps:
       - name: Checkout repository
diff --git a/.github/workflows/end-to-end-tests.yml b/.github/workflows/end-to-end-tests.yml
index 681738f14c..cd2746f307 100644
--- a/.github/workflows/end-to-end-tests.yml
+++ b/.github/workflows/end-to-end-tests.yml
@@ -32,6 +32,7 @@ permissions: {}
 
 env:
   LOCAL_DIR: build
+  PUPPETEER_SKIP_DOWNLOAD: ${{ true }}
 
 jobs:
   # Runs the end-to-end test suite.
diff --git a/.github/workflows/performance.yml b/.github/workflows/performance.yml
index d936c62d19..43b92e2cd7 100644
--- a/.github/workflows/performance.yml
+++ b/.github/workflows/performance.yml
@@ -30,6 +30,8 @@ concurrency:
 permissions: {}
 
 env:
+  PUPPETEER_SKIP_DOWNLOAD: ${{ true }}
+
   # Performance testing should be performed in an environment reflecting a standard production environment.
   LOCAL_WP_DEBUG: false
   LOCAL_SCRIPT_DEBUG: false
diff --git a/.github/workflows/phpunit-tests-run.yml b/.github/workflows/phpunit-tests-run.yml
index eb3eab76e7..871585d572 100644
--- a/.github/workflows/phpunit-tests-run.yml
+++ b/.github/workflows/phpunit-tests-run.yml
@@ -51,6 +51,7 @@ env:
   LOCAL_DB_VERSION: ${{ inputs.db-version }}
   LOCAL_PHP_MEMCACHED: ${{ inputs.memcached }}
   PHPUNIT_CONFIG: ${{ inputs.phpunit-config }}
+  PUPPETEER_SKIP_DOWNLOAD: ${{ true }}
 
 jobs:
   # Runs the PHPUnit tests for WordPress.
diff --git a/.github/workflows/test-coverage.yml b/.github/workflows/test-coverage.yml
index 5e963900fb..8e400167f0 100644
--- a/.github/workflows/test-coverage.yml
+++ b/.github/workflows/test-coverage.yml
@@ -33,6 +33,7 @@ env:
   LOCAL_PHP_XDEBUG: true
   LOCAL_PHP_XDEBUG_MODE: 'coverage'
   LOCAL_PHP_MEMCACHED: ${{ false }}
+  PUPPETEER_SKIP_DOWNLOAD: ${{ true }}
 
 jobs:
   # Runs the PHPUnit tests for WordPress.
diff --git a/.github/workflows/test-npm.yml b/.github/workflows/test-npm.yml
index 185908f794..d53c8ec825 100644
--- a/.github/workflows/test-npm.yml
+++ b/.github/workflows/test-npm.yml
@@ -37,6 +37,9 @@ concurrency:
 # Any needed permissions should be configured at the job level.
 permissions: {}
 
+env:
+  PUPPETEER_SKIP_DOWNLOAD: ${{ true }}
+
 jobs:
   # Verifies that installing npm dependencies and building WordPress works as expected.
   #