Standardize on "Go to..." as a more appropriate option for most cases.
Props garrett-eclipse, kharisblank, audrasjb, ramiy, valentinbora.
Fixes#47235.
git-svn-id: https://develop.svn.wordpress.org/trunk@49539 602fd350-edb4-49c9-b593-d223f7449a82
* The array of network data returned from the `networks_pre_query` filter is assigned to the `networks` property of the current `WP_Network_Query` instance.
* The array of site data returned from the `sites_pre_query` filter is assigned to the `sites` property of the current `WP_Site_Query` instance.
This avoids the performance overhead of calling `WP_Network_Query::get_networks()` or `WP_Site_Query::get_sites()` twice: first when creating the object instance, then to retrieve the filtered results.
This also makes the filters a bit more consistent with other similar filters, e.g. `posts_pre_query`, `terms_pre_query`, `comments_pre_query`, or `users_pre_query`.
Follow-up to [46086], [48990].
Props yakimun, spacedmonkey.
Fixes#51333.
git-svn-id: https://develop.svn.wordpress.org/trunk@49538 602fd350-edb4-49c9-b593-d223f7449a82
This will discard any invalid responses instead of causing fatal errors.
It also makes badges optional, on the same basis as actions are optional. They are expected, but there may be situations where they are not present.
Props Clorith, dogwithblog, kraftbj, whyisjake, SergeyBiryukov.
Fixes#50145.
git-svn-id: https://develop.svn.wordpress.org/trunk@49537 602fd350-edb4-49c9-b593-d223f7449a82
Add the GD extension as a hard requirement.
This improves the reliability of the test suite and ensures that if the test infrastructure changes in the future and a platform requirement such as GD accidentally gets removed, the tests fail with an appropriate error message.
Follow-up to [48592].
Props ayeshrajans, jrf, johnbillion.
Fixes#50640.
git-svn-id: https://develop.svn.wordpress.org/trunk@49535 602fd350-edb4-49c9-b593-d223f7449a82
Application Passwords introduced a new Rewrite Rule to handle the Authorization header on certain systems. This bumps the database version so the change is applied to sites upon upgrading to 5.6.
Fixes#51723.
git-svn-id: https://develop.svn.wordpress.org/trunk@49534 602fd350-edb4-49c9-b593-d223f7449a82
Add a reference to `esc_url()` from `esc_url_raw()` return value description.
Props stevenlinx, audrasjb, helen.
Fixes#50585.
git-svn-id: https://develop.svn.wordpress.org/trunk@49512 602fd350-edb4-49c9-b593-d223f7449a82
This explicitly sets top and bottom margins instead of defining all four sides in shorthand notation.
Props sabernhardt, Lumne.
Fixes#51148.
git-svn-id: https://develop.svn.wordpress.org/trunk@49507 602fd350-edb4-49c9-b593-d223f7449a82
These arguments were introduced with the initial block editor, but not documented previously.
Follow-up to [49495].
Props TimothyBlynJacobs.
See #46261.
git-svn-id: https://develop.svn.wordpress.org/trunk@49496 602fd350-edb4-49c9-b593-d223f7449a82
Add a `@since` entry for `template` and `template_lock` arguments.
Follow-up to [49041], [49492], [49494].
See #46261.
git-svn-id: https://develop.svn.wordpress.org/trunk@49495 602fd350-edb4-49c9-b593-d223f7449a82
* Split the summary for `$template` per the documentation standards. The summary should be a single sentence.
* Change the type for `$template_lock` to `string|false`, to clarify that `true` is not supported.
* Fix typo in `$delete_with_user` description, adjust for better readability.
Follow-up to [49041], [49492].
See #46261.
git-svn-id: https://develop.svn.wordpress.org/trunk@49494 602fd350-edb4-49c9-b593-d223f7449a82
Add and document the template and template_lock attributes on WP_Post_Type that
are used by the block editor.
Props metalandcoffee.
See #46261.
git-svn-id: https://develop.svn.wordpress.org/trunk@49492 602fd350-edb4-49c9-b593-d223f7449a82
This fixes an issue introduced in [49369] that causes l10n related tests to fail when the PHPUnit test suite is run multiple times without hints of the site being under version control.
[49369] removed the `.git` folder from the ZIP artifact created during the initial setup job. This ZIP file is used by the later jobs in the workflow that run the test suite. The absence of the `.git` folder in these later jobs caused the language packs initially loaded from `phpunit/data/languages` folder to be updated asynchronously, resulting in unexpected values when running the tests a second time.
This change disables all Core auto-update and asynchronous language pack update attempts when running PHPUnit tests.
Props ocean90, SergeyBiryukov.
See #50401.
Fixes#51670.
git-svn-id: https://develop.svn.wordpress.org/trunk@49491 602fd350-edb4-49c9-b593-d223f7449a82
This better conveys the message of the notice and brings consistency with other success notices throughout Core.
Props audrasjb.
Fixes#51701.
git-svn-id: https://develop.svn.wordpress.org/trunk@49490 602fd350-edb4-49c9-b593-d223f7449a82
In each of these instances the variable being tested is a directly instantiated object and can never be a `WP_Error`, unlike when `wp_get_image_editor()` is used.
See #51344
git-svn-id: https://develop.svn.wordpress.org/trunk@49488 602fd350-edb4-49c9-b593-d223f7449a82
This brings some consistency between the two DocBlocks and adjusts the latter one per the documentation standards.
Follow-up to [49482].
See #50569.
git-svn-id: https://develop.svn.wordpress.org/trunk@49484 602fd350-edb4-49c9-b593-d223f7449a82
This switches to using `wp_parse_args()` instead of a combination of `array_merge()` and `array_intersect_key()` when ensuring that all expected default keys are present in the update information for a plugin.
This prevents non-default data returned by 3rd-party plugins from being unintentionally stripped out.
Props peterwilsoncc, chriscct7.
Fixes#51609.
git-svn-id: https://develop.svn.wordpress.org/trunk@49477 602fd350-edb4-49c9-b593-d223f7449a82
This brings some consistency with other text links on the screen, e.g. "View version details" for plugins or themes.
Follow-up to [49150].
Props afercia.
See #51523.
git-svn-id: https://develop.svn.wordpress.org/trunk@49471 602fd350-edb4-49c9-b593-d223f7449a82
If reinstalling WordPress, there is a condition where tables would exist in the database. Ensures that when that is the case, the install process can carry along without issue.
Fixes#51676.
Props xknown, garubi, mukesh27, desrosj, johnbillion, metalandcoffee, davidbaumwald, whyisjake.
git-svn-id: https://develop.svn.wordpress.org/trunk@49452 602fd350-edb4-49c9-b593-d223f7449a82
Partial revert of [49141], [49171], [49316].
All functional changes are removed, appropriate term counting unit tests are retained.
See #40351.
git-svn-id: https://develop.svn.wordpress.org/trunk@49451 602fd350-edb4-49c9-b593-d223f7449a82
The flag was previously used in PDF preview tests when cleaning up temporary files.
As noted in the PHP documentation, the flag is not available on some non-GNU systems, like Solaris or Alpine Linux.
Follow-up to [40130].
Props amykamala, sawanoboly.
Fixes#51661.
git-svn-id: https://develop.svn.wordpress.org/trunk@49450 602fd350-edb4-49c9-b593-d223f7449a82
