6390 Commits

Author	SHA1	Message	Date
Sergey Biryukov	cdc2f255ac	Tests: Clean up convert_smilies() tests. ... Includes: * Removing redundant `use_smilies` option switches, as it is set to 1 by default. * Restoring the `$wpsmiliestrans` array before performing assertions, not after. * Moving most of the `smilies_init()` calls to a `set_up()` method. Follow-up to [409/tests], [26191], [28717]. See #62278. git-svn-id: https://develop.svn.wordpress.org/trunk@59516 602fd350-edb4-49c9-b593-d223f7449a82	2024-12-15 23:22:22 +00:00
Sergey Biryukov	c3c319ed58	Formatting: Check the result of preg_split() in convert_smilies(). ... This aims to avoid a fatal error from `count()` when `preg_split()` fails on large input. Includes: * Optimizing the regular expression used to split the input by tags to avoid unlimited backtracking for better performance. * Adjusting the function logic for better readability. Follow-up to [340], [4380], [26191]. Props podpirate, nathkrill, rajinsharwar, dmsnell, bjorsch, q0rban, audrasjb, rupw, Ov3rfly, jorbin, nhrrob, chaion07, mcqueen22, azaozz, narenin, roybellingan, SergeyBiryukov. See #51019. git-svn-id: https://develop.svn.wordpress.org/trunk@59515 602fd350-edb4-49c9-b593-d223f7449a82	2024-12-14 23:51:09 +00:00
Greg Ziółkowski	1467750709	HTML API: Prevent bookmarks from being set on virtual tokens ... Fixes the issue when an HTML_Processor bookmark was set at a virtual token (a node in the resulting document that does not correspond to an HTML token present in the input string), seek behavior was unreliable. Props jonsurrell, gziolo. Fixes #62521. git-svn-id: https://develop.svn.wordpress.org/trunk@59502 602fd350-edb4-49c9-b593-d223f7449a82	2024-12-10 09:11:35 +00:00
Pascal Birchler	9c7d008158	Embeds: ensure correct thumbnail height. ... Use height 0 instead of 9999 to avoid unnecessarily using the full size version. Props colinleroy, swissspidy. Fixes #62094. git-svn-id: https://develop.svn.wordpress.org/trunk@59493 602fd350-edb4-49c9-b593-d223f7449a82	2024-12-05 21:19:37 +00:00
bernhard-reiter	1d49212bb9	Block Hooks: Fix context in update_ignored_hooked_blocks_postmeta. ... Ensure that the `$context` arg passed from `update_ignored_hooked_blocks_postmeta` to `apply_block_hooks_to_content` (and from there, to filters such as `hooked_block_types` and `hooked_block`) has the correct type (`WP_Post`). Filters hooked to `hooked_block_types` etc can typically include checks that conditionally insert a hooked block depending on `$context`. Prior to this changeset, a check like `if ( $context instanceof WP_Post )` would incorrectly fail, as `$context` would be a `stdClass` instance rather than a `WP_Post`. As a consequence, a hooked block inside of a Navigation post object that was modified by the user would not be marked as ignored by `update_ignored_hooked_blocks_postmeta`, and thus be erroneosly re-inserted by the Block Hooks algorithm. Props bernhard-reiter. Fixes #62639. git-svn-id: https://develop.svn.wordpress.org/trunk@59482 602fd350-edb4-49c9-b593-d223f7449a82	2024-12-04 12:05:33 +00:00
Greg Ziółkowski	e89e279e03	Interactivity API: Support length property on strings and arrays on the server ... The Interactivity API tries to align client and server rendering so that the behavior is the same. Adds missing handling for `.length` to directives processing on the server on strings and numeric arrays which is inherently supported through JavaScript language on the client. Props jonsurrell, gziolo, luisherranz. Fixes #62582. git-svn-id: https://develop.svn.wordpress.org/trunk@59477 602fd350-edb4-49c9-b593-d223f7449a82	2024-12-02 08:08:34 +00:00
Adam Silverstein	0671dfd5b4	Media: improve filter to enable setting output quality by image size. ... Add a new $size parameter to the wp_editor_set_quality filter. $size is an array with 'width' and 'height' keys. Developers can use this information to set image quality based on the image size. Props adamsilverstein, joemcgill, Mte90, codekraft, birgire, azaozz, sppramodh. Fixes #54648. git-svn-id: https://develop.svn.wordpress.org/trunk@59473 602fd350-edb4-49c9-b593-d223f7449a82	2024-11-29 23:46:50 +00:00
bernhard-reiter	e99d83918a	HTML API: Make non-body fragment creation methods private. ... The current implementation of `create_fragment` (and the underlying `create_fragment_at_current_node`) allows passing in a context that might result in a tree that cannot be represented by HTML. For example, a user might use `<p>` as context, and attempt to create a fragment that also consists of a paragraph element, `<p>like this`. This would result in a paragraph node nested inside another -- something that can never result from parsing HTML. To prevent this, this changeset makes `create_fragment_at_current_node` private and limits `create_fragment` to only `<body>` as context, while a comprehensive solution to allow other contexts is being worked on. Follow-up to [59444], [59467]. Props jonsurrell, dmsnell, bernhard-reiter. Fixes #62584. git-svn-id: https://develop.svn.wordpress.org/trunk@59469 602fd350-edb4-49c9-b593-d223f7449a82	2024-11-28 14:25:51 +00:00
bernhard-reiter	4b3436968d	HTML API: Allow more contexts in create_fragment. ... This changeset modifies `WP_HTML_Processor::create_fragment( $html, $context )` to use a full processor and `create_fragment_at_node` instead of the other way around. This makes more sense and makes the main factory methods more clear, where the state required for fragments is set up in `create_fragment_at_node` instead of in both `create_fragment` and `create_fragment_at_current_node`. This allows for more HTML contexts to be provided to the basic `create_fragment` where the provided context HTML is appended to `<!DOCTYPE html>`, a full processor is created, the last tag opener is found, and a fragment parser is created at that node via `create_fragment_at_current_node`. The HTML5lib tests are updated accordingly to use this new method to create fragments. Props jonsurrell, dmsnell, bernhard-reiter. Fixes #62584. git-svn-id: https://develop.svn.wordpress.org/trunk@59467 602fd350-edb4-49c9-b593-d223f7449a82	2024-11-27 14:33:46 +00:00
Carlos Bravo	9840f03281	HTML API: Recognize all uppercase tag names in tag processor. ... Fixes a missing "D" in the character list used by strspn to find tag openers, causing tags starting with D to be skipped by the tag processor in some circumstances. Follow-up to [58613]. Props jonsurrell, santosguillamot, wongjn, cbravobernal. Fixes #62522. git-svn-id: https://develop.svn.wordpress.org/trunk@59464 602fd350-edb4-49c9-b593-d223f7449a82	2024-11-27 09:55:53 +00:00
bernhard-reiter	1aa41dea33	REST API: Terms: Respect taxonomy's default query args. ... It is possible to supply a set of default query `args` to `register_taxonomy()` which will be used when querying a list of terms -- for example, `orderby` in order to specify how the resulting list of terms should be sorted. The Terms REST API controller previously respected these default query args only if the request included a post ID. This changeset makes it so that the default args will also be respected if no post ID is provided. Props bernhard-reiter, jsnajdr. Fixes #62500. git-svn-id: https://develop.svn.wordpress.org/trunk@59458 602fd350-edb4-49c9-b593-d223f7449a82	2024-11-25 11:14:37 +00:00
Pascal Birchler	27c566f1ac	REST API: Remove trailing slashes when preloading requests and there is a query string. ... Follow-up to [51648], see #51636. Props antonvlasenko, swissspidy, spacedmonkey. Fixes #57048. git-svn-id: https://develop.svn.wordpress.org/trunk@59457 602fd350-edb4-49c9-b593-d223f7449a82	2024-11-25 10:08:05 +00:00
Carlos Bravo	1563d8622d	HTML API: Prevent fragment creation on close tag. ... Prevent fragments from being created at tag closers. Follow-up to [59444]. Props jonsurrell, bernhard-reiter. Fixes #62357. git-svn-id: https://develop.svn.wordpress.org/trunk@59450 602fd350-edb4-49c9-b593-d223f7449a82	2024-11-22 12:50:48 +00:00
bernhard-reiter	71a52ced57	HTML API: Add method to create fragment at node. ... HTML Fragment parsing always happens with a context node, which may impact how a fragment of HTML is parsed. HTML Fragment Processors can be instantiated with a `BODY` context node via `WP_HTML_Processor::create_fragment( $html )`. This changeset adds a static method called `create_fragment_at_current_node( string $html_fragment )`. It can only be called when the processor is paused at a `#tag`, with some additional constraints: - The opening and closing tags must appear in the HTML input (no virtual tokens). - No "self-contained" elements are allowed ( `IFRAME`, `SCRIPT`, `TITLE`, etc.). If successful, the method will return a `WP_HTML_Processor` instance whose context is inherited from the node that the method was called from. Props jonsurrell, bernhard-reiter, gziolo. Fixes #62357. git-svn-id: https://develop.svn.wordpress.org/trunk@59444 602fd350-edb4-49c9-b593-d223f7449a82	2024-11-21 13:27:58 +00:00
Jonathan Desrosiers	193f6eb26e	i18n: Account for load_*_textdomain() after JIT loading. ... When `load_*_textdomain()` functions are called after WordPress has already attempted just-in-time loading of translations, nothing happens. This updates the related logic to retry translation loading when a custom path is set to ensure all translations are available. Additionally, this also fixes cases where an `en_US.mo` file is provided with non-English strings to override the default language. Follow up to [59157]. Props swissspidy, peterwilsoncc, desrosj, apermo, sergeybiryukov, wildworks, tigriweb, twvania, looswebstudio, stimul, audrasjb, finntown, bluantinoo, timwhitlock, albigdd. See #62337. git-svn-id: https://develop.svn.wordpress.org/trunk@59430 602fd350-edb4-49c9-b593-d223f7449a82	2024-11-20 02:48:40 +00:00
Michal Czaplinski	6c00c00fd6	HTML API: Use case insensitive tag_name comparison in ::next_tag. ... The HTML API `::next_tag` method now performs case-insensitive matching when searching for tags by name. For example, searching for 'DIV' will match both '<div>' and '<DIV>' tags. Props jonsurrell, dmsnell. Fixes #62427. git-svn-id: https://develop.svn.wordpress.org/trunk@59422 602fd350-edb4-49c9-b593-d223f7449a82	2024-11-19 16:03:08 +00:00
ramonopoly	dec5c90645	Theme JSON: include block style variations in path only output of get_block_nodes ... An `$include_node_paths_only` option to `get_block_nodes()` was introduced to improve performance. When set to `true`, this option tells the function to only return paths, and not selectors, for consumers that only needed paths to style values. For one of the conditional blocks, block style variations wasn't included. This commit adds them to the array of paths following the existing model `$node[]['path' => [], 'variations' => ['path' => []]]`. Follow-up to [61858]. Props aaronrobertshaw, ramonopoly. Fixes #62399. git-svn-id: https://develop.svn.wordpress.org/trunk@59418 602fd350-edb4-49c9-b593-d223f7449a82	2024-11-19 04:42:17 +00:00
Felix Arntz	61b9859728	Media: Avoid images with sizes=auto to be displayed downsized in supporting browsers. ... Based on the user agent stylesheet rules outlined in https://html.spec.whatwg.org/multipage/rendering.html#img-contain-size, images that have `sizes=auto` while applying `width: auto` or `width: fit-content` would be constrained to only 300px width. This changeset overrides said user agent stylesheet rule with a much larger constraint, to avoid the problem. Additionally, it introduces a filter `wp_img_tag_add_auto_sizes` which can be used to opt out of the functionality, as an additional measure. Props joemcgill, flixos90, dooperweb, SirLouen, azaozz, mukesh27, apermo. Fixes #62413. See #61847, #62345. git-svn-id: https://develop.svn.wordpress.org/trunk@59415 602fd350-edb4-49c9-b593-d223f7449a82	2024-11-18 19:50:06 +00:00
Carlos Bravo	91eb2517be	HTML API: Fix normalized doctype pub/sys identifier quotes. ... Changeset [59399] fixed missing DOCTYPEs in normalized HTML output. It missed an edge case where public and system identifiers may contain double quotes, in which case they must be quoted with single quotes. This commit addresses that issue and adds tests. Follow-up to [59399]. Props jonsurrell, luisherranz, apermo. Fixes #62396. git-svn-id: https://develop.svn.wordpress.org/trunk@59410 602fd350-edb4-49c9-b593-d223f7449a82	2024-11-18 13:05:35 +00:00
Sergey Biryukov	a731b9bfc0	Tests: Add missing @covers tag for fetch_feed() tests. ... Includes correcting the test class name as per the naming conventions. Follow-up to [59382]. See #62280. git-svn-id: https://develop.svn.wordpress.org/trunk@59408 602fd350-edb4-49c9-b593-d223f7449a82	2024-11-17 13:43:00 +00:00
bernhard-reiter	1a27422be3	HTML API: Include doctype in full parser serialize. ... Output DOCTYPE when calling `WP_HTML_Processor::serialize` on a full document that includes a DOCTYPE. The DOCTYPE should be included in the serialized/normalized HTML output as it has an impact in how the document is handled, in particular whether the document should be handled in quirks or no-quirks mode. This only affects the serialization of full parsers at this time because DOCTYPE tokens are currently ignored in all possible fragments. The omission of the DOCTYPE is subtle but can change the serialized document's quirks/no-quirks mode. Props jonsurrell. Fixes #62396. git-svn-id: https://develop.svn.wordpress.org/trunk@59399 602fd350-edb4-49c9-b593-d223f7449a82	2024-11-13 12:18:48 +00:00
Carlos Bravo	db2f6fe38e	Interactivity API: Allow missing state negation on server ... Aligns on the behavior of the negation operator with directives to missing paths in client and in server. With a directive like the following: {{{ <div data-wp-bind--hidden="!state.missing.property"> This should be hidden by the <code>hidden</code> attribute. </div> }}} Both server and client will return with this fix: {{{ <div data-wp-bind--hidden="!state.missing.property" hidden=""> This should be hidden by the <code>hidden</code> attribute. </div> }}} Props jonsurrell, luisherranz. Fixes #62374. git-svn-id: https://develop.svn.wordpress.org/trunk@59398 602fd350-edb4-49c9-b593-d223f7449a82	2024-11-13 11:17:48 +00:00
bernhard-reiter	ed0ad98bc4	HTML API: Expect closer on foreign content void lookalike elements. ... Ensure that `expects_closer` returns `false` on tags that look like void HTML tags, but are actually ''not'' void tags in foreign content. Props jonsurrell, bernhard-reiter. Fixes #62363. git-svn-id: https://develop.svn.wordpress.org/trunk@59392 602fd350-edb4-49c9-b593-d223f7449a82	2024-11-12 12:56:37 +00:00
bernhard-reiter	7b3d1078ec	HTML API: Ensure that full processor can seek to earlier bookmarks. ... When the HTML Processor seeks to an earlier place, it returns the the beginning of the document and proceeds forward until it reaches the appropriate location. This requires resetting internal state so that the processor can correctly proceed from the beginning of the document. The seeking reset logic was not adapted to account for the full processor (i.e. when created via `WP_HTML_Processor::create_full_parser()`). This change updates the seek logic to account for the full and fragment parsers as well as other state that has been introduced in the interim and should be reset. Props jonsurrell, dmsnell, westonruter, mi5t4n. Fixes #62290. git-svn-id: https://develop.svn.wordpress.org/trunk@59391 602fd350-edb4-49c9-b593-d223f7449a82	2024-11-12 10:30:26 +00:00
Jonathan Desrosiers	2762e5e92b	Feeds: Avoid fatal error with empty blog_charset value. ... After the SimplePie library was updated to version `1.8.0` in [59141], an edge case has been discovered where a fatal error can encountered if the `blog_charset` option is missing or empty. In `fetch_feed()`, this option is retrieved using `get_option()` instead of `get_bloginfo( ‘charset’ )`. The latter will detect this scenario and apply a default value of `UTF-8` and is already used interchangeably throughout Core. This switches to `get_bloginfo( ‘charset’ )` instead to prevent this edge case. Props david.binda, davidbaumwald, SergeyBiryukov, sabernhardt, azaozz, peterwilsoncc. Fixes #62354. git-svn-id: https://develop.svn.wordpress.org/trunk@59382 602fd350-edb4-49c9-b593-d223f7449a82	2024-11-11 17:48:42 +00:00
Peter Wilson	05e274b8db	Media: Include image update missed in [59379]. ... "We missed you", hissed the lovecats. -- The Cure. See #62359. git-svn-id: https://develop.svn.wordpress.org/trunk@59380 602fd350-edb4-49c9-b593-d223f7449a82	2024-11-10 22:43:43 +00:00
Peter Wilson	e1f052ec31	Media: Remove dimension suffix from full size converted HEIC images. ... Removes the dimension suffix, eg `-1000x1000` from the file name of full size images automatically converted from HEIC to JPEGs by WordPress. Introduces unit tests for the default conversion of images and customized conversion settings via the `image_editor_output_format` filter. Follow up to [58849], [58942], [59317], [59346], [59366] Props mukesh27, peterwilsoncc, azaozz, apermo, flixos90, ironprogrammer. Fixes #62359. See #53645, #62305. git-svn-id: https://develop.svn.wordpress.org/trunk@59379 602fd350-edb4-49c9-b593-d223f7449a82	2024-11-10 21:40:00 +00:00
Weston Ruter	8ad5281bad	HTML API: Improve private method name used by WP_HTML_Processor::next_token(). ... This renames the private `_next_token` method to `next_visitable_token`. It also removes irrelevant assertions from the unit test. Follow-up to [59285]. Props dmsnell, jonsurrell, westonruter. See #62269. git-svn-id: https://develop.svn.wordpress.org/trunk@59364 602fd350-edb4-49c9-b593-d223f7449a82	2024-11-06 19:22:22 +00:00
ramonopoly	b1b57613a0	Theme JSON: replace top-level background style objects on merge ... This commit fixes an omission in the logic of `WP_Theme_JSON::merge()` where top-level background image style objects are not replaced, rather they are merged. Because background images are self contained objects, their properties are unique and should not be merged. Blocks are already catered for via `WP_Theme_JSON::get_block_nodes()`. Follow-up to [61858]. Props ramonopoly, andrewserong. Fixes #62328. git-svn-id: https://develop.svn.wordpress.org/trunk@59335 602fd350-edb4-49c9-b593-d223f7449a82	2024-11-01 05:24:53 +00:00
Peter Wilson	023af2111b	Tests/Build tools: Only fail importer tests if plugin is missing. ... Reverts an earlier change to the test suite in which the PHPUnit tests could not run if the importer plugin was not available. This update allows the test suite to run and will fail importer tests if the plugin is not available. Follow up to r59085. Props peterwilsoncc, azaozz. See #62325. git-svn-id: https://develop.svn.wordpress.org/trunk@59326 602fd350-edb4-49c9-b593-d223f7449a82	2024-10-30 23:27:08 +00:00
Sergey Biryukov	695476ea5e	Comments: Use a more precise check for disallowed keys on filtered comment data. ... The previous approach of running `wp_allow_comment()` twice could have unintended consequences, e.g. the `check_comment_flood` action was also triggered twice, which might lead to false-positive identification of comment flood in case there is some custom callback hooked to it, which is not expecting identical data seeing twice. This commit introduces a new function, `wp_check_comment_data()`, to specifically check for disallowed content before and after comment data is filtered. Follow-up to [59267]. Props david.binda, SergeyBiryukov. See #61827. git-svn-id: https://develop.svn.wordpress.org/trunk@59319 602fd350-edb4-49c9-b593-d223f7449a82	2024-10-29 15:36:56 +00:00
Sergey Biryukov	6bc26d5aed	Users: Set correct default value for $user_login in retrieve_password(). ... This resolves a "passing null to non-nullable" deprecation notice on PHP 8.1+: {{{ Deprecated: trim(): Passing null to parameter #1 ($string) of type string is deprecated }}} Follow-up to [50129], [54477]. Props afragen, peterwilsoncc, SergeyBiryukov. Fixes #62298. git-svn-id: https://develop.svn.wordpress.org/trunk@59312 602fd350-edb4-49c9-b593-d223f7449a82	2024-10-28 20:03:13 +00:00
Sergey Biryukov	ea88e1fd71	Tests: Use better domain for HTTP API invalid hostname test. ... The previous domain that was used to test for a host whose IPv4 address cannot be resolved, `exampleeeee.com`, got registered and has an A-record now, so it's not invalid anymore. `.invalid` is intended for use in online construction of domain names that are sure to be invalid and which it is obvious at a glance are invalid. Reference: [https://datatracker.ietf.org/doc/html/rfc2606#section-2 Reserved Top Level DNS Names: TLDs for Testing, & Documentation Examples]. Follow-up to [52084], [58384], [58388]. Props sippis, johnbillion, MattyRob, swissspidy. Fixes #62303. git-svn-id: https://develop.svn.wordpress.org/trunk@59293 602fd350-edb4-49c9-b593-d223f7449a82	2024-10-27 19:03:48 +00:00
Weston Ruter	6573ea6e3c	HTML API: Fix extensibility of WP_HTML_Processor::next_token(). ... Break out logic from the `next_token()` method into a private method which may call itself recursively. This allows for subclasses to override the `next_token()` method and be assured that each call to `next_token()` corresponds with the consumption of one single token. This also parallels how `WP_HTML_Tag_Processor::next_token()` wraps a private `base_class_next_token()` method. Props westonruter, jonsurrell. Fixes #62269. git-svn-id: https://develop.svn.wordpress.org/trunk@59285 602fd350-edb4-49c9-b593-d223f7449a82	2024-10-23 22:03:23 +00:00
Sergey Biryukov	309ecbd324	Comments: Validate new comments before and after comment data is filtered. ... This ensures that a Disallowed Comment Keys match will consistently send the comment to the Trash, by checking both the original unmodified comment data and the final filtered comment data. If the first check has already resulted in a `trash` or `spam` status, the second check is skipped as redundant. Follow-up to [2894], [3851], [48121], [48575]. Props cfinke, kbrownkd, thompsonsj, mi5t4n, devspace, chaion07, engahmeds3ed, SergeyBiryukov. Fixes #61827. git-svn-id: https://develop.svn.wordpress.org/trunk@59267 602fd350-edb4-49c9-b593-d223f7449a82	2024-10-21 23:05:53 +00:00
Pascal Birchler	0d9c56edfb	I18N: Fix script languages path on Multisite. ... This is a follow-up to [59126] (itself a follow-up to [57922]), which caused a regression when determining the right path when loading script translations. Props swissspidy, themes-1, staurand. Fixes #62016. git-svn-id: https://develop.svn.wordpress.org/trunk@59264 602fd350-edb4-49c9-b593-d223f7449a82	2024-10-21 14:11:56 +00:00
Peter Wilson	ba472085a0	Editor: Load all style variation fonts within the editors. ... Loads the font family files from style variations defined within a theme for user in the site and post editors. This is to ensure the fonts are shown while editing without the need for a reload after switching styles. Props ironprogrammer, mmaattiiaass. Fixes #62231. git-svn-id: https://develop.svn.wordpress.org/trunk@59260 602fd350-edb4-49c9-b593-d223f7449a82	2024-10-20 23:23:11 +00:00
Sergey Biryukov	281a68fa14	Editor: Replace id attribute with class in WP_Font_Face::get_style_element(). ... `wp_print_font_faces()` prints an HTML tag that can be used more than once, so the document could end up having multiple tags with the same `id` attribute. The `id` global attribute defines an identifier (ID) which must be unique in the whole document. Reference: [https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/id MDN Web Docs: id]. Follow-up to [56500]. Props mmaattiiaass, peterwilsoncc. Fixes #62246. git-svn-id: https://develop.svn.wordpress.org/trunk@59259 602fd350-edb4-49c9-b593-d223f7449a82	2024-10-20 13:11:24 +00:00
Andrew Ozz	b1dade3c03	Upgrade/Install: Return WP_Error when source files cannot be found. ... Fixes a fatal error in `array_keys()` (PHP 8.0+) as `$wp_filesystem->dirlist()` will return `false` when the source directory doesn't exist or becomes unreadable for some reason. Props: verygoode, lifelightweb, da5f656f, costdev, afragen, azaozz Fixes #61114 git-svn-id: https://develop.svn.wordpress.org/trunk@59257 602fd350-edb4-49c9-b593-d223f7449a82	2024-10-18 23:35:02 +00:00
Joe McGill	39bda90823	Editor: Cache global styles for blocks. ... This caches the generated CSS from block nodes in merged Theme JSON data to avoid repeated costly operations required to compute style properties for blocks. The generated CSS is saved to a transient that expires every hour. This is a follow-up that reimplements [58334], which was previously reverted in [58710]. Props thekt12, spacedmonkey, pereirinha, mukesh27, isabel_brison, oandregal, andrewserong, ramonjd, joemcgill, costdev, aaronrobertshaw, peterwilsoncc. Fixes #61679. See #59595. git-svn-id: https://develop.svn.wordpress.org/trunk@59256 602fd350-edb4-49c9-b593-d223f7449a82	2024-10-18 21:53:45 +00:00
Greg Ziółkowski	70106015bf	HTML API: Fix the position update after changing the modifiable text when length differs ... There was an edge case detected for updating the text placed without the wrapping HTML tag with `set_modifiable_text`. Props gziolo, jonsurrell. Fixes #62241. git-svn-id: https://develop.svn.wordpress.org/trunk@59250 602fd350-edb4-49c9-b593-d223f7449a82	2024-10-18 13:29:04 +00:00
bernhard-reiter	6bb92c17e1	HTML API: Ensure form closer tokens are reachable. ... Form tag closers have complicated conditions. There was a bug where the HTML Processor would not stop correctly on a FORM tag closer token. This changeset ensures that that token is reachable. Developed in https://github.com/WordPress/wordpress-develop/pull/7582 Discussed in https://core.trac.wordpress.org/ticket/61576 Follow-up to [58779]. Props jonsurrell. Fixes #61576. git-svn-id: https://develop.svn.wordpress.org/trunk@59248 602fd350-edb4-49c9-b593-d223f7449a82	2024-10-17 17:46:31 +00:00
Adam Silverstein	b5df5f08e0	Media: Ensure Imagick quality is set correctly. ... Fix an issue where Imagick did not properly set image quality for AVIF images. Adds a call to `setCompressionQuality` where we currently call `setImageCompressionQuality` Props: jamesosborne, adamsilverstein, mukeshpanchal27. Fixes: #61614. git-svn-id: https://develop.svn.wordpress.org/trunk@59247 602fd350-edb4-49c9-b593-d223f7449a82	2024-10-17 17:03:23 +00:00
Sergey Biryukov	787e52f61a	Tests: Correct test class name for rss_enclosure() as per the naming conventions. ... Includes: * Moving `@covers` tags to the class-level DocBlock, since this is the only function tested in the class. * Adjusting the assertion messages for clarity, as `rss_enclosure()` does not return anything directly. * Using a static closure for improved performance. Follow-up to [59241]. See #61530. git-svn-id: https://develop.svn.wordpress.org/trunk@59243 602fd350-edb4-49c9-b593-d223f7449a82	2024-10-16 14:17:12 +00:00
Peter Wilson	4edc60427e	Feeds: Validate enclosures prior to generating tags. ... Prevent possible PHP warnings caused by malformed enclosure meta data. This change ensures the enclosure meta data has at least three lines of text before generating the tag in `rss_enclosure()`. Props arypneta, johnjamesjacoby, nihar007, rahmohn, rghedin, zahardoc. Fixes #58798. git-svn-id: https://develop.svn.wordpress.org/trunk@59241 602fd350-edb4-49c9-b593-d223f7449a82	2024-10-15 22:22:42 +00:00
Greg Ziółkowski	bf2aa81f6e	Editor: Bootstrap block binding sources with inline script from server ... Bootstrap block bindings sources earlier in the process through an inline script to ensure they are available when developers want to extend them in the client. Following the same pattern other APIs like registering block types are doing. Props santosguillamot, cbravobernal, gziolo. Fixes #6225. git-svn-id: https://develop.svn.wordpress.org/trunk@59238 602fd350-edb4-49c9-b593-d223f7449a82	2024-10-15 08:50:08 +00:00
Peter Wilson	7685041a59	Media: Account for post ID queries in update_post_thumbnail_cache(). ... Updates `update_post_thumbnail_cache()` to account for `WP_Query` objects that only contain the post ID field rather than the entire post object. This changes passes the `$post` value to `get_post_thumbnail_id()` rather than assuming the presence of the ID property. Additionally, the posts to which the thumbnail is attached are now primed prior to calling the function to avoid numerous unnecessary database queries. The test `WP_Test_REST_Posts_Controller::test_get_items_primes_parent_post_caches()` is modified to account for an order of operations change for the priming of post meta caches. The cache is no longer primed in the final call to `update_meta_cache()` so the tests need to account for the post meta to be primed in any call to the function. Props antpb, jorbin, khokansardar, linsoftware, mukesh27, oglekler, rajinsharwar, sumitsingh, xendo. Fixes #59521. git-svn-id: https://develop.svn.wordpress.org/trunk@59235 602fd350-edb4-49c9-b593-d223f7449a82	2024-10-14 22:20:09 +00:00
Sergey Biryukov	e4cdc743e1	Users: Further adjust the check for use_ssl meta in wp_insert_user(). ... This removes a redundant check for a falsey value, which is equivalent to the `empty()` check directly before. Includes minor adjustments in the unit test: * Adding a `@covers` tag. * Correcting the description for clarity. * Using `assertSame()` for strict type checking. Follow-up to [59216]. See #60299. git-svn-id: https://develop.svn.wordpress.org/trunk@59232 602fd350-edb4-49c9-b593-d223f7449a82	2024-10-14 21:14:49 +00:00
Pascal Birchler	f9bd807866	Sitemaps: Improve sitemap.xml redirects when using custom permalinks. ... Changes the way redirects from `sitemap.xml` to `wp-sitemap.xml` happen, so that they also work when using a more complex custom rewrite structure. Props gmariani405, swissspidy, euthelup, peterwilsoncc. Fixes #61931. git-svn-id: https://develop.svn.wordpress.org/trunk@59228 602fd350-edb4-49c9-b593-d223f7449a82	2024-10-14 08:47:34 +00:00
Peter Wilson	1dcbe1096e	Bundled Themes: Test new themes are added to new bundled files. ... Introduces a test to ensure that new bundled themes are included in the `$_new_bundled_files` array. Modifies previous theme related tests added during the 6.7 release cycle to include the correct annotations. Props peterwilsoncc, mukesh27, costdev. See #61530, #62103. git-svn-id: https://develop.svn.wordpress.org/trunk@59227 602fd350-edb4-49c9-b593-d223f7449a82	2024-10-14 01:05:09 +00:00