43450 Commits

Author SHA1 Message Date
Sergey Biryukov
622ab73fe6 Docs: Correct the alternative hook name for the deprecated whitelist_options hook.
Follow-up to [48121].

See .

git-svn-id: https://develop.svn.wordpress.org/trunk@50373 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-17 12:40:10 +00:00
Sergey Biryukov
e49c3c7f18 Docs: Correct the type of $widget_id argument in is_active_widget().
See .

git-svn-id: https://develop.svn.wordpress.org/trunk@50372 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-17 11:46:35 +00:00
Sergey Biryukov
135d567399 Robots: Rename wp_embed_no_robots to wp_robots_noindex_embeds().
This brings the naming in line with `wp_robots_noindex_search()`.

Follow-up to [49992], [50370].

See , .

git-svn-id: https://develop.svn.wordpress.org/trunk@50371 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-17 10:49:13 +00:00
Peter Wilson
f400eb5ab9 General: Add noindex robots meta tag to search results.
Prevent search engines indexing internal search results to protect against reflected web spam attacks.

Props abagtcs, audrasjb, ayeshrajans, burtrw, johnbillion, jonoaldersonwp, peterwilsoncc, poena, sabernhardt, xkon.
Fixes 


git-svn-id: https://develop.svn.wordpress.org/trunk@50370 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-16 23:36:44 +00:00
John Blackbourn
6299c30506 Post WordPress 5.7 Beta 3 version bump.
git-svn-id: https://develop.svn.wordpress.org/trunk@50369 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-16 21:18:06 +00:00
John Blackbourn
21c5666fce WordPress 5.7 beta 3.
git-svn-id: https://develop.svn.wordpress.org/trunk@50368 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-16 20:55:10 +00:00
Sergey Biryukov
9bac3d3401 External Libraries: Further fix jQuery deprecations in WordPress core.
This addresses `JQMIGRATE` warnings in some admin files and the Thickbox library.

Follow-up to [50001], [50270].

Props bordoni, poena.
See .

git-svn-id: https://develop.svn.wordpress.org/trunk@50367 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-16 20:23:19 +00:00
Sergey Biryukov
e23d442cd9 Twenty Nineteen: Add some space between the cookies checkbox and label in comment form.
Props sabernhardt, garrett-eclipse, mukesh27, monikarao, Boniu91.
Fixes .

git-svn-id: https://develop.svn.wordpress.org/trunk@50365 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-16 20:13:48 +00:00
Kelly Choyce-Dwan
55f2f3f67b Twenty Twenty-One: Remove background color from Social Links the dark gray style.
This block variation doesn't support custom colors, so allowing a background color leads to a mismatch between frontend and editor styles.

Props poena, paaljoachim, audrasjb.
Fixes .



git-svn-id: https://develop.svn.wordpress.org/trunk@50364 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-16 20:10:19 +00:00
Sergey Biryukov
944830428d Accessibility: Taxonomy: Correct keyboard navigation for the Tags meta box in classic editor.
Props sabernhardt, almendron, jose64, alexstine, joedolson, ryokuhi.
Fixes .

git-svn-id: https://develop.svn.wordpress.org/trunk@50363 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-16 20:02:35 +00:00
Sergey Biryukov
729873ddda Administration: Apply the months_dropdown_results filter separately from pre_months_dropdown_query.
Follow-up to [50163].

Props hellofromTonya.
Fixes .

git-svn-id: https://develop.svn.wordpress.org/trunk@50362 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-16 19:56:13 +00:00
Sergey Biryukov
0ff408d563 Twenty Ten: Correct the fallback to the default header if the featured image width is narrower than the twentyten_header_image_width setting.
Follow-up to [45581].

Props sabernhardt, macmanx, audrasjb.
Fixes .

git-svn-id: https://develop.svn.wordpress.org/trunk@50361 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-16 19:25:26 +00:00
Sergey Biryukov
0337b93b01 Twenty Eleven: Correct the fallback to the default header if the featured image width is narrower than the twentyeleven_header_image_width setting.
Follow-up to [45581].

Props sabernhardt, macmanx, audrasjb.
See .

git-svn-id: https://develop.svn.wordpress.org/trunk@50360 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-16 19:24:40 +00:00
Sergey Biryukov
5334a8dcca Twenty Twenty: Make sure the RTL list styles are preserved after npm run build.
Adjust the padding value for better consistency.

Props desrosj, sabernhardt, ryelle, mukesh27.
Fixes .

git-svn-id: https://develop.svn.wordpress.org/trunk@50359 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-16 19:09:55 +00:00
Kelly Choyce-Dwan
686448dde2 Bundled Themes: Fix alignment and styles for quote, verse, and code blocks.
Updates older themes to fix alignment, spacing, and font issues to better match the frontend display. Applies to themes: Twenty Eleven, Twenty Thirteen, Twenty Fourteen, Twenty Sixteen, Twenty Seventeen, and Twenty Twenty.

Props burnuser, talldanwp, cristinasoponar, poena, kjellr
Fixes .



git-svn-id: https://develop.svn.wordpress.org/trunk@50358 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-16 18:57:31 +00:00
John Blackbourn
28bc6a08cf Posts, Post Types: Update the styling of the legacy Links editing screen.
This brings its styling inline with other meta boxes in the admin area.

Props antonlukin, kburgoine, grzim, sabernhardt, pbiron, audrasjb

Fixes 


git-svn-id: https://develop.svn.wordpress.org/trunk@50357 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-16 18:47:39 +00:00
Sergey Biryukov
563ea09789 Filesystem API: Make sure to only call fread() on non-empty files in the PclZip library.
This avoids a fatal error on PHP 8 caused by passing a zero value to `fread()` as the `$length` argument, which must be greater than zero.

Props yakimun, fierevere, jrf, DavidAnderson, SergeyBiryukov.
Fixes .

git-svn-id: https://develop.svn.wordpress.org/trunk@50355 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-16 18:40:29 +00:00
John Blackbourn
22618cef9a Feeds: Fix the URL returned by get_feed_link() when pretty permalinks are not in use.
Props hauvong, peterwilsoncc, SergeyBiryukov

Fixes 


git-svn-id: https://develop.svn.wordpress.org/trunk@50354 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-16 17:32:58 +00:00
Sergey Biryukov
8bd8ead1da XML-RPC: Pass the method arguments and the XML-RPC server instance to the xmlrpc_call action.
This provides better context and makes the action easier to use when the call passes specific content in the payload of the request.

Props dd32.
Fixes .

git-svn-id: https://develop.svn.wordpress.org/trunk@50353 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-16 17:01:46 +00:00
Joe Dolson
4e4837d9b1 Media: Associate upload errors and field with controls.
Adds an explicit relationship between the upload button and the maximum upload limit, moves focus to the error dismiss button if an error occurs, and adds a call to wp.a11y.speak to report the error after it occurs.

Props afercia, anevins, antpb, adamsilverstein, poena
Fixes 

git-svn-id: https://develop.svn.wordpress.org/trunk@50352 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-16 04:03:37 +00:00
Peter Wilson
d9ceb1c434 Twenty Twenty-One: Display inline-images inline.
Remove `display: block` property from inline images and display them center aligned vertically.

Props jeroenrotty, melchoyce, mukesh27, paaljoachim, poena, talldanwp.
Fixes .



git-svn-id: https://develop.svn.wordpress.org/trunk@50351 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-16 02:24:11 +00:00
Peter Wilson
62614d976b Twenty Twenty-One: Match bullets between editor and frontend.
Change bullet style on frontend nested unordered lists to `circle` to match the editor styles.

Props poena, mukesh27, mahfuz01, tejwanihemant.
Fixes .



git-svn-id: https://develop.svn.wordpress.org/trunk@50350 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-15 23:50:06 +00:00
Peter Wilson
ad0a97f111 Bundled Themes: Synchronise .gitignore with themes' svn ignore property.
Add `node_modules` directories within Twenty Twenty-One, Twenty Twenty and Twenty Nineteen to the `.gitignore` file.

Fixes .


git-svn-id: https://develop.svn.wordpress.org/trunk@50349 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-15 23:17:36 +00:00
Peter Wilson
ed55dc802e Twenty Twenty-One: Add CSS source map files to committed files.
Remove `*.css.map` files from the ignore properties of Twenty Twenty-One directories, add the unignored files.

Props poena, peterwilsoncc.
Fixes .



git-svn-id: https://develop.svn.wordpress.org/trunk@50348 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-15 23:09:27 +00:00
Kelly Choyce-Dwan
caffd32f52 Bundled Themes: Support font size option for code block.
Adds font-size support to Twenty Fourteen, Twenty Sixteen, and Twenty Seventeen.

Props poena, paaljoachim, peterwilsoncc.
Fixes .



git-svn-id: https://develop.svn.wordpress.org/trunk@50347 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-15 18:54:02 +00:00
Kelly Choyce-Dwan
c3bf0a2fec Twenty Thirteen: Fix alignment of child blocks within the Cover block.
Props kjellr, melchoyce.
Fixes .



git-svn-id: https://develop.svn.wordpress.org/trunk@50346 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-15 18:31:01 +00:00
Sergey Biryukov
e50f46d49a Tests: Rename two classes in phpunit/tests/http/ to match the function names.
See .

git-svn-id: https://develop.svn.wordpress.org/trunk@50345 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-15 14:05:42 +00:00
Sergey Biryukov
4e4b4de3be Tests: Add missing @covers tags for files in phpunit/tests/http/.
Props patopaiar, jrf.
See .

git-svn-id: https://develop.svn.wordpress.org/trunk@50344 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-15 14:00:02 +00:00
Riad Benguella
9cab116980 Block Editor: Update packages with bug fixes to be included in WP 5.7 beta 3.
The updated packages are:

@wordpress/block-directory: 1.18.6 -> 1.18.7
@wordpress/block-editor: 5.2.6 -> 5.2.7
@wordpress/block-library: 2.28.3 -> 2.28.4
@wordpress/edit-post: 3.26.6 -> 3.26.7
@wordpress/editor: 9.25.6 -> 9.25.7
@wordpress/format-library: 1.26.6 -> 1.26.7
@wordpress/reusable-blocks: 1.1.6 -> 1.1.7

Props isabel_brison.
Fixes .


git-svn-id: https://develop.svn.wordpress.org/trunk@50343 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-15 08:27:50 +00:00
Sergey Biryukov
a17ae3dc0f Tests: Rename classes in phpunit/tests/hooks/ per the naming conventions.
https://make.wordpress.org/core/handbook/testing/automated-testing/writing-phpunit-tests/#naming-and-organization

Follow-up to [47780], [48911], [49327], [50291], [50292].
See .

git-svn-id: https://develop.svn.wordpress.org/trunk@50342 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-14 12:20:34 +00:00
Sergey Biryukov
8d1dfb6bcf Tests: Add missing @covers tags for files in phpunit/tests/hooks/.
Props patopaiar, jrf.
See .

git-svn-id: https://develop.svn.wordpress.org/trunk@50341 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-14 12:09:25 +00:00
Dominik Schilling
93e961bd76 Docs: Improve parameter types for various URL functions and filters that also accept null.
See .

git-svn-id: https://develop.svn.wordpress.org/trunk@50340 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-13 15:15:00 +00:00
Sergey Biryukov
cb623c351c Tests: Add missing @covers tags for files in phpunit/tests/general/.
Props patopaiar, jrf.
See .

git-svn-id: https://develop.svn.wordpress.org/trunk@50339 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-13 13:47:12 +00:00
Sergey Biryukov
3f50750a50 Tests: Simplify @covers tags in editor/wpEditors.php using @coversDefaultClass annotation.
Follow-up to [50288].

See .

git-svn-id: https://develop.svn.wordpress.org/trunk@50338 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-13 13:45:23 +00:00
Sergey Biryukov
f626e2897b Tests: Use @ticket annotation for ticket numbers, for clarity.
See .

git-svn-id: https://develop.svn.wordpress.org/trunk@50337 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-13 12:17:36 +00:00
gziolo
e794cb23a8 Tests: Fix failing unit test for block settings
Follow-up to [50297].

Fixes .




git-svn-id: https://develop.svn.wordpress.org/trunk@50300 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-12 16:39:01 +00:00
Jonathan Desrosiers
4e080befee Build/Test Tools: Run xDebug tests on PHP 8.0.
The PHP 8 Docker container for the local WordPress environment now contains xDebug 3.x (the version required for running on PHP 8), so the `xdebug` test group can now be run.

See , .

git-svn-id: https://develop.svn.wordpress.org/trunk@50299 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-12 16:36:14 +00:00
Jonathan Desrosiers
14c3fb1d43 Build/Test Tools: Run automated testing when tags are created.
This expands the list of events that triggers automated testing to include tags.

It also refines the matched version ranges for several workflows.

See .

git-svn-id: https://develop.svn.wordpress.org/trunk@50298 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-12 16:01:54 +00:00
Greg Ziółkowski
e3a98e8f55 Blocks: Add missing apiVersion field when preparing server-registered blocks for the block editor
When working on changes to @wordpress/create-block tool (https://github.com/WordPress/gutenberg/pull/28883) to use register_block_type_from_metadata with block.json file in the templates for scaffolded blocks I run into this issue where apiVersion wasn't exposed from the server.

Fixes .



git-svn-id: https://develop.svn.wordpress.org/trunk@50297 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-12 15:58:53 +00:00
Sergey Biryukov
d271a206db Block Editor: Remove extra quotes from the default font stack for editor styles.
Follow-up to [50155].

Props dd32, Joen, kafleg.
Fixes .

git-svn-id: https://develop.svn.wordpress.org/trunk@50295 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-12 07:53:28 +00:00
Peter Wilson
a55a9183bc Site Health: Update site-health script dependencies.
Add `wp-hooks` and `wp-i18n` to Site Health JavaScript dependencies.

Props gmariani405, Clorith, mukesh27.
Fixes .


git-svn-id: https://develop.svn.wordpress.org/trunk@50294 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-12 00:08:16 +00:00
Peter Wilson
37f41ee040 Twenty Twenty-One: Correct accent marks in block pattern alt text.
Correct accents in "Roses Trémières" for block patterns and starter content.

Props audrasjb, geekzebre, kjellr, SergeyBiryukov.
Fixes .



git-svn-id: https://develop.svn.wordpress.org/trunk@50293 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-12 00:01:08 +00:00
Sergey Biryukov
ae1a9ba8db Tests: Rename some files and classes in phpunit/tests/general/ per the naming conventions.
https://make.wordpress.org/core/handbook/testing/automated-testing/writing-phpunit-tests/#naming-and-organization

Follow-up to [47780], [48911], [49327], [50291].

See .

git-svn-id: https://develop.svn.wordpress.org/trunk@50292 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-11 21:38:30 +00:00
Sergey Biryukov
88567c5bae Tests: Rename some classes in phpunit/tests/date/ per the naming conventions.
https://make.wordpress.org/core/handbook/testing/automated-testing/writing-phpunit-tests/#naming-and-organization

Follow-up to [47780], [48911], [49327].

See .

git-svn-id: https://develop.svn.wordpress.org/trunk@50291 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-11 21:20:41 +00:00
Sergey Biryukov
835066933b Tests: Add missing @covers tags for files in phpunit/tests/external-http/.
Props patopaiar, jrf.
See .

git-svn-id: https://develop.svn.wordpress.org/trunk@50290 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-11 20:53:51 +00:00
Sergey Biryukov
5b3cb96ce0 Tests: Add missing @covers tags for files in phpunit/tests/error-protection/.
Props patopaiar, jrf.
See .

git-svn-id: https://develop.svn.wordpress.org/trunk@50289 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-11 20:53:19 +00:00
Sergey Biryukov
f184ef4b6c Tests: Add missing @covers tags for files in phpunit/tests/editor/.
Props patopaiar, jrf.
See .

git-svn-id: https://develop.svn.wordpress.org/trunk@50288 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-11 20:52:52 +00:00
Sergey Biryukov
c49e14bd7b Tests: Add missing @covers tags for files in phpunit/tests/dependencies/.
Props patopaiar, jrf.
See .

git-svn-id: https://develop.svn.wordpress.org/trunk@50287 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-11 15:15:37 +00:00
Sergey Biryukov
a4617592cb Tests: Add missing @covers tags for files in phpunit/tests/db/.
Props patopaiar, jrf.
See .

git-svn-id: https://develop.svn.wordpress.org/trunk@50286 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-11 14:02:42 +00:00
Jonathan Desrosiers
6e49ac2e96 Build/Test Tools: Install WordPress Importer plugin when installing the Docker-based local environment.
The WordPress Importer plugin is now downloaded to the `tests/phpunit/data/plugins` directory when running `npm run env:install`.

This ensures that the PHPUnit test suite will not fail when the plugin is missing.

This also introduces a new `WP_IMPORTER_REVISION` variable to the `.env` file, to control the SVN revision that is checked out.

Props johnbillion.
Fixes .

git-svn-id: https://develop.svn.wordpress.org/trunk@50285 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-10 16:52:13 +00:00