18383 Commits

Author SHA1 Message Date
John Blackbourn
21c5666fce WordPress 5.7 beta 3.
git-svn-id: https://develop.svn.wordpress.org/trunk@50368 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-16 20:55:10 +00:00
Sergey Biryukov
9bac3d3401 External Libraries: Further fix jQuery deprecations in WordPress core.
This addresses `JQMIGRATE` warnings in some admin files and the Thickbox library.

Follow-up to [50001], [50270].

Props bordoni, poena.
See #51812.

git-svn-id: https://develop.svn.wordpress.org/trunk@50367 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-16 20:23:19 +00:00
Sergey Biryukov
e23d442cd9 Twenty Nineteen: Add some space between the cookies checkbox and label in comment form.
Props sabernhardt, garrett-eclipse, mukesh27, monikarao, Boniu91.
Fixes #46601.

git-svn-id: https://develop.svn.wordpress.org/trunk@50365 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-16 20:13:48 +00:00
Kelly Choyce-Dwan
55f2f3f67b Twenty Twenty-One: Remove background color from Social Links the dark gray style.
This block variation doesn't support custom colors, so allowing a background color leads to a mismatch between frontend and editor styles.

Props poena, paaljoachim, audrasjb.
Fixes #52499.



git-svn-id: https://develop.svn.wordpress.org/trunk@50364 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-16 20:10:19 +00:00
Sergey Biryukov
944830428d Accessibility: Taxonomy: Correct keyboard navigation for the Tags meta box in classic editor.
Props sabernhardt, almendron, jose64, alexstine, joedolson, ryokuhi.
Fixes #52408.

git-svn-id: https://develop.svn.wordpress.org/trunk@50363 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-16 20:02:35 +00:00
Sergey Biryukov
729873ddda Administration: Apply the months_dropdown_results filter separately from pre_months_dropdown_query.
Follow-up to [50163].

Props hellofromTonya.
Fixes #51660.

git-svn-id: https://develop.svn.wordpress.org/trunk@50362 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-16 19:56:13 +00:00
Sergey Biryukov
0ff408d563 Twenty Ten: Correct the fallback to the default header if the featured image width is narrower than the twentyten_header_image_width setting.
Follow-up to [45581].

Props sabernhardt, macmanx, audrasjb.
Fixes #52516.

git-svn-id: https://develop.svn.wordpress.org/trunk@50361 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-16 19:25:26 +00:00
Sergey Biryukov
0337b93b01 Twenty Eleven: Correct the fallback to the default header if the featured image width is narrower than the twentyeleven_header_image_width setting.
Follow-up to [45581].

Props sabernhardt, macmanx, audrasjb.
See #52516.

git-svn-id: https://develop.svn.wordpress.org/trunk@50360 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-16 19:24:40 +00:00
Sergey Biryukov
5334a8dcca Twenty Twenty: Make sure the RTL list styles are preserved after npm run build.
Adjust the padding value for better consistency.

Props desrosj, sabernhardt, ryelle, mukesh27.
Fixes #52401.

git-svn-id: https://develop.svn.wordpress.org/trunk@50359 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-16 19:09:55 +00:00
Kelly Choyce-Dwan
686448dde2 Bundled Themes: Fix alignment and styles for quote, verse, and code blocks.
Updates older themes to fix alignment, spacing, and font issues to better match the frontend display. Applies to themes: Twenty Eleven, Twenty Thirteen, Twenty Fourteen, Twenty Sixteen, Twenty Seventeen, and Twenty Twenty.

Props burnuser, talldanwp, cristinasoponar, poena, kjellr
Fixes #52009.



git-svn-id: https://develop.svn.wordpress.org/trunk@50358 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-16 18:57:31 +00:00
John Blackbourn
28bc6a08cf Posts, Post Types: Update the styling of the legacy Links editing screen.
This brings its styling inline with other meta boxes in the admin area.

Props antonlukin, kburgoine, grzim, sabernhardt, pbiron, audrasjb

Fixes #48782


git-svn-id: https://develop.svn.wordpress.org/trunk@50357 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-16 18:47:39 +00:00
Sergey Biryukov
563ea09789 Filesystem API: Make sure to only call fread() on non-empty files in the PclZip library.
This avoids a fatal error on PHP 8 caused by passing a zero value to `fread()` as the `$length` argument, which must be greater than zero.

Props yakimun, fierevere, jrf, DavidAnderson, SergeyBiryukov.
Fixes #52018.

git-svn-id: https://develop.svn.wordpress.org/trunk@50355 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-16 18:40:29 +00:00
John Blackbourn
22618cef9a Feeds: Fix the URL returned by get_feed_link() when pretty permalinks are not in use.
Props hauvong, peterwilsoncc, SergeyBiryukov

Fixes #51839


git-svn-id: https://develop.svn.wordpress.org/trunk@50354 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-16 17:32:58 +00:00
Sergey Biryukov
8bd8ead1da XML-RPC: Pass the method arguments and the XML-RPC server instance to the xmlrpc_call action.
This provides better context and makes the action easier to use when the call passes specific content in the payload of the request.

Props dd32.
Fixes #52524.

git-svn-id: https://develop.svn.wordpress.org/trunk@50353 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-16 17:01:46 +00:00
Joe Dolson
4e4837d9b1 Media: Associate upload errors and field with controls.
Adds an explicit relationship between the upload button and the maximum upload limit, moves focus to the error dismiss button if an error occurs, and adds a call to wp.a11y.speak to report the error after it occurs.

Props afercia, anevins, antpb, adamsilverstein, poena
Fixes #47120

git-svn-id: https://develop.svn.wordpress.org/trunk@50352 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-16 04:03:37 +00:00
Peter Wilson
d9ceb1c434 Twenty Twenty-One: Display inline-images inline.
Remove `display: block` property from inline images and display them center aligned vertically.

Props jeroenrotty, melchoyce, mukesh27, paaljoachim, poena, talldanwp.
Fixes #52287.



git-svn-id: https://develop.svn.wordpress.org/trunk@50351 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-16 02:24:11 +00:00
Peter Wilson
62614d976b Twenty Twenty-One: Match bullets between editor and frontend.
Change bullet style on frontend nested unordered lists to `circle` to match the editor styles.

Props poena, mukesh27, mahfuz01, tejwanihemant.
Fixes #52412.



git-svn-id: https://develop.svn.wordpress.org/trunk@50350 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-15 23:50:06 +00:00
Peter Wilson
ed55dc802e Twenty Twenty-One: Add CSS source map files to committed files.
Remove `*.css.map` files from the ignore properties of Twenty Twenty-One directories, add the unignored files.

Props poena, peterwilsoncc.
Fixes #52377.



git-svn-id: https://develop.svn.wordpress.org/trunk@50348 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-15 23:09:27 +00:00
Kelly Choyce-Dwan
caffd32f52 Bundled Themes: Support font size option for code block.
Adds font-size support to Twenty Fourteen, Twenty Sixteen, and Twenty Seventeen.

Props poena, paaljoachim, peterwilsoncc.
Fixes #52431.



git-svn-id: https://develop.svn.wordpress.org/trunk@50347 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-15 18:54:02 +00:00
Kelly Choyce-Dwan
c3bf0a2fec Twenty Thirteen: Fix alignment of child blocks within the Cover block.
Props kjellr, melchoyce.
Fixes #51224.



git-svn-id: https://develop.svn.wordpress.org/trunk@50346 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-15 18:31:01 +00:00
Riad Benguella
9cab116980 Block Editor: Update packages with bug fixes to be included in WP 5.7 beta 3.
The updated packages are:

@wordpress/block-directory: 1.18.6 -> 1.18.7
@wordpress/block-editor: 5.2.6 -> 5.2.7
@wordpress/block-library: 2.28.3 -> 2.28.4
@wordpress/edit-post: 3.26.6 -> 3.26.7
@wordpress/editor: 9.25.6 -> 9.25.7
@wordpress/format-library: 1.26.6 -> 1.26.7
@wordpress/reusable-blocks: 1.1.6 -> 1.1.7

Props isabel_brison.
Fixes #52525.


git-svn-id: https://develop.svn.wordpress.org/trunk@50343 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-15 08:27:50 +00:00
Dominik Schilling
93e961bd76 Docs: Improve parameter types for various URL functions and filters that also accept null.
See #51800.

git-svn-id: https://develop.svn.wordpress.org/trunk@50340 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-13 15:15:00 +00:00
Greg Ziółkowski
e3a98e8f55 Blocks: Add missing apiVersion field when preparing server-registered blocks for the block editor
When working on changes to @wordpress/create-block tool (https://github.com/WordPress/gutenberg/pull/28883) to use register_block_type_from_metadata with block.json file in the templates for scaffolded blocks I run into this issue where apiVersion wasn't exposed from the server.

Fixes #52512.



git-svn-id: https://develop.svn.wordpress.org/trunk@50297 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-12 15:58:53 +00:00
Sergey Biryukov
d271a206db Block Editor: Remove extra quotes from the default font stack for editor styles.
Follow-up to [50155].

Props dd32, Joen, kafleg.
Fixes #46169.

git-svn-id: https://develop.svn.wordpress.org/trunk@50295 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-12 07:53:28 +00:00
Peter Wilson
a55a9183bc Site Health: Update site-health script dependencies.
Add `wp-hooks` and `wp-i18n` to Site Health JavaScript dependencies.

Props gmariani405, Clorith, mukesh27.
Fixes #52483.


git-svn-id: https://develop.svn.wordpress.org/trunk@50294 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-12 00:08:16 +00:00
Peter Wilson
37f41ee040 Twenty Twenty-One: Correct accent marks in block pattern alt text.
Correct accents in "Roses Trémières" for block patterns and starter content.

Props audrasjb, geekzebre, kjellr, SergeyBiryukov.
Fixes #52500.



git-svn-id: https://develop.svn.wordpress.org/trunk@50293 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-12 00:01:08 +00:00
Peter Wilson
f9b901549b Canonical: Rename wp_force_plain_ugly_permalink() to match UI terminology.
Rename `wp_force_plain_ugly_permalink()` to `wp_force_plain_post_permalink()` to match terminology used in the WordPress dashboard.

Follow up to [50132].
Props SergeyBiryukov.
Fixes #5272.



git-svn-id: https://develop.svn.wordpress.org/trunk@50282 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-10 05:38:23 +00:00
Jonathan Desrosiers
26b3fa70a3 Post WordPress 5.7 Beta 2 version bump.
git-svn-id: https://develop.svn.wordpress.org/trunk@50281 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-09 20:38:37 +00:00
Jonathan Desrosiers
c351ffcb1c WordPress 5.7 Beta 2.
git-svn-id: https://develop.svn.wordpress.org/trunk@50280 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-09 20:24:56 +00:00
Kelly Choyce-Dwan
a25e5988dd Administration: Update color contrast on UI elements.
The color palette changes in #49999 introduced some contrast issues on buttons, input elements, and links. This change ensures that all interactive elements have an appropriate contrast ratio.

Follow-up to [50025].
Props audrasjb, joedolson.
Fixes #52402.



git-svn-id: https://develop.svn.wordpress.org/trunk@50278 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-09 19:45:47 +00:00
Sergey Biryukov
93db55f9be Twenty Twenty: Make ordered list styling in classic editor match the front-end style.
Props sabernhardt, sebastienserre, hareesh-pillai.
Fixes #50454.

git-svn-id: https://develop.svn.wordpress.org/trunk@50275 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-09 17:53:00 +00:00
Anthony Burchell
5f2d089fb3 Media: Make adjacent_image_link() include alt text when returning an image.
When using the `adjacent_image_link()` function there is a condition that will return a linked image. Previously, the returned image was sent without alt attributes.

Now, `adjacent_image_link()` will include alt attributes of the image's title when an image is returned.

Props joedolson, Mista-Flo, sabernhardt.
Fixes #52387.


git-svn-id: https://develop.svn.wordpress.org/trunk@50274 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-09 17:25:18 +00:00
Sergey Biryukov
22ffa08799 Twenty Twenty-One: Use correct value for the global line-height CSS variable.
Props acerempel, mukesh27, dd32, poena.
Fixes #52477.

git-svn-id: https://develop.svn.wordpress.org/trunk@50273 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-09 17:08:31 +00:00
Sergey Biryukov
0ff5b67127 Site Health: Link to the support article on troubleshooting in "There has been a critical error" message.
This page is more geared towards users than the one on debugging, which is more developer-oriented.

Props audrasjb, Clorith, Ipstenu.
Fixes #52392.

git-svn-id: https://develop.svn.wordpress.org/trunk@50272 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-09 16:57:06 +00:00
John Blackbourn
22cd0a3b9e Comments: Extend the duration of the window within which unapproved comments are visible by their author.
This extension is necessary because the comment approval notification opt-in form introduced in [47887] uses the same mechanism, and the previous limit of one minute meant that users on a slow connection, using assistive technology, with limited motor skills, or who are generally indecisive may not complete the opt-in action within one minute, and therefore not see the confirmation message.

Props joedolson, imath, hellofromTonya, peterwilsoncc, alexstine, davidbaumwald 

Fixes #52406


git-svn-id: https://develop.svn.wordpress.org/trunk@50271 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-09 16:55:29 +00:00
Sergey Biryukov
93e1d628d0 External Libraries: Further fix jQuery deprecations in WordPress core.
This addresses `JQMIGRATE` warnings in the `image-edit.js` library and the `imgAreaSelect` jQuery plugin

Follow-up to [50001].

Props Clorith, poena, dariak, jeroenrotty.
See #51812.

git-svn-id: https://develop.svn.wordpress.org/trunk@50270 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-09 16:43:44 +00:00
Jonathan Desrosiers
73c1b28ec7 Twenty Twenty-One: Prevent Dark Mode related JavaScript error.
This prevents an `Uncaught TypeError` in the block editor when scrolling caused by the absence of a `#dark-mode-toggler` element.

Props ocean90, mukesh27, justinahinon.
Fixes #52473.

git-svn-id: https://develop.svn.wordpress.org/trunk@50269 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-09 14:54:48 +00:00
John Blackbourn
f0e3ab49b3 Posts, Post Types: Clarify the documentation about the return value of get_post() when a falsey value is passed.
Props Rahe, juliobox, peterwilsoncc, hellofromTonya, audrasjb

Fixes #33068


git-svn-id: https://develop.svn.wordpress.org/trunk@50266 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-09 13:42:58 +00:00
Sergey Biryukov
a4cb795001 Docs: Update some recently added inline comments per the documentation standards.
Follow-up to [50256], [50258], [50259].

See #51800.

git-svn-id: https://develop.svn.wordpress.org/trunk@50264 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-09 12:32:54 +00:00
Sergey Biryukov
0b8b1f4006 Site Health: Clarify the recommendation in file uploads test when post_max_size is defined as 0.
This adds a more descriptive text in scenarios where `post_max_size` and `upload_max_filesize` differ, and `post_max_size` is set to a value of `0`.

In some scenarios, PHP may read `0` as a literal zero size, and not as unlimited, which it also means in other scenarios.

See https://www.php.net/manual/en/ini.core.php#ini.post-max-size for details, as PHP 5.3.4 introduced this behavior for literal zero interpretation when the content type of a request is `application/x-www-form-urlencoded` or is not registered with PHP.

Props Clorith, pixolin, helen, ratneshk.
Fixes #51466.

git-svn-id: https://develop.svn.wordpress.org/trunk@50263 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-09 12:04:01 +00:00
Peter Wilson
c25dcaf5e8 Twenty Twenty-One: Update editor styles of search block.
Update editor styles to more closely match the front-end following upstream changes.

Props poena, paaljoachim, hellofromTonya.
Fixes #52433.



git-svn-id: https://develop.svn.wordpress.org/trunk@50262 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-09 03:53:14 +00:00
Peter Wilson
59ff18165e Twenty Twenty-One: Adapt vertical buttons to text length.
Display vertically aligned buttons as inline elements.

Props poena, paaljoachim, hellofromTonya, jeroenrotty, rolfsiebers.
Fixes #52432.



git-svn-id: https://develop.svn.wordpress.org/trunk@50261 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-09 03:42:43 +00:00
Peter Wilson
223bd0ee52 Twenty Twenty-One: Support font size option for code block.
Props poena, paaljoachim, hellofromTonya.
See #52431.



git-svn-id: https://develop.svn.wordpress.org/trunk@50260 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-09 03:22:42 +00:00
Robert Anderson
385c29b49a Fix wp.i18n.isRTL()
Fixes a bug causing wp.i18n.isRTL() to return false in RTL langauges by manually
loading the translated 'ltr' string for the i18n dependency. This ports over an
identical fix that was made in Gutenberg.

Fixes #52441.
Props @jonsurrell @youknowriad.


git-svn-id: https://develop.svn.wordpress.org/trunk@50259 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-08 23:49:33 +00:00
Anthony Burchell
27a113951b Media: Allow post_date to be respected in media_handle_sideload().
Previously, date information was unable to be changed when using `media_handle_sideload()`. 

Now you can override the date for a media item using `$post_data['post_date']` before using the function.

Props jamesgol, mukesh27, SergeyBiryukov, hellofromTonya, Mista-Flo.
Fixes #50972.


git-svn-id: https://develop.svn.wordpress.org/trunk@50258 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-08 23:20:56 +00:00
Peter Wilson
2e23c29603 Posts/Post Types: Improve documentation of get_posts().
Add references to `WP_Query` to the documentation of `get_posts()`. As the developer documentation for `WP_Query` includes an expanded explanation a full link to developer.wordpress.org is included rather than a standard `@see`.

Props dam6pl, peterwilsoncc.
See #51852, #51800.



git-svn-id: https://develop.svn.wordpress.org/trunk@50257 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-08 22:50:36 +00:00
Anthony Burchell
de258c87e6 Media: Pause any playing media when closing the the media modal.
Previously, any video or audio playing in the media modal failed to stop playing when the modal was closed. Now we pause the player when the modal is closed.

Props adamsilverstein, hellofromTonya, paaljoachim, Mista-Flo, Clorith, justinahinon, afercia, amolv.
Fixes #48562.


git-svn-id: https://develop.svn.wordpress.org/trunk@50256 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-08 21:42:43 +00:00
Dominik Schilling
df0c776d1f Block Editor: Use a unique name for the nonce of the custom fields toggle form.
Avoids a browser warning for having two elements with a non-unique id `#_wpnonce` on the post edit screen.

See #23165.
Fixes #51483.
Props vandestouwe, Mista-Flo.

git-svn-id: https://develop.svn.wordpress.org/trunk@50255 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-08 21:37:34 +00:00
Kelly Choyce-Dwan
fb37bfa8e1 Privacy: Update colors to match new color palette.
Follow-up to [50161].
Props xkon.
Fixes #52436.



git-svn-id: https://develop.svn.wordpress.org/trunk@50238 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-08 19:13:09 +00:00
Kelly Choyce-Dwan
9c8e17821a Administration: Fix background color of plugin update row on small screens.
When the color change was done, the background of plugins with updates had to be manually changed. This section was missed, which caused a visual bug. This fix also removes some redundant CSS for the same element.

Follow-up to [50025].
Props afragen.
Fixes #52452.



git-svn-id: https://develop.svn.wordpress.org/trunk@50237 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-08 16:11:34 +00:00